Commit Graph

3685 Commits

Author SHA1 Message Date
Ludovic Marie d0d5e79f1a Structures: honour a carried mod's start and placement rules
Repurposed Structures' and Moog's jigsaws check biomes and terrain height in
a radius and refuse to start in liquid; their spreads keep a minimum
distance from the world origin and away from several other sets. Carry maps
them to vanilla's jigsaw and random spread and writes those rules under
horizon: keys; the game now runs them (start_checks.rs, the spread's
min distance and exclusion sets). Vanilla data has none of the keys.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:38:59 +02:00
Ludovic Marie 65732406fc Carry: take processors written in Java out of their lists
The game, like vanilla, refuses a processor list holding a type it does not
know, and with it every pool naming the list, so those structures did not
generate at all. Carry now takes the library types out of processor lists
(files and inline ones in pool elements) and counts them by type in the
carry report: the structures generate, undecorated. On ATM10's carried
mods: 1,427 processors of 146 types; pool decode failures 31 -> 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:38:10 +02:00
Ludovic Marie f72c8674ad Carry: the start and placement rules of mapped jigsaws
Repurposed Structures' and Moog's jigsaws and spreads add rules on top of
vanilla's; mapped to vanilla they were lost, and Moog's spreads structures
1.65 times as far apart as its files say, so MVS alone started 9x as often
as on NeoForge. Carry now writes the start rules under
horizon:start_checks, the minimum distance and the super exclusion zone's
sets (from the mod's structure set tags) under horizon: placement keys,
and scales Moog's spacing. Layout rules (piece clipping, burying) are still
lost and counted in the carry report's rules_lost.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:38:10 +02:00
Ludovic Marie 7d27950e31 Carry: write worldgen block states in 26.3's shape
1.21.1 writes a block or fluid state in worldgen JSON as {"Name", "Properties"};
26.3's codec reads {"id", "properties"} and refuses the old shape, so every
processor list, feature or pool holding one failed to decode. Carry now
rewrites them. On ATM10's carried mods: 1,005 files in 17 mods.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:38:09 +02:00
Ludovic Marie 9190d14b7f Block registry: read facts.json as it streams
The game and the assets step each parsed facts.json into a JSON tree, then
copied each state into an NBT tree, before building the registry. With a
pack's 214,000 states each step peaked at 816 MB for a 139 MB registry.
The registry now deserializes the rows it needs straight from the file
(each row's state and its air and fluid columns, and the defaults):
registry peak 816 -> 153 MB, assets peak 816 -> 235 MB, RSS after the
assets step 1,344 -> 442 MB. Vanilla: 138 -> 27 MB.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:35:28 +02:00
Ludovic Marie 2932704156 Region files: write each saved chunk in place, as vanilla's RegionFile
Saving a chunk read every chunk of its region file and wrote them all to a
new file. The writer now writes only the saved chunk, into the first free
run of sectors (RegionBitmap), points the header at it and then frees its
old sectors (RegionFile.write / clear), with one flush per region and batch.
Readers and the writer share one open file per region. A chunk queued again
before the writer reached it is written once, by its newest batch
(IOWorker.pendingWrites).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:19:55 +02:00
Ludovic Marie b540ccb642 Brewing stands tick in the level's block entity ticker list
Brewing stands were the last server ticker with a pass of its own over the
whole block entity map every tick. They now tick in their place in
Level.blockEntityTickers, as BrewingStandBlock.getTicker makes them: in
list order, only in block-ticking range and inside the world border, with
their bottle states written as each one ticks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:17:44 +02:00
Ludovic Marie c2f3d01ee4 Merge remote-tracking branch 'pr/779' into integ/mp-sh
# Conflicts:
#	mods/horizon/src/test/java/dev/horizonlab/parity/LocatorBarClient.java
2026-10-18 06:35:13 +02:00
Ludovic Marie 6e7b34d5b8 Merge remote-tracking branch 'pr/790' into integ/mp-sh 2026-10-18 06:34:57 +02:00
Ludovic Marie 1541086b21 Merge remote-tracking branch 'pr/767' into integ/mp-sh 2026-10-18 06:34:56 +02:00
Ludovic Marie 6829da90f2 Merge remote-tracking branch 'pr/769' into integ/mp-sh
# Conflicts:
#	tools/lan_e2e.py
2026-10-18 06:34:56 +02:00
Ludovic Marie 4029475397 Merge remote-tracking branch 'pr/766' into integ/mp-sh 2026-10-18 06:34:38 +02:00
Ludovic Marie daa8b2f528 Merge remote-tracking branch 'pr/760' into integ/mp-sh
# Conflicts:
#	tools/lan_e2e.py
2026-10-18 06:34:26 +02:00
Ludovic Marie e6f0384dda Merge remote-tracking branch 'pr/759' into integ/mp-sh 2026-10-18 06:34:07 +02:00
Ludovic Marie 85fa29ee7a Merge remote-tracking branch 'pr/764' into integ/mp-sh 2026-10-18 06:34:06 +02:00
Ludovic Marie 319343992e Merge remote-tracking branch 'pr/763' into integ/mp-sh 2026-10-18 06:34:05 +02:00
Ludovic Marie f683d359a2 Merge remote-tracking branch 'pr/762' into integ/mp-sh 2026-10-18 06:34:04 +02:00
Ludovic Marie 0fbb7bdd0b Merge remote-tracking branch 'pr/756' into integ/mp-sh 2026-10-18 06:34:04 +02:00
Ludovic Marie 092dc7c641 Merge remote-tracking branch 'pr/754' into integ/mp-sh 2026-10-18 06:34:02 +02:00
Ludovic Marie 14f58d85e0 Merge remote-tracking branch 'pr/753' into integ/mp-sh 2026-10-18 06:34:02 +02:00
Ludovic Marie 2ac362f1d3 Merge pull request #813 from ludovic111/perf/dedicated-no-mesh
🤖 Agent: merged: no meshing on a dedicated server. Combined check of main + perf-ticks-6's six: clippy, tests, 8 harnesses PASS.
2026-10-18 06:33:51 +02:00
Ludovic Marie b63debb376 Merge pull request #793 from ludovic111/perf/creaking-heart-scan
🤖 Agent: merged: creaking heart scan only in sections whose palette holds a heart (240→3 ms per 15 s). Combined check of main + perf-ticks-6's six: clippy, tests, 8 harnesses PASS.
2026-10-18 06:33:46 +02:00
Ludovic Marie 2e2f4a6581 Merge pull request #809 from ludovic111/fix/ask-server-suggestions
🤖 Agent: merged: ask_server suggestions. Combined check of main + perf-ticks-6's six: clippy, tests, 8 harnesses PASS.
2026-10-18 06:33:41 +02:00
Ludovic Marie 0436c9470d Merge pull request #808 from ludovic111/fix/server-titles
🤖 Agent: merged: /title reaches guests and the server thread. Combined check of main + perf-ticks-6's six: clippy, tests, 8 harnesses PASS.
2026-10-18 06:33:36 +02:00
Ludovic Marie 4fb261fd30 Merge pull request #807 from ludovic111/fix/guest-death-health
🤖 Agent: merged: dead guest gets health 0. Combined check of main + perf-ticks-6's six: clippy, tests, 8 harnesses PASS.
2026-10-18 06:33:32 +02:00
Ludovic Marie e19803aa62 Merge pull request #806 from ludovic111/perf/chunk-ticket-levels
🤖 Agent: merged: vanilla FULL ticket square per server player (RD32 finished chunks 8809→4761, spawn CPU 153→98 s). Combined check of main + perf-ticks-6's six: clippy, tests, 8 harnesses PASS.
2026-10-18 06:33:27 +02:00
Ludovic Marie 5f49a85a4a Merge pull request #817 from ludovic111/perf/surface-rules
🤖 Agent: merged the shared ore-vein richness sample (surface −8% alone, −14% with #801; byte-identical, 19 worldgen harnesses pass).
2026-10-18 06:22:08 +02:00
Ludovic Marie 999c532a57 Merge pull request #801 from rdbtCVS/t3/optimize-surface-generation-upstream
🤖 Agent: merged rdbt's constant surface material-rule branches (surface −6%; byte-identical on four dimension/seed hashes, 19 worldgen harnesses pass; review in the thread).
2026-10-18 06:18:08 +02:00
Ludovic Marie cf97a5e1dc Decoration order: dense grids instead of hash maps
vanilla_order replays vanilla's ticket scheduler over every chunk in view
each time the player crosses into another chunk, on the render thread. At
render distance 32 that is about 200,000 level updates in SipHash maps:
8 ms per call. Over dense grids covering the square it can touch, the
same replay takes 1 ms. A test checks the order against the hash map
version for several centres and radii.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 05:44:08 +02:00
Ludovic Marie 65fc3b9f94 Content mods: structure mods' worldgen joins the worldgen bundles
A content mod's data/<ns>/worldgen/ files were copied into the content root,
where nothing reads them: the worldgen loader reads bundles. The build now
adds a mod's structures, structure sets, template pools, processor lists and
configured and placed features to their bundles, its data/<ns>/structure/
templates to worldgen/structure/<ns>/, and its biome tags to the biome tag
bundle. The loader refuses a biome tag naming what it lacks (another mod's
biomes, a loader's convention tags), so those entries are dropped, as they are
from block and item tags. Biomes, noise and density functions stay out: they
would change vanilla's terrain.

Structure and placement types Horizon does not have stay unsupported, as
before; carry-over maps the common mod ones next.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 05:24:48 +02:00
Ludovic Marie 6f7096b396 Ore veins: sample shared richness once, index the volume without division
26.3's copper and iron vein rules both bind minecraft:overworld/ore_vein/richness
eagerly, so the material stage sampled the same root over the same chunk volume
twice. Bindings of one compiled root now share its buffer; sampling is
deterministic, so the values are identical.

The two vein density reads per solid block went through
DensityVolume::index_of_block, which divides and takes the remainder by the
step on each axis. The stage's volumes are unit-step, so index them directly
(falling back for strided volumes).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 05:00:16 +02:00
Ludovic Marie ff6e01de03 Command suggestions: ask the server for nodes the tree marks ask_server
A remote client's chat now sends ServerboundCommandSuggestionPacket for an
argument node whose provider is minecraft:ask_server (bossbar ids, data
storage, datapacks, team names, functions...), as ClientSuggestionProvider.customSuggestion
does. The suggestions are done when ClientboundCommandSuggestionsPacket
answers that id; its completions join the local ones (Suggestions.merge).
Replies to older requests are dropped.

The remote tree takes each node's provider from the packet only: a local
provider the server didn't send stood in for the server's before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 04:57:29 +02:00
Ludovic Marie 0f482a45c8 Dedicated server: never mesh sections
A dedicated server draws nothing, like the integrated server, yet its
streaming still meshed every section it lit (Streaming::mesh followed only
options.integrated). It now skips meshing too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 04:49:06 +02:00
rdbtCVS c47b30fcf0 Optimize binary density, Beardifier and Perlin sampling 2026-10-18 03:49:02 +01:00
Ludovic Marie 9f7bd91109 Merge pull request #789 from ludovic111/perf/entity-culling
🤖 Agent: merged vanilla shouldRender culling for boats, paintings, item frames, armor stands, TNT, tridents and fireworks (~525 entities: FPS 107→141; only entities beyond vanilla's range disappear).
2026-10-18 04:41:28 +02:00
Ludovic Marie e627842ede Merge pull request #788 from ludovic111/perf/occlusion-async
🤖 Agent: merged cave culling on a worker thread (RD32 prepare 10.3→1.0 ms, p99 275→208 ms, FPS 116→135; drawn sections identical in all 18 views; 89/89 harnesses).
2026-10-18 04:12:15 +02:00
rdbtCVS d370364f12 Specialize constant material rule branches after binding 2026-10-18 03:11:34 +01:00
LookImEcho-Rick c1211b2245 Fix execute source dimension for player teleports 2026-10-17 21:08:53 -05:00
Ludovic Marie c12f5cf41a Server titles: /title reaches the guest, and its HUD shows and clears them
TitleCommand sends the targeted player ClientboundSetTitleText,
SetSubtitleText, SetActionBarText, SetTitlesAnimation and ClearTitles. A
guest's /title (the window's own player on the server thread too) only
changed the server's HUD; it is now sent to the guest. The remote client
showed titles and action bars as a bare line and ignored subtitles, times
and clearing; it now feeds the HUD's titles as ClientPacketListener does
(the action bar of a SystemChat overlay too) and ticks them (Gui.tick).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 04:00:48 +02:00
Ludovic Marie 65d5a35cd2 Server: a dead guest is sent its health of 0, as ServerPlayer.doTick does
The hub held SetHealth back once a guest died, so the guest's health
stayed at its last positive value under the death screen. ServerPlayer
sends it every tick it changes, dead or not, and only when the health or
the food level changes or the saturation reaches or leaves zero: the hub
sent it on every change of saturation too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 04:00:24 +02:00
Ludovic Marie c6531e4bde Server players finish vanilla's FULL square, not a 1.5x circle
DistanceManager.PlayerTicketTracker gives every chunk within the server's
view distance (Chebyshev) of a player a PLAYER_LOADING ticket at level 31,
so FULL (33) reaches two chunks past it and FEATURES and TERRAIN one and
two more. A server player's streaming area was a circle of radius
(view distance + 2) * 3 / 2 + 1, finished one further: 2.1x the chunks at
view distance 12. It is now that square, and lan status reports the
server world's chunk counts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 04:00:23 +02:00
Ludovic Marie d223b383ee Merge pull request #798 from ludovic111/perf/block-entity-tickers
🤖 Agent: merged vanilla-order block entity ticking (new harness: 21,590/21,590 ticks match vanilla; block-entity share of the tick 19.5%→9.6% with 50 bots; 90/90 harnesses locally).
2026-10-18 03:59:14 +02:00
Ludovic Marie b651ca5f93 Merge pull request #795 from ludovic111/perf/sculk-fx-maps
🤖 Agent: merged sculk per-mob maps on the fast hasher (small win; keys are server-assigned ids).
2026-10-18 03:54:57 +02:00
Ludovic Marie 5ca2021223 Merge pull request #791 from ludovic111/perf/zlib-rs
🤖 Agent: merged zlib-rs compression (chunk deflate 1.98× faster, writer-thread deflate −60%; 222/222 harnesses locally, verify green).
2026-10-18 03:54:54 +02:00
Ludovic Marie 50daf6ecfc Merge pull request #792 from LookImEcho-Rick/codex/tooltip-display-parity
🤖 Agent: merged LookImEcho-Rick's tooltip_display parity, with its Java oracle and Rust probe.
2026-10-18 03:33:38 +02:00
Ludovic Marie f32e696eb9 Merge pull request #794 from lazy-importer/fix/creative-flight-save-persistence
🤖 Agent: merged lazy-importer's creative flight persistence across save and reload (fixes #777).
2026-10-18 03:33:33 +02:00
rdbtCVS ce77a4189d Specialize unary density evaluation per bulk buffer 2026-10-18 02:26:03 +01:00
Ludovic Marie 118bfa2be2 fix(game): finish every consumable as vanilla's Consumable.onConsume
Follow-up to #773 (consume effects on food):

- ApplyStatusEffectsConsumeEffect always draws its float and skips the
  effects when the draw is >= probability (#773 skipped the draw at 1.0
  and applied on <=).
- on_consume_effects run for every consumable, not only food: milk can be
  drunk (clear_all_effects, then the bucket), honey removes poison and
  leaves its glass bottle, stews their bowl (UseRemainder).
- The consumable's own timing, sound, animation and particles
  (consume_seconds, sound, has_consume_particles) through horizon-world's
  Consumable.emit, in vanilla's draw order; FoodProperties.onConsume's
  sound and burp; the used statistic; the eat or drink game event after
  the effects.
- teleport_randomly (chorus fruit) through horizon-world's verified
  TeleportConsume port, with LivingEntity.randomTeleport for the player
  (border clamp, entities_can_teleport_to ground, collision and liquid
  checks), the teleport game event and sound, level event 2017's
  directional particles and entity event 46's portal particles.
- tools/agent_control_e2e.py: a consume scenario (golden apple at full
  hunger, milk, honey, chorus fruit).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 03:14:29 +02:00
Ludovic Marie 209b898c02 The console's and players' command feedback reaches the operators
CommandSourceStack.broadcastToAdmins beyond a guest on a dedicated server:

- The dedicated server's console tells every operator what its commands
  did, as `[Server: ...]`, when `broadcast-console-to-ops` is on
  (DedicatedServer.shouldInformAdmins). This covers the game's commands
  and the dedicated-only ones vanilla broadcasts (op, deop, ban, pardon,
  kick, whitelist, save-all, save-on/off, stop).
- In a world open to LAN, the host, an operator when commands are
  allowed, hears of its guests' commands, and op guests hear of the
  host's.
- A player's name in the line is their display name, with the `/tell`
  suggestion, the entity hover and the insertion (Player.getDisplayName).

New harness test_server_ops_feedback_parity: two vanilla-codec
operators' system chat while the console and one of them run commands,
deop and op, toggle send_command_feedback and save, with
broadcast-console-to-ops on and off. LocatorBarClient can record system
chat (`chat on`). lan_e2e's feedback check also asserts the host is told.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 03:02:11 +02:00
Ludovic Marie 9a2d87ec97 fix(server): move players to another dimension with execute in ... run tp
On a dedicated server, `execute in <dimension> run tp @s ...` from a player
moved them inside the level they were in. It now does what vanilla's
TeleportCommand does: ServerPlayer.teleport into the other level, with the
Respawn packet keeping all data and no portal sound, then the feedback. The
players there are tracked to them and they are removed from the ones they
left.

tools/test_server_dimension_players_parity.py joins two players to a vanilla
and a Horizon server and compares, step by step, the players each is sent and
loses and the dimensions it respawns into, while they go to the Nether and
the End by command and through an End portal. LocatorBarClient gains
`players on` and `still NAME` (the position reminder a still client sends).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 03:01:56 +02:00