Commit Graph

28 Commits

Author SHA1 Message Date
Ludovic Marie a013e35a61 Collision scans: pass the rest of an outer row in a contained section at once
On the rows along a box's bottom, top and sides every cell is outer, so in a
section no block reaches out of, the rest of the row up to the chunk's edge
is passed in one step instead of cell by cell. The candidate budget still
ends the scan where it did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:17:59 +01:00
Ludovic Marie 4459f132fe Collision scans: skip the outer cells of sections no block reaches out of
BlockCollisions keeps a block on the cells around the box (Cursor3D types 1
and 2) only if it has a large collision shape or is a moving piston. Most
sections hold neither in their palette, so the scan now asks the provider
once per section and passes those cells without reading them: a mob's box
reads about a fifth of the cells it did. Same hits, same order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:44:09 +01:00
Ludovic Marie e0d29dc233 Drop the aquifer helper and correct the fire burnout comment
Stable Clippy (1.99, what CI runs) does not flag q < -2. || q > 2., so the
helper and its test only served Rust 1.90's Clippy. Fire burnout is not
'intentionally disabled': vanilla's FireBlock.tick reads the
INCREASED_FIRE_BURNOUT environment attribute, set by eight overworld biomes,
which Horizon does not read yet; the comment now says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 11:31:38 +02:00
Ganer 4b1e298a44 fix(worldgen): resolve upstream Rust 1.90 Clippy boolean warnings 2026-10-23 16:55:08 -05:00
Ludovic Marie ac60b337aa worldgen: chunks far apart still make a region (map past the grid)
TerrainRegion::new refused a region whose chunks bounding box passed
2^20 columns, where it took any set of distinct chunks before: the
bulk_section parity fixture puts a chunk at x = 4194304 beside the
origin and failed with InvalidChunks. Keep the grid for the usual small
box and fall back to a map past it; both refuse a position twice. The
lookup now subtracts in i64, so no coordinate can wrap into the grid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 15:40:07 +02:00
Ludovic Marie 2bfe3391a8 Merge branch 'perf/collision-scan' of https://github.com/ludovic111/horizon into integ-659 2026-10-19 13:50:47 +02:00
Ludovic Marie d634870f15 Structures: Repurposed's matter phase, piece origin and y value rule tests
Repurposed Structures' mineshafts and Nether monument test blocks with
three rule tests of their own. Vanilla, and the game, refuse a processor
list naming a type they do not know, and with it every pool naming the
list: the 5 Nether mineshaft start pools in a ported pack never load.

The game now runs them under its own types, with the mod's fields:

- horizon:matter_phase (MatterPhaseRuleTest): solid (not air, no fluid,
  canOcclude), liquid, air, and air or liquid with rails and chains,
  optionally inverted. Structure processors now bind the block
  properties to read canOcclude.
- horizon:piece_origin_axis_aligned_linear_pos: vanilla's axis-aligned
  chance over the block's distance from its template's origin.
- horizon:y_value: the block's world height in a range.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 20:48:34 +02:00
Ludovic Marie c717628169 Merge pull request #827 from ludovic111/perf/region-in-place
🤖 Agent: merged: chunks saved in place in their region file, as vanilla (save into a full region 80.3→7.1 ms). perf-ticks-7's four PRs together on main d85a3603: clippy, 861 client + world tests, 19 harnesses (light, lan, dedicated_server, save_roundtrip, world_reopen, disk, datafix ×6, world, server_world_gen, block_entity ×4, chunk_stage) PASS.
2026-10-18 09:45:19 +02:00
Ludovic Marie 2932704156 Region files: write each saved chunk in place, as vanilla's RegionFile
Saving a chunk read every chunk of its region file and wrote them all to a
new file. The writer now writes only the saved chunk, into the first free
run of sectors (RegionBitmap), points the header at it and then frees its
old sectors (RegionFile.write / clear), with one flush per region and batch.
Readers and the writer share one open file per region. A chunk queued again
before the writer reached it is written once, by its newest batch
(IOWorker.pendingWrites).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 07:19:55 +02:00
Ludovic Marie 14f58d85e0 Merge remote-tracking branch 'pr/753' into integ/mp-sh 2026-10-18 06:34:02 +02:00
rdbtCVS d370364f12 Specialize constant material rule branches after binding 2026-10-18 03:11:34 +01:00
Ludovic Marie 2e531f35e5 Per-state tables: check state identities while reading, never as a tree
occlusion.nbt, cached-collision.nbt, cached-support.nbt, block-properties.nbt and
movement-properties.nbt each carry the identity of every block state, and every
loader parsed them into an NBT tree first: 240 MB per table for ATM10's 153,511
states, about 1.4 GB allocated and freed while the game starts.

nbt::read_named_streaming hands a named list to a visitor element by element.
registry::BlockTableFile reads a table that way, checking each state against the
registry as it comes, and loaders build from a checked registry::BlockTable.
from_nbt stays for trees built in memory (tests, fixtures).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 21:25:11 +02:00
Ludovic Marie 4d1596fe3b Load ATM10's 42 carried mods: room past 8,192 textures and tags
With the wide state ids, ATM10's 42 data-tier mods (193,762 states)
reach the world once these loaders stop refusing them:

- Block sprites: eight texture arrays of 2048 layers instead of four
  (9,790 block textures for the 42).
- Per-state tables read as NBT: the table limits cover 2^20 states, and
  the collision table in level data uses them.
- Worldgen block tags: 2^20 blocks instead of 8,192 (mineable/pickaxe
  holds every stone block of a pack).
- As vanilla's loaders do, a blockstate definition that does not bind,
  a missing or broken block model of a mod, and a recipe that does not
  parse are logged and skipped instead of dropping every mod (or
  stopping the game).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 09:12:41 +02:00
Ludovic Marie a3bf174ddb Collision scans: a counting cursor, and fewer lookups and allocations per block
Block collision scans (vanilla's BlockCollisions) are most of every mob's
move, and moves were the largest share of the world tick with 600 mobs.
Per cell and per hit, the scan did work vanilla's JIT makes cheap:

- the cursor divided its index by the box width and height for every cell;
  it now counts x, then y, then z, as Cursor3D does (same cells, same order,
  same budget);
- the unit cube test cloned the shared unit cube to compare identities
  (`VoxelShape::is_block` compares with it in place), and built a
  normalised box to test it against the entity box (`intersects_corners`);
- every non-empty block looked its state up in the contextual rule map
  (scaffolding, liquids, powder snow); a flag in the scan table now says
  which states have one;
- a moved shape decomposed its occupancy into boxes again; the moved
  shape's boxes are its own boxes moved, the same values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 05:55:21 +02:00
Ludovic Marie 877165a6c9 Read region headers as vanilla's RegionFile does in the region tests
Invalid allocations are dropped rather than refused, overlaps are not
checked, and an empty or truncated file is a region without chunks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-11 16:41:30 +02:00
Ludovic Marie fe4688c8ca Match world ray clipping and fall distance reset selection 2026-10-07 01:59:47 +02:00
Ludovic Marie e45980b5c7 Match player crouching edge backoff and collision probe bounds 2026-10-07 00:56:02 +02:00
Ludovic Marie 0a6c777815 Bind registered block movement properties and reloadable tags 2026-10-07 00:43:56 +02:00
Ludovic Marie a2df9158ca Bind collision scans to registry behavior and resident chunk providers 2026-10-06 23:53:34 +02:00
Ludovic Marie 99f310c4e3 Match lazy block collision scanning and provider query order 2026-10-06 23:24:57 +02:00
Ludovic Marie 75e835558c Preserve canonical collision shape identities in registry imports 2026-10-06 23:13:27 +02:00
Ludovic Marie 18d0c44e8d Retain vanilla biomes during below-zero regeneration 2026-10-06 19:49:00 +02:00
Ludovic Marie 32ad4ba6aa Apply live chunk-upgrade permissions and retained biome status 2026-10-06 19:31:11 +02:00
Ludovic Marie b1505adc54 Enforce generation write heights during below-zero upgrades 2026-10-06 15:28:26 +02:00
Ludovic Marie e755a5920a Implement proto-chunk block-entity storage and coordinate resolution 2026-10-06 14:59:17 +02:00
Ludovic Marie 43d5793f6b Bind resident region fluid states and resolved tag queries 2026-10-06 13:57:32 +02:00
Ludovic Marie ea237d983f Implement disk replacement and chunk postprocessing marks 2026-10-06 12:25:49 +02:00
Ludovic Marie cb19660fbe Build Horizon Rust parity foundations and differential validation
Add version-bound core, world data, geometry, generation and feature implementations with native client/server comparison tools and scoped evidence reports. Apply Horizon project branding.

Workspace tests, Clippy and 147 Python tests passed. Full 51-family survival and expanded provider comparisons are still running; complete gameplay parity and a playable Rust client remain unfinished. Private game artifacts and the isolated simple-block placement work are excluded.
2026-10-06 11:24:51 +02:00