Commit Graph

2639 Commits

Author SHA1 Message Date
Ludovic Marie 0ceede079e Merge pull request #964 from ludovic111/feat/carry-apply-random-condition
🤖 Agent: merged after verify passed and parity --changed 311/311 locally. Carry for Lithostitched apply_random, condition and set_block (130 dropped → 0).
2026-10-19 06:20:48 +02:00
Ludovic Marie 9ed2f482af Merge pull request #960 from ludovic111/feat/carry-processor-references
🤖 Agent: merged after verify passed and parity --changed 311/311 locally. Lithostitched reference processors carried: 83 dropped → 0.
2026-10-19 06:20:39 +02:00
Ludovic Marie 995187d82d Merge pull request #958 from ludovic111/feat/yung-modifiers
🤖 Agent: merged after verify passed and parity --changed 311/311 locally on the integration commit. YUNG modifiers, piece_in_range and dead-end pools (game side).
2026-10-19 06:20:28 +02:00
Ludovic Marie f3a3dd22bd Merge pull request #957 from ludovic111/fix/carry-json-comments
🤖 Agent: merged after verify and CI parity passed. The carry reads data files with comments as Minecraft does; six Better Fortresses pools come back (265 → 3,765 pieces over seed 1234's Nether centre).
2026-10-19 06:20:19 +02:00
Ludovic Marie cd4f8ba849 Merge pull request #954 from ludovic111/fix/stronghold-ring-biome-search
🤖 Agent: merged after verify passed and local proof on one integration commit of modpacks-9's PRs: parity --changed 311/311, structure-start oracle 3,153/3,153. CI parity's only failure was secure_chat, which this change doesn't touch. Stronghold rings 3/128 off → 0/128 on seeds 1234, 2, 3, 42, -7.
2026-10-19 06:20:09 +02:00
Ludovic Marie ee4b4c7834 Merge pull request #962 from ludovic111/fix/level-switch-entities
🤖 Agent: merged after verify and CI parity passed (command_exec 764/764 three times locally, 20 affected harnesses). /summon no longer spawns other pending entities and takes their id; the harness settle waits for entities like vanilla's. Fixes #947.
2026-10-19 05:55:41 +02:00
Ludovic Marie c569bbe291 Merge pull request #961 from ludovic111/fix/readback-alignment
🤖 Agent: merged after verify passed. GPU readbacks (occlusion results, GPU timer) no longer assume the mapping's alignment; fixes the Vega 11 launch crash in #953.
2026-10-19 04:47:48 +02:00
Ludovic Marie 4b28390f72 docs/modpacks.md: Lithostitched's processors carried, and what they change
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:42:29 +02:00
Ludovic Marie f62e07c36a Read GPU readbacks without assuming the mapping's alignment
A Vega 11 on Windows (Vulkan) panicked at launch in bytemuck's cast_slice
with TargetAlignmentGreaterAndInputNotAligned, starting with the release
that shipped occlusion culling. The section-test results and the GPU
timer's timestamps were cast in place from the mapped range, which isn't
guaranteed to be 4- or 8-byte aligned. Copy the words out instead.

Fixes #953

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:40:00 +02:00
Ludovic Marie bb24420df2 Carry: Lithostitched's apply_random, condition and set_block as the game's
apply_random becomes horizon:apply_random: its weighted lists, or its set
of lists at weight 1, with the inline lists carried like any other (their
Java processors dropped and counted). condition becomes horizon:condition
when the game runs every condition in it (true, all_of, any_of, not,
random_chance, matching_blocks with plain property values), with its then
and else lists carried. set_block with a simple or weighted state provider
and no block entity change becomes horizon:set_block. Anything else stays
Java and is dropped as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:29:23 +02:00
Ludovic Marie 8993bd4594 Merge pull request #949 from rdbtCVS/t3/reuse-terrain-sampler-scratch
🤖 Agent: merged, thanks rdbt! Terrain sampler scratch buffers are reused between chunks; byte-identical output across the 22 world-gen parity harnesses on the combined commit.
2026-10-19 04:21:05 +02:00
Ludovic Marie 764b4e0803 Merge pull request #948 from rdbtCVS/t3/fix-issue-945
🤖 Agent: merged, thanks rdbt! Spectator scroll-wheel flight speed now follows vanilla (6,791 oracle cases); verified on the combined commit with local_input and the client tests. Fixes #945.
2026-10-19 04:20:53 +02:00
Ludovic Marie ea8964506c Merge pull request #946 from rdbtCVS/t3/dedup-neighbour-computation
🤖 Agent: merged, thanks rdbt! Checked on one commit with #948 and #949: fmt, workspace clippy -D warnings, 896 world/core/client tests, and 22 parity harnesses (biome, carving, decoration, density, structure_density, server_world_gen, world_spawn, …) all pass.
2026-10-19 04:20:41 +02:00
Ludovic Marie 8e095b88fa Carry: write Lithostitched's processor references in
lithostitched:reference runs the processors of other lists in turn.
Carry now writes their processors in its place, in order and references
in them too, from the mod's own processor lists. A reference to a tag or
to a list the mod lacks stays, and is dropped and counted as before.
ChoiceTheorem's Overhauled Village builds most of its lists this way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:17:42 +02:00
Ludovic Marie be85b81d13 YUNG's assembler: modifiers, piece_in_range and dead-end pools
Better Nether Fortresses relies on three parts of YUNG's API the game did
not have:

- piece_in_range: another piece (of some templates, or any) inside the
  piece's box grown sideways, below and above.
- Modifiers, applied once the layout is done, in piece order and with the
  assembler's random: a condition, then actions on the piece itself.
  transform swaps its template for one picked by setFeatureSeed(x, y, x)
  and moves it by an offset turned with the piece; delay_generation moves
  it to the end of the piece list.
- Dead-end pools: a piece that got no child though it has other jigsaws
  is taken out (its parent's junction, its room and its count given back)
  and a piece of its dead-end pool is chosen for the same parent jigsaw.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:06:59 +02:00
Ludovic Marie bb3ec12ed0 Carry: read data files with comments, as Minecraft does
Minecraft reads data JSON with Gson's lenient reader, which skips `//`,
`#` and `/* */` comments. Six of YUNG's template pools have them (Better
Fortresses' bridges, halls and hall ends; Better Jungle Temples' floors),
so carry refused them as unreadable and the structures lost those pieces:
seed 1234's seven Better Fortresses had 265 pieces in all, now 3,765, and
five Better Jungle Temples 170, now 196. A file that parses once its
comments are gone is carried as plain JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:06:59 +02:00
Ludovic Marie cd30aae4a8 Strongholds: sample each ring search through one biome resolver
ChunkGeneratorStructureState's ring searches call findBiomeHorizontal,
which samples its 57x57 quarts in order through one resolver; vanilla's
climate index starts each lookup from the previous result and keeps it on
a tie. Horizon built a fresh resolver for every quart, so ties went the
other way: three of seed 1234's 128 strongholds were up to 6 chunks off
(the first one 96 blocks from vanilla's). StartContext::noise_biomes
samples a batch through one resolver and the search hands it the square.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:06:59 +02:00
Ludovic Marie ab8d803d5c Merge pull request #952 from ludovic111/perf/heightmap-scan-from-surface
🤖 Agent: merged after verify and CI parity passed. tick_blocks finds the motion-blocking height from the top of the terrain: 1.98 → 1.36 ms per tick with 10 bots on the Mac mini (−31%).
2026-10-19 04:05:57 +02:00
Ludovic Marie 07f2913d53 Merge pull request #951 from ludovic111/fix/entity-ticks-ticking-area
🤖 Agent: merged after verify and CI parity passed. Non-living entities (TNT, falling blocks, boats, frames…) now tick only in entity-ticking chunks, as in vanilla.
2026-10-19 03:14:23 +02:00
Ludovic Marie 737841550f Merge pull request #950 from ludovic111/fix/natural-spawn-every-player
🤖 Agent: merged after verify and CI parity passed; 301/301 harnesses locally on the combination with #951/#952. Dedicated servers now spawn mobs around every player (0 → ~70 per bot, 139–144 for two, matching vanilla's caps).
2026-10-19 03:14:15 +02:00
Ludovic Marie c0f0c17ed4 Keep restored chunk entities out of /summon's result after a level switch
Coming back to a level, the entities saved with its chunks wait in
World::loaded_entities until the next tick spawns them, as vanilla's
PersistentEntitySectionManager.processPendingLoads does. /summon pushed its
compound onto that queue and drained all of it, so the first waiting
entity took the id counted as the summon's root: after a Nether round trip
`/summon minecraft:armor_stand ...` reported "Summoned new Pig". Summon now
spawns only its own stack and leaves the queue to the tick.

The command harness's settle now waits for the entities of the chunks
around the player as well, like the oracle's settle
(areEntitiesActuallyLoadedAndTicking), and a `portal` op sends the player
through the nether portal it stands in (Entity.handlePortal:
NetherPortalBlock.getPortalDestination, teleportToPortalDestination). The
corpus's new `levels` group makes the round trip and checks the Overworld's
pig and a summon's feedback on the way back.

Fixes #947

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 03:07:17 +02:00
rdbtCVS 2fe7cb3a4b Reuse terrain sampler scratch buffers between chunks 2026-10-19 01:23:23 +01:00
rdbtCVS 0ab07f7209 Fix spectator scroll wheel flight speed 2026-10-19 01:10:17 +01:00
rdbtCVS 6a4bed4744 Coordinate concurrent neighbour cache misses by chunk key 2026-10-19 00:52:21 +01:00
Ludovic Marie ba3a0fcf01 Merge pull request #943 from rdbtCVS/t3/reduce-carver-cache-locks
🤖 Agent: thanks rdbt! Verify passes. A per-worker memo of the carver biome lookups in front of the shared mutex: the resolved biome per origin is a pure function of seed, dimension and position, so results can't change, and the test checks eviction leaves the terrain identical. Paired benchmarks: +3.3–3.9 % terrain throughput at six workers (16 pairs, two sites), up to +5.9 % at size 32, no single-worker regression.
2026-10-19 01:36:09 +02:00
Ludovic Marie e805e9886c Scan for the motion-blocking top from the world surface, not the build limit
getHeightmapPos(MOTION_BLOCKING) walked every column from y 319 down,
one block lookup per y. Each precipitation roll (3 in 48 per ticking
chunk per tick) and each isRainingAt paid for it: with the chunks of 10
players ticking it was most of tick_blocks. Only air lies above the
WORLD_SURFACE heightmap the chunk already keeps, and air neither blocks
motion nor holds a fluid, so the scan starts there. LevelAccess gains
world_surface (the build limit by default, so other levels scan as before).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 01:35:44 +02:00
Ludovic Marie c755ca04f5 Tick paintings, frames, boats, armor stands, falling blocks and TNT only in entity-ticking chunks
ServerLevel.tick ticks an entity only where the chunk tickets make it
entity ticking (inEntityTickingRange, and EntityTickList holds only the
entities of entity-ticking chunks). Mobs, items and minecarts already
checked it (#931); these six entity kinds ticked wherever they were
loaded, so TNT went off and sand fell past the simulation distance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 01:35:44 +02:00
Ludovic Marie 08c77ad785 Spawn mobs around every player, and despawn from the nearest of them
Natural spawning returned without a local player, so a dedicated or
--server-thread server spawned no mobs and a LAN host spawned them only
around itself. ServerChunkCache.tickChunks now takes its spawning chunks
from every player in the level (ChunkMap.collectSpawningChunks), the
global caps from the natural spawn chunk tracker's size, and the local
caps from each player (LocalMobCapCalculator). Inhabited time and
thunder follow the same chunks (tickSpawningChunk), the wandering trader
picks a random living player (getRandomPlayer), and mobs despawn by
their distance to the nearest non-spectator of any kind.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 01:35:44 +02:00
Ludovic Marie a9bcaa6ed5 Merge pull request #942 from ludovic111/fix/village-villagers
🤖 Agent: reviewed; verify passes. Ports removeWhenFarAway = false for Villager, WanderingTrader and AbstractGolem (iron/snow/copper golems, shulkers). Seed 1234 plains village: main 0 villagers, this PR 14, vanilla 26.3 server 14. 95/96 affected harnesses pass; world_spawn timed out on a busy machine, then 59/60 seeds alone (the one off is the known chunk-order flake #308). Fixes #917.
2026-10-19 01:31:13 +02:00
Ludovic Marie eaf6b03f86 Merge pull request #927 from ludovic111/fix/lazy-pair-recheck
🤖 Agent: reviewed; verify passes. Re-checked all four perf-server-10 PRs merged on current main (after #887 #931 #912 #916): fmt/clippy clean, horizon-client tests 893 passed, lan, dedicated_server, server_world_gen, chunk_stage, world_reopen, server_entities, server_player_targets, server_dimension_players pass, lan_e2e growth/plates/eating/hurt/chat/light pass in both modes (eating with --server-thread failed once in the long sequence, then passed twice alone). Numbers in the PR.
2026-10-19 01:24:19 +02:00
Ludovic Marie cdd55e54a5 Merge pull request #914 from ludovic111/perf/guest-tick-stats
🤖 Agent: reviewed; verify passes. Re-checked all four perf-server-10 PRs merged on current main (after #887 #931 #912 #916): fmt/clippy clean, horizon-client tests 893 passed, lan, dedicated_server, server_world_gen, chunk_stage, world_reopen, server_entities, server_player_targets, server_dimension_players pass, lan_e2e growth/plates/eating/hurt/chat/light pass in both modes (eating with --server-thread failed once in the long sequence, then passed twice alone). Numbers in the PR.
2026-10-19 01:23:58 +02:00
Ludovic Marie fdf4b16e72 Merge pull request #934 from ludovic111/perf/chunk-encode-workers
🤖 Agent: reviewed; verify passes. Re-checked all four perf-server-10 PRs merged on current main (after #887 #931 #912 #916): fmt/clippy clean, horizon-client tests 893 passed, lan, dedicated_server, server_world_gen, chunk_stage, world_reopen, server_entities, server_player_targets, server_dimension_players pass, lan_e2e growth/plates/eating/hurt/chat/light pass in both modes (eating with --server-thread failed once in the long sequence, then passed twice alone). Numbers in the PR.
2026-10-19 01:23:39 +02:00
Ludovic Marie d79b394086 Merge pull request #915 from ludovic111/perf/paletted-pack
🤖 Agent: reviewed; verify passes. Re-checked all four perf-server-10 PRs merged on current main (after #887 #931 #912 #916): fmt/clippy clean, horizon-client tests 893 passed, lan, dedicated_server, server_world_gen, chunk_stage, world_reopen, server_entities, server_player_targets, server_dimension_players pass, lan_e2e growth/plates/eating/hurt/chat/light pass in both modes (eating with --server-thread failed once in the long sequence, then passed twice alone). Numbers in the PR.
2026-10-19 01:23:19 +02:00
rdbtCVS 745c756df5 perf(worldgen): cache carver biomes per worker 2026-10-19 00:21:20 +01:00
Ludovic Marie 8fcae5043b Merge pull request #932 from ludovic111/feat/lithostitched-block-swap
🤖 Agent: reviewed; verify passes. Main merged into the stack (processors.rs tests kept from both sides; port-pack tests pass on each layer, clippy clean). Parity: all 269 game-side harnesses on modpacks-8's integration commit, structure-start oracle 35/35.
2026-10-19 01:07:45 +02:00
Ludovic Marie c1d2eddb5d Merge pull request #930 from ludovic111/feat/yung-chest-cap
🤖 Agent: reviewed; verify passes. Main merged into the stack (processors.rs tests kept from both sides; port-pack tests pass on each layer, clippy clean). Parity: all 269 game-side harnesses on modpacks-8's integration commit, structure-start oracle 35/35.
2026-10-19 01:07:21 +02:00
Ludovic Marie 3215ee942e Merge pull request #929 from ludovic111/feat/yung-placeholder-blocks
🤖 Agent: reviewed; verify passes. Main merged into the stack (processors.rs tests kept from both sides; port-pack tests pass on each layer, clippy clean). Parity: all 269 game-side harnesses on modpacks-8's integration commit, structure-start oracle 35/35.
2026-10-19 01:04:55 +02:00
Ludovic Marie cbd051a1d7 Merge pull request #926 from ludovic111/feat/carry-trial-spawners-vaults
🤖 Agent: reviewed; verify passes. Main merged into the stack (processors.rs tests kept from both sides; port-pack tests pass on each layer, clippy clean). Parity: all 269 game-side harnesses on modpacks-8's integration commit, structure-start oracle 35/35.
2026-10-19 01:04:30 +02:00
Ludovic Marie bc549713bb Merge feat/yung-chest-cap (with main) into feat/lithostitched-block-swap
processors.rs tests: keep both sides' tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 00:57:59 +02:00
Ludovic Marie 63044f339c Merge feat/yung-placeholder-blocks (with main) into feat/yung-chest-cap
processors.rs tests: keep both sides' tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 00:57:52 +02:00
Ludovic Marie c3595f1a9c Merge feat/carry-trial-spawners-vaults (with main) into feat/yung-placeholder-blocks
processors.rs tests: keep #929's desert temple test and #920's rule-test test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 00:57:45 +02:00
Ludovic Marie 03c423daac Merge origin/main into feat/carry-trial-spawners-vaults
processors.rs tests: keep both #926's trial spawner and vault tests and
#920's Repurposed rule-test test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 00:57:14 +02:00
Ludovic Marie 6da2963080 Merge pull request #924 from ludovic111/fix/carry-dead-vertical-distance
🤖 Agent: reviewed; verify passes. Parity: all 269 game-side harnesses on modpacks-8's integration commit (main 573f3a64 + the six game-side PRs), vanilla structure-start oracle 35/35. Merged in order #919 → #920 → #922 → #923 → #924, then the stack #926 → #929 → #930 → #932.
2026-10-19 00:52:33 +02:00
Ludovic Marie 5b9c75c017 Merge pull request #923 from ludovic111/feat/carry-small-nether-dungeon
🤖 Agent: reviewed; verify passes. Parity: all 269 game-side harnesses on modpacks-8's integration commit (main 573f3a64 + the six game-side PRs), vanilla structure-start oracle 35/35. Merged in order #919 → #920 → #922 → #923 → #924, then the stack #926 → #929 → #930 → #932.
2026-10-19 00:52:19 +02:00
Ludovic Marie d04c266edb Merge pull request #922 from ludovic111/feat/repurposed-mineshafts
🤖 Agent: reviewed; verify passes. Parity: all 269 game-side harnesses on modpacks-8's integration commit (main 573f3a64 + the six game-side PRs), vanilla structure-start oracle 35/35. Merged in order #919 → #920 → #922 → #923 → #924, then the stack #926 → #929 → #930 → #932.
2026-10-19 00:52:05 +02:00
Ludovic Marie 5f0fea0bd6 Merge pull request #920 from ludovic111/feat/carry-rule-tests
🤖 Agent: reviewed; verify passes. Parity: all 269 game-side harnesses on modpacks-8's integration commit (main 573f3a64 + the six game-side PRs), vanilla structure-start oracle 35/35. Merged in order #919 → #920 → #922 → #923 → #924, then the stack #926 → #929 → #930 → #932.
2026-10-19 00:51:52 +02:00
Ludovic Marie 0c933cc9c5 Merge pull request #919 from ludovic111/feat/structure-rule-tests
🤖 Agent: reviewed; verify passes. Parity: all 269 game-side harnesses on modpacks-8's integration commit (main 573f3a64 + the six game-side PRs), vanilla structure-start oracle 35/35. Merged in order #919 → #920 → #922 → #923 → #924, then the stack #926 → #929 → #930 → #932.
2026-10-19 00:51:38 +02:00
Ludovic Marie 8625ec35e0 Merge pull request #939 from ludovic111/perf/occlusion-cull-cheap
🤖 Agent: reviewed; verify passes. HD 620 (Vulkan/Mesa) culling off → on: RD16 +22–42 % FPS (peak unchanged, culling paused), RD32 +14–109 %; 1 % lows and CPU ms equal or better except RD32 peak's 1 % low (38.8 → 37.4). Screenshots: static views within main-vs-main noise, 21 frames after 30–40° camera jumps identical (no popping). parity section_mesh, translucency, light, hud locally; CI parity covers the rest. On only on Vulkan devices with SHADER_EARLY_DEPTH_TEST, INDIRECT_FIRST_INSTANCE and fragment-writable storage; Metal draws as before. Not yet checked on NVIDIA/AMD or Windows Vulkan: HORIZON_GPU_CULL=0 turns it off.
2026-10-19 00:39:08 +02:00
Ludovic Marie 13cd89578a Terrain: occlusion culling of solid sections (Vulkan)
Sections that terrain in front hides entirely are drawn with an instance
count of 0. Phase 1 draws the sections the last test read back saw; in the
same pass every other section's box (and an eighth of phase 1's) is drawn
against phase 1's depth, front faces only, with a fragment shader forced
past an early depth test that marks the section seen. Phase 2, in a second
pass, draws what the test saw. The test is exact per pixel and needs no depth
read or Hi-Z, and every solid draw stays one entry of one list, so the CPU
records as many draws as before (Mesa unrolls a multi-draw per entry on
Intel Gen9). Culling pauses while the last result hid under a tenth of the
solid indices, with one frame in 64 testing everything.

HD 620 at RD16: +23-42% FPS in five of perf-frame-6's six views, the peak
view unchanged; RD32: +14-109%. Pixels unchanged, also on camera jumps.
Vulkan only: naga's MSL has no early fragment tests. HORIZON_GPU_CULL=0
turns it off, `all` culls every frame; `section-cull on|off` in a game.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 23:53:53 +02:00
Ludovic Marie 25f2e2396d Merge pull request #916 from ludovic111/feat/server-headless-build
🤖 Agent: reviewed; verify passes. Release dry run on this branch (run 39167763008): linux, macos, windows builds and publish all succeed; horizon-server-linux-x86_64.tar.gz (28 MB) built and import-checked (no libasound/libudev). Agent's proof: 880/879 client tests in both builds, dedicated_server/server_entities/lan on the server build, install → init → start → bot join on the ThinkPad without the libraries.
2026-10-18 23:42:28 +02:00