Advancements: read the tree on another thread while the world loads

The first criterion trigger of a world's first tick loaded the
advancement tree: about 1,400 JSON files read and parsed on the game
thread, about 60 ms of a 125 ms first tick. open_world now starts that
read on a thread, and the first advancement_tree() takes its result,
the same tree as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Ludovic Marie
2026-10-17 14:16:54 +02:00
parent 7fb54b8150
commit d989d4033f
2 changed files with 22 additions and 1 deletions
+1
View File
@@ -6231,6 +6231,7 @@ impl Game<'_> {
self.fns = Default::default();
self.bosses = Default::default();
reset_world_progress(&mut self.adv, &mut self.stats);
self.prefetch_advancement_tree();
self.restore_player_environment = true;
// RandomSequences: the world's data/minecraft/random_sequences.dat.
self.rand_sequences =
+21 -1
View File
@@ -88,6 +88,9 @@ pub(super) struct AdvState {
pub(super) changed: BTreeSet<usize>,
pub(super) unlocked: Vec<String>,
pub(super) announced: Vec<Text>,
/// The tree being read on another thread since the world opened
/// (`prefetch_advancement_tree`), taken by the first `advancement_tree`.
pub(super) pending_tree: Option<std::thread::JoinHandle<Tree>>,
}
/// The game's world for predicates.
struct View<'a, 'g>(&'a Game<'g>);
@@ -221,10 +224,27 @@ impl Game<'_> {
/// The advancement tree, loaded once.
pub(super) fn advancement_tree(&mut self) -> Arc<Tree> {
if self.adv.tree.list.is_empty() {
self.adv.tree = Arc::new(Tree::load(&self.options.resources.join("data")));
let tree = match self.adv.pending_tree.take().map(|h| h.join()) {
Some(Ok(tree)) => tree,
_ => Tree::load(&self.options.resources.join("data")),
};
self.adv.tree = Arc::new(tree);
}
self.adv.tree.clone()
}
/// Start reading the advancement files on another thread while the world
/// loads. The first tick's first criterion trigger used to read and parse
/// all of them on the game thread (about 60 ms).
pub(super) fn prefetch_advancement_tree(&mut self) {
if !self.adv.tree.list.is_empty() || self.adv.pending_tree.is_some() {
return;
}
let data = self.options.resources.join("data");
self.adv.pending_tree = std::thread::Builder::new()
.name("horizon-advancements".into())
.spawn(move || Tree::load(&data))
.ok();
}
pub(super) fn load_advancements(&mut self) {
if self.adv.loaded || self.remote.is_some() || self.no_player_here() {
return;