Worlds without structures generate none

`generate-structures=false` (server.properties, stored by #733) and the
world screen's Generate Structures were written to the world's settings
but the generator ignored them. VanillaTerrain now builds its generator
from the world's `generate_structures`
(OverworldGenerator::for_world): without structures there are no starts,
terrain adaptation or structure pieces, as in
ChunkStatusTasks.generateStructureStarts, and `locate structure` and eyes
of ender find nothing (ChunkGenerator.findNearestMapStructure).

The server world gen harness's world without structures now also
compares `locate structure` for a village and a mineshaft and the saved
chunks' structure starts and references.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Ludovic Marie
2026-10-17 23:07:55 +02:00
parent ce571f789c
commit a1af7fdad5
4 changed files with 69 additions and 5 deletions
+4 -1
View File
@@ -6569,7 +6569,10 @@ impl Game<'_> {
res.threads,
)
} else {
let inner = Arc::new(VanillaTerrain::for_dimension(&self.options.resources.join("worldgen"), pack.assets.registry, &res.biomes, seed, dim.id()).map_err(|e| {
// WorldOptions.generateStructures, from the world's settings.
let structures =
horizon_client::save::WorldGen::read(world_root).is_none_or(|w| w.structures);
let inner = Arc::new(VanillaTerrain::for_world(&self.options.resources.join("worldgen"), pack.assets.registry, &res.biomes, seed, dim.id(), structures).map_err(|e| {
format!("{e}\nPrepare the worldgen bundle with the launcher, or: horizon-prepare --prepare")
})?);
self.end.set_locator(Some(inner.clone()));
+14 -1
View File
@@ -56,6 +56,19 @@ impl VanillaTerrain {
biomes: &Biomes,
seed: i64,
dimension: &str,
) -> crate::Result<Self> {
Self::for_world(dir, registry, biomes, seed, dimension, true)
}
/// A dimension of a world whose `generate_structures` is `structures`
/// (`ChunkGenerator.createStructures` and `findNearestMapStructure` do
/// nothing without).
pub fn for_world(
dir: &Path,
registry: &'static BlockRegistry,
biomes: &Biomes,
seed: i64,
dimension: &str,
structures: bool,
) -> crate::Result<Self> {
let data: Arc<GeneratorData> = shared_data(dir, registry)?;
let biome_map = data
@@ -64,7 +77,7 @@ impl VanillaTerrain {
.map(|name| biomes.id(name))
.collect();
let generator =
OverworldGenerator::for_dimension(data, seed, "minecraft:normal", dimension)?;
OverworldGenerator::for_world(data, seed, "minecraft:normal", dimension, structures)?;
let unsupported = generator.unsupported_features();
if !unsupported.is_empty() {
log::warn!(
@@ -1764,6 +1764,18 @@ impl OverworldGenerator {
) -> Result<Self, GeneratorError> {
Self::build(data, seed, preset, dimension, true)
}
/// A dimension of a world preset, with or without structures (the
/// world's `generate_structures`: without, no starts, terrain adaptation,
/// structure pieces or structure locating).
pub fn for_world(
data: Arc<GeneratorData>,
seed: i64,
preset: &str,
dimension: &str,
structures: bool,
) -> Result<Self, GeneratorError> {
Self::build(data, seed, preset, dimension, structures)
}
fn build(
data: Arc<GeneratorData>,
seed: i64,
+39 -3
View File
@@ -10,7 +10,10 @@ to the preset's classic ones) and `generate-structures`.
Each case starts vanilla's server and Horizon's (`horizon-client --dedicated --nogui`) in a new folder, waits
for `Done` and stops them. Compared exactly: the world's `data/minecraft/world_gen_settings.dat`, tag types
included, and the warnings and errors logged while the world's settings are read (the `Worker-Main` lines;
the worker's number is left out).
the worker's number is left out). In a world without structures (`generate-structures=false`), also what
`locate structure` answers on the console for a village and a mineshaft (ChunkGenerator.findNearestMapStructure
finds none) and how many of the saved chunks hold structure starts or references (none:
ChunkStatusTasks.generateStructureStarts does nothing).
Horizon generates the normal and flat presets only: `large_biomes`, `amplified`, `single_biome_surface` and
`debug_all_block_states` aren't tested.
@@ -23,6 +26,7 @@ import re
import shutil
import subprocess
import sys
import time
try:
from . import anvil_dump, lab, test_rust_parity as base
@@ -60,6 +64,32 @@ CASES = {
'unknown': {'level-type': 'Some Type', 'level-seed': '42'},
}
WORKER = re.compile(r'\[Worker-Main-\d+/(WARN|ERROR)\]: (.*)')
LOCATE = ['locate structure #minecraft:village', 'locate structure minecraft:mineshaft']
REPLY = re.compile(r'\]: (?:System chat: )?((?:Could not find|The nearest|Unknown|Incorrect).*)')
def console_reply(server, command, timeout=300):
"""The first command reply the console logs after `command`."""
start = len(server.lines)
server.console(command)
deadline = time.time() + timeout
while time.time() < deadline:
for line in server.lines[start:]:
if m := REPLY.search(line):
return m.group(1)
time.sleep(0.2)
raise AssertionError(f'no reply to {command!r} in {timeout} s:\n' + '\n'.join(server.lines[-20:]))
def structure_chunks(world):
"""How many saved overworld chunks hold structure starts, and how many references."""
starts = references = 0
for region in sorted((world / 'region').glob('*.mca')):
for chunk in anvil_dump.region_chunks(region).values():
structures = anvil_dump.plain(chunk, True).get('structures', {})
starts += bool(structures.get('starts'))
references += bool(structures.get('References'))
return f'chunks with structure starts: {starts}, with references: {references}'
def escape(value):
@@ -77,11 +107,16 @@ def run_case(label, command, build, case):
encoding='iso-8859-1')
(directory / 'eula.txt').write_text('eula=true\n')
server = Server(command, directory, f'{label}-{case}')
replies = []
try:
server.wait_for(r'Done \(')
if CASES[case].get('generate-structures') == 'false':
replies = [f'{c}: {console_reply(server, c)}' for c in LOCATE]
finally:
server.stop()
out = [f'# {case}']
out = [f'# {case}', *replies]
if replies:
out.append(structure_chunks(directory / 'world'))
out += [f'{m.group(1)}: {m.group(2)}' for l in server.lines if (m := WORKER.search(l))]
settings = anvil_dump.plain(anvil_dump.read_dat(directory / 'world/data/minecraft/world_gen_settings.dat'),
True, typed=True)
@@ -121,7 +156,8 @@ def main():
java=subprocess.check_output(['java', '--version'], text=True).splitlines()[0],
cases=list(CASES), lines=len(vanilla), output_sha256=lab.digest(build / 'horizon.txt', 'sha256'),
scope='a new dedicated-server world: level-type (flat, normal, unknown), a flat world\'s '
'generator-settings, generate-structures, as world_gen_settings.dat and the lines logged.'))
'generator-settings, generate-structures, as world_gen_settings.dat and the lines logged; without '
'structures, locate structure\'s replies and the saved chunks\' structure starts and references.'))
print(f'server world gen: {len(CASES)} cases, {len(vanilla)} lines identical')