parity: a workspace crate's features count through the sources they gate

A manifest line defining or turning on a workspace crate's feature no longer
makes the manifests count, if every source naming the feature (or one it turns
on) changed too, as in a split, where the new crate's files are all new.
#2215 (horizon-items with a test-support feature) now selects 209 harnesses
instead of 354.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Ludovic Marie
2026-10-27 01:10:36 +01:00
parent 1b1571ed6a
commit 1af4d0e432
2 changed files with 69 additions and 5 deletions
+21
View File
@@ -440,5 +440,26 @@ class WorkspaceManifestTests(unittest.TestCase):
resolver = {"Cargo.toml": '[workspace]\nmembers = ["a"]\nresolver = "3"\n'}
self.assertEqual(self.verdict({"Cargo.toml": '[workspace]\nmembers = ["a"]\nresolver = "2"\n'}, resolver), set())
def test_a_feature_of_a_workspace_crate_counts_through_its_sources(self):
items = '[package]\nname = "horizon-items"\n\n[features]\ntest-support = []\n'
client = self.CLIENT + '\n[dev-dependencies]\nhorizon-items = { path = "../horizon-items", features = ["test-support"] }\n'
head = {"crates/horizon-items/Cargo.toml": items, "crates/horizon-client/Cargo.toml": client,
"crates/horizon-items/src/lib.rs": '#[cfg(feature = "test-support")]\npub fn for_tests() {}\n'}
base = {"crates/horizon-client/Cargo.toml": self.CLIENT}
# The new crate's files are all changed, the code the feature gates with them.
self.assertEqual(self.verdict(base, head), {"crates/horizon-items/Cargo.toml", "crates/horizon-client/Cargo.toml"})
# Turning on a feature of a crate whose gated code didn't change selects as before.
world = '[package]\nname = "horizon-world"\n\n[features]\nextra = ["more"]\nmore = []\n'
with tempfile.TemporaryDirectory() as temp, mock.patch.object(parity, "ROOT", Path(temp)):
Path(temp, "crates/horizon-world/src").mkdir(parents=True)
Path(temp, "crates/horizon-world/Cargo.toml").write_text(world)
Path(temp, "crates/horizon-world/src/lib.rs").write_text('#[cfg(feature = "more")]\nfn x() {}\n')
self.assertFalse(parity.feature_sources_changed("horizon-world", "extra", {"crates/horizon-client/Cargo.toml"}))
self.assertTrue(parity.feature_sources_changed("horizon-world", "extra", {"crates/horizon-world/src/lib.rs"}))
self.assertFalse(parity.feature_sources_changed("horizon-nothing", "extra", set()))
# A feature that reaches an external package counts.
optional = {"crates/horizon-client/Cargo.toml": self.CLIENT + '\n[features]\nfast = ["wgpu/x"]\n'}
self.assertEqual(self.verdict({"crates/horizon-client/Cargo.toml": self.CLIENT}, optional), set())
def test_without_a_base_everything_counts(self):
self.assertEqual(parity.workspace_only_manifests({"Cargo.lock"}, None), set())
+48 -5
View File
@@ -1248,9 +1248,14 @@ def trace_main(output, script, arguments):
SHARED_INPUTS = {"research-lock.json", "Cargo.lock"}
# Manifest sections that say what a crate is and where its targets are, not what it builds with.
MANIFEST_SECTION_KEPT = re.compile(r"\[\[?(?:package|lib|bin|example|test|bench|lints|badges)\b[^\]]*\]\]?$")
# A workspace crate named as a dependency (by path, or from the workspace's own table), or listed as a member.
WORKSPACE_LINE = re.compile(r'(?:horizon[\w-]*|cargo-horizon-mod|xtask)\s*=\s*(?:\{[^}]*\b(?:path|workspace)\s*=[^}]*\}|true)'
r'|(?:horizon[\w-]*|cargo-horizon-mod|xtask)\.workspace\s*=\s*true|"crates/[^"]+",?')
WORKSPACE_CRATE = r"(horizon[\w-]*|cargo-horizon-mod|xtask)"
# A workspace crate named as a dependency (by path, or from the workspace's own table) without choosing its features,
# or listed as a member.
WORKSPACE_LINE = re.compile(WORKSPACE_CRATE + r'\s*=\s*(?:\{(?![^}]*\bfeatures\b)[^}]*\b(?:path|workspace)\s*=[^}]*\}|true)'
r'|' + WORKSPACE_CRATE + r'\.workspace\s*=\s*true|"crates/[^"]+",?')
# A workspace crate named as a dependency with some of its features turned on.
WORKSPACE_FEATURES = re.compile(WORKSPACE_CRATE + r'\s*=\s*\{(?=[^}]*\b(?:path|workspace)\s*=)(?![^}]*default-features)'
r'[^}]*\bfeatures\s*=\s*\[([^\]]*)\][^}]*\}')
def git_show(base, path):
@@ -1263,12 +1268,14 @@ def manifest_lines(text):
"""A Cargo.toml's lines that decide what is built: (section, line) pairs, without its package's identity and
targets, comments, or workspace crates (whose code counts through its own sources)."""
lines, section = set(), ""
name = re.search(r'^\[package\][^\[]*?^name\s*=\s*"([^"]+)"', text or "", re.M | re.S)
for raw in (text or "").splitlines():
line = re.sub(r"\s+", " ", raw.split("#", 1)[0]).strip()
if not line:
continue
if line.startswith("["):
section = line
# A crate's features are its own: the same line in two crates means two things.
section = f"[features] of {name.group(1) if name else '?'}" if line == "[features]" else line
continue
if MANIFEST_SECTION_KEPT.match(section) or WORKSPACE_LINE.fullmatch(line) or \
section == "[workspace]" and (line.startswith("members =") or line.startswith('"') or line == "]"):
@@ -1297,7 +1304,43 @@ def workspace_only_manifests(changed, base):
before = set().union(*(manifest_lines(git_show(base, path)) for path in tomls)) if tomls else set()
after = set().union(*(manifest_lines((ROOT / path).read_text(encoding="utf-8") if (ROOT / path).exists() else None)
for path in tomls)) if tomls else set()
return set(manifests) if before == after else set()
# Workspace crates' features that a changed line defines or turns on: they change what compiles of that crate's
# sources, which is fine only where every source naming them changed too (a split: the crate's files are new).
gated = set()
for section, line in before ^ after:
wanted = WORKSPACE_FEATURES.fullmatch(line)
if wanted:
gated |= {(wanted.group(1), feature) for feature in re.findall(r'"([^"]+)"', wanted.group(2))}
elif section.startswith("[features] of ") and re.fullmatch(r'[\w-]+ = \[(?: ?"[\w-]+",?)*\s*\]', line):
gated.add((section[len("[features] of "):], line.split(" ", 1)[0]))
else:
return set() # an external package, a feature reaching one ("dep:", "crate/feature"), a build setting
return set(manifests) if all(feature_sources_changed(crate, feature, changed) for crate, feature in gated) else set()
def feature_sources_changed(crate, feature, changed):
"""Whether every Rust source of workspace crate `crate` that names `feature`, or a feature it turns on, is in
changed (False where the crate isn't found)."""
listed = subprocess.run(["git", "ls-files", "*Cargo.toml"], cwd=ROOT, capture_output=True, text=True)
manifests = [ROOT / path for path in listed.stdout.split()] if listed.returncode == 0 else list(ROOT.rglob("Cargo.toml"))
for manifest in manifests:
text = manifest.read_text(encoding="utf-8") if manifest.exists() else ""
if re.search(r'^\[package\][^\[]*?^name\s*=\s*"' + re.escape(crate) + '"', text, re.M | re.S):
break
else:
return False
table = re.search(r"^\[features\]\n(.*?)(?=^\[|\Z)", text, re.M | re.S)
implies = {name: re.findall(r'"([^"]+)"', value) for name, value in
re.findall(r'^([\w-]+)\s*=\s*\[([^\]]*)\]', table.group(1) if table else "", re.M)}
names, todo = set(), [feature]
while todo:
name = todo.pop()
if name not in names:
names.add(name)
todo += [implied for implied in implies.get(name, []) if "/" not in implied and ":" not in implied]
named = re.compile(r'feature\s*=\s*"(?:' + "|".join(map(re.escape, sorted(names))) + r')"')
return all(path.relative_to(ROOT).as_posix() in changed for path in manifest.parent.rglob("*.rs")
if named.search(path.read_text(encoding="utf-8", errors="replace")))
def changed_files(ref):