Ludovic Marie
08c4805e10
GitHub's releases page sorts a day's tags as text, so v2026.10.15.9 showed above v2026.10.15.18 (reported by rdbt on Discord). Tags now count .01, .02... Every reader (release_train.tag_key, the launcher's compare_versions) compares the parts as integers, so older unpadded tags still order correctly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
119 lines
7.6 KiB
Python
119 lines
7.6 KiB
Python
import datetime as dt
|
|
from pathlib import Path
|
|
import tempfile
|
|
import unittest
|
|
|
|
from tools import release_train as train
|
|
|
|
NOW = dt.datetime(2026, 10, 15, 12, 0, tzinfo=dt.timezone.utc)
|
|
|
|
|
|
def pr(number, title="Fix a thing", labels=(), paths=("crates/horizon-client/src/game.rs",), issues=(), author="ludovic111",
|
|
merged=dt.timedelta(hours=9)):
|
|
return {"number": number, "title": title, "labels": list(labels), "paths": list(paths), "issues": list(issues),
|
|
"author": author, "url": f"https://github.com/ludovic111/horizon/pull/{number}", "merged_at": NOW - merged}
|
|
|
|
|
|
class ReleaseTrainTests(unittest.TestCase):
|
|
def test_player_facing_paths(self):
|
|
exporters = {"mods/horizon/src/test/java/dev/horizonlab/parity/VanillaMobDataExporter.java"}
|
|
self.assertTrue(train.player_facing("crates/horizon-client/src/game.rs", "game"))
|
|
self.assertTrue(train.player_facing("Cargo.lock", "game"))
|
|
self.assertTrue(train.player_facing("xtask/src/main.rs", "game"))
|
|
self.assertTrue(train.player_facing(next(iter(exporters)), "game", exporters))
|
|
self.assertFalse(train.player_facing("mods/horizon/src/test/java/dev/horizonlab/parity/VanillaFoodOracle.java", "game", exporters))
|
|
self.assertFalse(train.player_facing("crates/horizon-world/examples/probe.rs", "game"))
|
|
self.assertFalse(train.player_facing("crates/horizon-client/README.md", "game"))
|
|
self.assertFalse(train.player_facing("tools/test_food_parity.py", "game"))
|
|
self.assertFalse(train.player_facing("launcher/src/main.rs", "game"))
|
|
self.assertTrue(train.player_facing("launcher/src/main.rs", "launcher"))
|
|
self.assertTrue(train.player_facing("crates/horizon-prepare/src/lib.rs", "launcher"))
|
|
self.assertFalse(train.player_facing("launcher/links.json", "launcher"))
|
|
self.assertFalse(train.player_facing("crates/horizon-client/src/game.rs", "launcher"))
|
|
|
|
def test_the_exporters_are_those_horizon_prepare_names(self):
|
|
found = train.exporters()
|
|
self.assertIn(train.EXPORTERS + "VanillaMobDataExporter.java", found)
|
|
self.assertTrue(all(path.endswith(".java") for path in found))
|
|
|
|
def test_game_tags_count_up_within_a_day(self):
|
|
today = dt.date(2026, 10, 15)
|
|
self.assertEqual(train.next_game_tag(["v2026.10.14", "launcher-v0.1.4"], today), "v2026.10.15")
|
|
self.assertEqual(train.next_game_tag(["v2026.10.15"], today), "v2026.10.15.01")
|
|
self.assertEqual(train.next_game_tag(["v2026.10.15", "v2026.10.15.01", "v2026.10.15.02"], today), "v2026.10.15.03")
|
|
# Unpadded tags from before the change still count, and the next one sorts after them as text too.
|
|
self.assertEqual(train.next_game_tag(["v2026.10.15", "v2026.10.15.9", "v2026.10.15.20"], today), "v2026.10.15.21")
|
|
self.assertEqual(train.next_game_tag(["v2026.10.15", "v2026.10.15.08"], today), "v2026.10.15.09")
|
|
tags = ["v2026.10.15.09", "v2026.10.15.10", "v2026.10.15"]
|
|
self.assertEqual(sorted(tags), sorted(tags, key=train.tag_key))
|
|
|
|
def test_launcher_tags_bump_the_patch_or_the_minor(self):
|
|
tags = ["launcher-v0.1.3", "launcher-v0.1.10", "v2026.10.15", "launcher-v0.1.4"]
|
|
self.assertEqual(train.next_launcher_tag(tags, minor=False), "launcher-v0.1.11")
|
|
self.assertEqual(train.next_launcher_tag(tags, minor=True), "launcher-v0.2.0")
|
|
|
|
def test_decision(self):
|
|
minute = dt.timedelta(minutes=1)
|
|
decide = lambda prs, **kw: train.decision("game", prs, NOW, **kw)[0]
|
|
self.assertTrue(decide([pr(1, merged=16 * minute)]), "settled for the debounce")
|
|
self.assertFalse(decide([pr(1, merged=5 * minute)]), "merged moments ago")
|
|
self.assertFalse(decide([pr(1, merged=40 * minute), pr(2, merged=5 * minute)]), "a burst still merging")
|
|
self.assertTrue(decide([pr(1, merged=61 * minute), pr(2, merged=2 * minute)]), "merges that never pause still ship")
|
|
self.assertTrue(decide([pr(1, labels=["release-now"], merged=minute)]))
|
|
self.assertFalse(decide([pr(1, paths=[])]), "nothing players run")
|
|
self.assertFalse(decide([pr(1, labels=["skip-release"])]))
|
|
self.assertFalse(decide([pr(1, labels=["release-now", "skip-release"])]))
|
|
self.assertFalse(decide([pr(1, merged=5 * minute), pr(2, labels=["skip-release"], merged=minute)]), "the settled one waits for nothing")
|
|
self.assertFalse(decide([pr(1)], paused=True))
|
|
self.assertTrue(decide([], paused=True, force=True))
|
|
|
|
def test_notes(self):
|
|
prs = [pr(5, "Nether portals: vanilla timing and linking (fixes #94)", issues=[94]),
|
|
pr(6, "Controllers: gilrs input layer and gameplay", labels=["feature"], author="cosmic"),
|
|
pr(7, "Release folder in Rust", labels=["skip-release"]),
|
|
pr(8, "Website footer", paths=[])]
|
|
title, body = train.notes("game", "v2026.10.15.1", prs, ["- Sound cuts out after an hour."])
|
|
self.assertEqual(title, "Horizon 2026.10.15.1: Controllers, nether portals")
|
|
self.assertIn("### New\n- Controllers: gilrs input layer and gameplay (#6)", body)
|
|
self.assertIn("### Fixed\n- Nether portals: vanilla timing and linking (#5, fixes #94)", body)
|
|
self.assertIn("### Known issues\n- Sound cuts out after an hour.", body)
|
|
self.assertNotIn("#7", body)
|
|
self.assertNotIn("#8", body)
|
|
self.assertIn("Thanks to @cosmic.", body)
|
|
self.assertLess(body.index("### New"), body.index("### Fixed"))
|
|
title, _ = train.notes("game", "v2026.10.15.2", [pr(9, "Horizon's mark", labels=["feature"]),
|
|
pr(10, "Game menus", labels=["feature"])], [])
|
|
self.assertEqual(title, "Horizon 2026.10.15.2: Game menus, Horizon's mark", "proper nouns keep their capital")
|
|
|
|
def test_a_long_release_is_named_after_its_first_titles(self):
|
|
prs = [pr(n, f"Change number {n} with a fairly long title") for n in range(1, 10)]
|
|
title, _ = train.notes("game", "v2026.10.15", prs, [])
|
|
self.assertTrue(title.startswith("Horizon 2026.10.15: Change number 9"), title)
|
|
self.assertTrue(title.endswith("more fixes"), title)
|
|
self.assertLess(len(title), 100)
|
|
|
|
def test_a_feature_split_over_several_pull_requests_is_named_once(self):
|
|
prs = [pr(1, "Controllers: rumble", labels=["feature"]), pr(2, "Controllers: menus", labels=["feature"]),
|
|
pr(3, "Maces: smash attacks"), pr(4, "Fix stuck keys when opening Options")]
|
|
title, _ = train.notes("game", "v2026.10.15", prs, [])
|
|
self.assertEqual(title, "Horizon 2026.10.15: Controllers, stuck keys when opening Options, maces")
|
|
self.assertEqual(train.summary([], [pr(n, f"Change number {n} with a fairly long title") for n in range(4)]),
|
|
"Change number 3 with a fairly long title and 3 more fixes")
|
|
|
|
def test_launcher_notes(self):
|
|
title, body = train.notes("launcher", "launcher-v0.2.0", [pr(3, "Launcher: say the self-update succeeded")], [])
|
|
self.assertEqual(title, "Horizon launcher 0.2.0")
|
|
self.assertIn("### Fixed\n- Launcher: say the self-update succeeded (#3)", body)
|
|
self.assertNotIn("Known issues", body)
|
|
|
|
def test_known_issues_are_the_bullets_of_the_file(self):
|
|
with tempfile.TemporaryDirectory() as temp:
|
|
path = Path(temp, "known-issues.md")
|
|
path.write_text("# Known issues\n\nSome text.\n\n- One.\n- Two, with **bold**.\n continued\n")
|
|
self.assertEqual(train.known_issues(path), ["- One.", "- Two, with **bold**."])
|
|
self.assertEqual(train.known_issues(Path(temp, "missing.md")), [])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|