Files
horizon-airdef/launcher/src/signed.rs
T
Ludovic Marie 846f681b9a Signed updates: releases from before signing stay installable with pinned files; tests need a release key
- crates/horizon-release-sign/legacy-releases.txt pins the SHA-256 of every archive of the 131 releases published
  before signing (GitHub's upload digests, written by tools/ci/legacy_releases.py). The launcher and
  horizon-server update install those releases only with exactly those files, so rolling back to one works and
  nobody can swap its files later; every other release needs its signed SHA256SUMS.
- the_launcher_ships_with_a_release_key and horizon_server_ships_with_a_release_key fail while
  release-keys.txt lists no key, so this can't ship refusing everything.
- Test tags moved to v2099.* so they never collide with a pinned release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 12:20:36 +02:00

97 lines
4.4 KiB
Rust

//! Signed downloads (docs/security.md): a game or launcher archive is installed only when its
//! SHA-256 matches the release's SHA256SUMS and that list is signed by one of the keys built in
//! from crates/horizon-release-sign/release-keys.txt. A release from before signing installs only
//! with the SHA-256 pinned for it in legacy-releases.txt (a rollback). Anything else is refused
//! with a message saying why.
use crate::backend::REPO;
use horizon_release_sign::{PublicKey, SIGNATURE, SUMS};
/// Where a release's attached file downloads from (GitHub's fixed address for it).
pub fn asset_url(tag: &str, name: &str) -> String {
format!("https://github.com/{REPO}/releases/download/{tag}/{name}")
}
/// The signed SHA-256 of `asset` in release `tag`, fetching its SHA256SUMS and SHA256SUMS.sig
/// with `fetch` (None: the release has no such file), or why the download must be refused. A
/// release from before signing gets its pinned SHA-256, whatever files it carries now.
pub fn digest(
tag: &str,
asset: &str,
keys: &[PublicKey],
fetch: impl Fn(&str) -> Result<Option<Vec<u8>>, String>,
) -> Result<String, String> {
if let Some(hex) = horizon_release_sign::legacy_digest(tag, asset) {
return Ok(hex.to_owned());
}
let sums = fetch(&asset_url(tag, SUMS))?;
let signature = fetch(&asset_url(tag, SIGNATURE))?
.map(|bytes| String::from_utf8_lossy(&bytes).into_owned());
horizon_release_sign::signed_digest(tag, asset, sums.as_deref(), signature.as_deref(), keys)
}
#[cfg(test)]
mod tests {
use super::*;
use horizon_release_sign::{sha256_hex, sums_file, SigningKey};
#[test]
fn the_launcher_ships_with_a_release_key() {
// With no key in release-keys.txt every release after the pinned ones would be refused:
// this fails until the release environment's public key is listed (docs/security.md).
assert!(
!horizon_release_sign::trusted_keys().is_empty(),
"crates/horizon-release-sign/release-keys.txt lists no key"
);
}
#[test]
fn releases_from_before_signing_install_only_with_their_pinned_files() {
let tampered =
|_: &str| -> Result<Option<Vec<u8>>, String> { Ok(Some(b"anything".to_vec())) };
let pinned =
horizon_release_sign::legacy_digest("v2026.10.12", "horizon-linux-x86_64.tar.gz")
.expect("v2026.10.12 is from before signing");
assert_eq!(
digest("v2026.10.12", "horizon-linux-x86_64.tar.gz", &[], tampered),
Ok(pinned.to_owned())
);
}
#[test]
fn only_archives_signed_by_a_built_in_key_install() {
let (key, _) = SigningKey::generate().unwrap();
let sums = sums_file(&[("horizon.zip".into(), sha256_hex(b"game"))]);
let signature = key.sign("v2099.01.01", sums.as_bytes());
// GitHub as it answers for a signed release (any tag: the files are what a replay would serve).
let signed = |url: &str| -> Result<Option<Vec<u8>>, String> {
assert!(url.starts_with("https://github.com/ludovic111/horizon/releases/download/"));
Ok(Some(
if url.ends_with(".sig") {
signature.clone()
} else {
sums.clone()
}
.into_bytes(),
))
};
let keys = [key.public()];
assert_eq!(
digest("v2099.01.01", "horizon.zip", &keys, signed),
Ok(sha256_hex(b"game"))
);
// Signed for another tag, by another key, or not listing the archive: refused.
assert!(digest("v2099.01.02", "horizon.zip", &keys, signed).is_err());
let (other, _) = SigningKey::generate().unwrap();
assert!(digest("v2099.01.01", "horizon.zip", &[other.public()], signed).is_err());
assert!(digest("v2099.01.01", "other.zip", &keys, signed).is_err());
// No checksums (a release from before signing): refused, saying so.
let unsigned = |_: &str| -> Result<Option<Vec<u8>>, String> { Ok(None) };
let refused = digest("v2099.01.01", "horizon.zip", &keys, unsigned).unwrap_err();
assert!(refused.contains("not signed"), "{refused}");
// Checksums that can't be fetched are an error too, never a pass.
let offline = |_: &str| -> Result<Option<Vec<u8>>, String> { Err("No connection".into()) };
assert!(digest("v2099.01.01", "horizon.zip", &keys, offline).is_err());
}
}