21019afc2b
A chest minecart, hopper minecart or chest boat's menu edits a stand-in container, which is meant to be copied back to the vehicle when the menu closes. close_container took the open container before calling close_cart_container, which then found nothing open and copied nothing: items taken out came back on the next open, and items put in vanished. Copy the stand-in back from the key close_container took. A server player's clicks in such a menu copy it back at once, since the menu is the vehicle's own inventory (ContainerEntity, AbstractMinecartContainer and ChestBoat implement the container the menu reads and writes).