//! Minecraft server DNS redirects (`ServerRedirectHandler` / `ServerNameResolver`). //! Port 25565 asks for `_minecraft._tcp.`'s SRV record; no record or a //! failed query leaves the original address in use. The protocol handshake //! still uses that original address. use crate::{Error, Result}; use std::net::{IpAddr, SocketAddr, ToSocketAddrs}; mod dns; pub(crate) fn resolve(host: &str, port: u16) -> Result> { resolve_with(host, port, srv_redirect, |host, port| { (host, port) .to_socket_addrs() .map(|addrs| addrs.collect()) .map_err(|e| Error::new(format!("Unknown host {host}: {e}"))) }) } fn resolve_with( host: &str, port: u16, srv: impl FnOnce(&str) -> Option<(String, u16)>, addresses: impl FnOnce(&str, u16) -> Result>, ) -> Result> { // Vanilla also asks for `_minecraft._tcp.127.0.0.1`, which never has a // record: IP literals and localhost skip the query. if port == 25565 && host.parse::().is_err() && host != "localhost" && let Some((target, target_port)) = srv(&format!("_minecraft._tcp.{}.", host.trim_end_matches('.'))) { // No second SRV lookup at the target, and no fallback to the original // host when the target is unknown. return addresses(&target, target_port); } addresses(host, port) } fn srv_redirect(name: &str) -> Option<(String, u16)> { dns::query_srv(name, &dns::system_name_servers(), dns::SERVER_TIMEOUT) } #[cfg(test)] mod tests { use super::*; #[test] fn redirects_default_port_even_when_the_original_host_has_no_addresses() { let result = resolve_with( "play.example.org", 25565, |name| { assert_eq!(name, "_minecraft._tcp.play.example.org."); Some(("backend.example.org.".into(), 25570)) }, |host, port| { assert_eq!((host, port), ("backend.example.org.", 25570)); Ok(vec!["127.0.0.1:25570".parse().unwrap()]) }, ) .unwrap(); assert_eq!( result, vec!["127.0.0.1:25570".parse::().unwrap()] ); } #[test] fn no_record_or_lookup_failure_keeps_the_original_address() { resolve_with( "play.example.org", 25565, |_| None, |host, port| { assert_eq!((host, port), ("play.example.org", 25565)); Ok(vec![]) }, ) .unwrap(); } #[test] fn explicit_nondefault_ports_and_ip_literals_do_not_query_srv() { for (host, port) in [ ("play.example.org", 25570), ("127.0.0.1", 25565), ("::1", 25565), ("localhost", 25565), ] { resolve_with( host, port, |_| panic!("unexpected SRV query"), |actual, actual_port| { assert_eq!((actual, actual_port), (host, port)); Ok(vec![]) }, ) .unwrap(); } } #[test] fn fully_qualified_host_does_not_get_a_second_trailing_dot() { resolve_with( "play.example.org.", 25565, |name| { assert_eq!(name, "_minecraft._tcp.play.example.org."); None }, |_, _| Ok(vec![]), ) .unwrap(); } #[test] fn unknown_redirect_target_does_not_fall_back_to_the_original() { let result = resolve_with( "play.example.org", 25565, |_| Some(("missing.example.org.".into(), 25570)), |host, _| { assert_eq!(host, "missing.example.org."); Err(Error::new("unknown redirected host")) }, ); assert_eq!(result.unwrap_err().to_string(), "unknown redirected host"); } #[test] fn literal_address_can_connect_without_dns() { let listener = std::net::TcpListener::bind("127.0.0.1:0").unwrap(); let address = listener.local_addr().unwrap(); let connection = crate::connection::Connection::connect_server( "127.0.0.1", address.port(), std::time::Duration::from_secs(1), ) .unwrap(); let (accepted, _) = listener.accept().unwrap(); drop((connection, accepted)); } }