Commit Graph

2326 Commits

Author SHA1 Message Date
Ludovic Marie dbeebefbda Merge pull request #1134 from ludovic111/fix/loot-set-potion
🤖 Agent: merged. Verify passes. B5's local integration of all its PRs on main: parity --changed 102/102, plus lan_e2e (flakes listed in FEATURES.md LATER 4l).
2026-10-22 04:03:02 +02:00
Ludovic Marie 5aff29807a Merge pull request #1149 from ludovic111/fix/others-breaking-progress
🤖 Agent: merged. Verify passes. B5's local integration of all its PRs on main: parity --changed 102/102 (the explosion-dependent 22 rerun after rebasing onto #1101), and lan_e2e passes except checks that fail only after earlier checks and pass alone (in FEATURES.md LATER 4l).
2026-10-22 03:24:35 +02:00
Ludovic Marie d4739f31b2 Merge pull request #1137 from ludovic111/fix/dragon-server-levels
🤖 Agent: merged. Verify passes. B5's local integration of all its PRs on main: parity --changed 102/102 (the explosion-dependent 22 rerun after rebasing onto #1101), and lan_e2e passes except checks that fail only after earlier checks and pass alone (in FEATURES.md LATER 4l).
2026-10-22 03:24:32 +02:00
Ludovic Marie 1fda49b9b0 Merge pull request #1119 from ludovic111/fix/boat-water-patch
🤖 Agent: merged. Verify passes. CI parity's failures are only the known flakes: world_spawn (vanilla gives several spawn heights for one seed across runs) and dedicated_server (play-pearl). This client rendering change can't move either. B2's integration passed every rendering harness, and before/after screenshots are in the body.
2026-10-22 03:03:27 +02:00
Ludovic Marie cb5355b3ff Merge pull request #1116 from ludovic111/fix/end-crystal-spin
🤖 Agent: merged. Verify passes. CI parity's failures are only the known flakes: world_spawn (vanilla gives several spawn heights for one seed across runs) and dedicated_server (play-pearl). This client rendering change can't move either. B2's integration passed every rendering harness, and before/after screenshots are in the body.
2026-10-22 03:03:23 +02:00
Ludovic Marie c4d6b34172 Other players' block cracks are drawn
On a server or a world open to LAN, a player saw only their own crack.
The server sent each new stage to the others
(ClientboundBlockDestruction), but a client of a server ignored the
packet, and the host of a LAN world neither drew its guests' cracks nor
sent its own to them.

Vanilla keeps the cracks per breaker (ClientLevel.destroyBlockProgress:
a progress outside 0..9 removes it, 400 ticks without news drops it) and
draws, within 32 blocks, the furthest one on each block
(LevelExtractor.extractBlockDestroyAnimation). Horizon now does the
same: a client of a server takes the packet, a LAN host records its
guests' stages and sends its own (each new stage, then -1 when it
stops), and every crack is drawn with its own stage. A guest's crack
also goes when the block it digs is gone before its STOP_DESTROY_BLOCK
(its own tick broke it), as ServerPlayerGameMode.tick clears it on air:
the others kept its last stage for 400 ticks. Each crack vertex carries
its stage sprite's atlas origin in its light bytes (the crumbling pass
is unlit); the shader keeps the shared sprite size.

lan_e2e `cracks`: each side watches the block the other mines and sees
its crack grow; no crack is left once the blocks break. The screenshots
from both sides show the cracks.

Fixes #1096

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 03:02:56 +02:00
Ludovic Marie fd0473605b Merge pull request #1125 from ludovic111/fix/station-quick-move
🤖 Agent: merged. Verify passes. Local integration of #1121–#1125 on main 2d586fac: parity --changed, all 101 affected harnesses pass. Screenshots in the body.
2026-10-22 03:00:02 +02:00
Ludovic Marie 24ce07cb93 Merge pull request #1124 from ludovic111/fix/menu-style-test-race
🤖 Agent: merged. Verify passes. Local integration of #1121–#1125 on main 2d586fac: parity --changed, all 101 affected harnesses pass. Screenshots in the body.
2026-10-22 02:59:58 +02:00
Ludovic Marie 194bad0b08 Merge pull request #1123 from ludovic111/fix/book-title-edit-box
🤖 Agent: merged. Verify passes. Local integration of #1121–#1125 on main 2d586fac: parity --changed, all 101 affected harnesses pass. Screenshots in the body.
2026-10-22 02:59:54 +02:00
Ludovic Marie f0b2083ca8 Merge pull request #1122 from ludovic111/fix/classic-extras-pairs
🤖 Agent: merged. Verify passes. Local integration of #1121–#1125 on main 2d586fac: parity --changed, all 101 affected harnesses pass. Screenshots in the body.
2026-10-22 02:59:50 +02:00
Ludovic Marie d87fe66e3e Merge pull request #1121 from ludovic111/fix/session-lock-release
🤖 Agent: merged. Verify passes. Local integration of #1121–#1125 on main 2d586fac: parity --changed, all 101 affected harnesses pass. Screenshots in the body.
2026-10-22 02:59:46 +02:00
Ludovic Marie afd9e820f5 Merge pull request #1127 from ludovic111/fix/server-update-semver-tags
🤖 Agent: merged. Verify and CI parity pass, and the independent review is OK: 12 update tests; v0.2.0.1 ranks below every 0.2 tag; a 0.2 install is never offered a dated tag.
2026-10-22 02:16:01 +02:00
Ludovic Marie 3ca2fc8c8b Merge pull request #1115 from ludovic111/fix/break-particle-sprite
🤖 Agent: merged. Verify passes. CI parity's only failure is world_spawn seed -2080727421395798566, where vanilla itself gives several heights across runs (also on main; see #1112). Screenshots in the body.
2026-10-22 02:03:42 +02:00
Ludovic Marie e935f5dc55 Merge pull request #1118 from ludovic111/fix/biome-fog-blend
🤖 Agent: merged. Verify and CI parity pass, with before/after screenshots in the body.
2026-10-22 02:03:21 +02:00
Ludovic Marie 323cc49198 Merge pull request #1120 from feeldev12/fix/benchmark-world-folder-race
🤖 Agent: merged. Thank you @feeldev12! Verify passes. A 2-line fix to benchmark tooling: the world folder is created before the marker is written, so slow devices no longer race the async world open.
2026-10-22 02:03:17 +02:00
Ludovic Marie 4b4b88b061 dragon: FightWho's doc names LAN and server players only
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:57:24 +02:00
Ludovic Marie 1845cc73af fix: end crystals take their entity ids when the fight places them
Like the dragon, a spike's crystal gets its id from the entity counter as
EndCrystal's constructor does, instead of only once a client tracks it: a
player the level serves without a client can then aim at it. The fight's
control status lists each crystal's id and position.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e32e5031c141fbd8c882847729beec92a65179a3)
2026-10-22 01:57:24 +02:00
Ludovic Marie ac06314bd9 fix: the dragon fights every player in the End, not only the window's
The dragon read the window's own player for everything: network players
(LAN guests, players on a server) were never targeted, strafed, charged,
knocked back, bitten, breathed on or hit by its fireballs.

- It sees the level's players (the window's and every guest in the level)
  through `TargetingConditions.forCombat` as each phase asks
  (`Level.getNearestPlayer`): alive, neither creative nor spectator, none on
  Peaceful. The holding pattern strafes the enemy nearest the egg, the
  landing approach comes in opposite it, the perched dragon scans within 20
  blocks (10 up or down) and charges within 150.
- The strafe keeps its own target (`attackTarget`) and goes back to the
  holding pattern when it leaves the level.
- A destroyed crystal sends a holding dragon after the player who destroyed
  it, else the nearest player (`EnderDragon.onCrystalDestroyed`), when it can
  attack them.
- Wing knockback and the head and neck bites, the breath and fireball clouds
  and its fireballs act on every player alike; what hits a guest runs as
  that guest, its knockback sent to its client.
- The dragon takes its id and its parts' when it is created, so a guest can
  attack them in a world without network players too.

A unit test covers the targeting rules (spectators and creative players
passed over, ranges, Peaceful, the nearest to the egg).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 2eef4e4bf50137d1cb8d9a377e0be38b07294b8e)
2026-10-22 01:57:24 +02:00
Ludovic Marie 2adfd75193 Loot tables apply set_potion
SetPotionFunction was skipped, so the potions a loot table gives came
out with no contents: a piglin's barter never held fire resistance (the
drinkable and splash ones, 16 of 469), only uncraftable potions. The
merchant and /loot code had it; the shared loot evaluator now does too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 1b2767122d7ffc9faf8d8359f49e86bab5054979)
2026-10-22 01:57:23 +02:00
Ludovic Marie f5688883ad fix: dragon damage follows vanilla (perched arrows, cooldown, explosions)
- A perched dragon (scanning, attacking, flaming, hovering) shrugs arrows
  off as `AbstractDragonSittingPhase.onHurt` does: no damage, and the arrow
  is set alight for a second and turns back instead of being spent. Arrows
  that hit a part or a crystal deal the arrow's damage with its Power bonus,
  and turn back when the hit is refused (a dying dragon, an invulnerable
  crystal).
- The damage cooldown is `LivingEntity.hurtServer`'s: within it a stronger
  hit lands its excess over the last one instead of being dropped; the hurt
  sound plays only for a new hit.
- Explosions hit as `ServerExplosion.hurtEntities` does: the dragon itself
  (its body) and then each part, each by its distance and its exposure
  (`getSeenPercent`, so cover protects it), through the cooldown; and every
  end crystal in reach blows up, not only the first.

`Dragon::hurt` and `Dragon::explosion_hits` are pure, with unit tests for
the perched arrows, the cooldown's excess, the parts' quarter plus one,
the take-off after a quarter of its health, and exposure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit c730ed9ed8e4d9151bacca3313f0fbdf5180c42e)
2026-10-22 01:57:23 +02:00
Ludovic Marie f2f3fb6ede fix: the ender dragon fight runs on server levels
On a dedicated server (and single player's server thread) the End is ticked
with no local player, and `tick_fight` returned before spawning the dragon:
players in the End found crystals but never a dragon.

- The fight finds its players as `EnderDragonFight.updatePlayers` does, every
  20 ticks: every player alive within 192 blocks of (0, 128, 0), the host and
  the network players in the level alike. Scanning the state, the respawn
  sequence, `createNewDragon` and the crystal count run while it has one;
  the dragon and crystals tick whenever the End does.
- The dragon is tracked to network players (`minecraft:ender_dragon`, its
  health and `DATA_PHASE` as vanilla pairs them, no attribute instances) and
  reserves its eight part ids after its own, as `EnderDragon`'s constructor
  does, so clients can attack the parts; a network player's attack on a part
  or an end crystal is aimed at it.

tools/test_server_dragon_parity.py sends a lone vanilla-codec client to the
End of vanilla's dedicated server and of Horizon's: the fight starts and the
dragon is tracked with the same spawn data, synched data entries and
attributes. VanillaProtocolClient's entity mode answers a scene's teleport
with the acceptance alone, as the 26.3 client does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 618db927d93bbcf7f3669ad0d630377c4646729d)
2026-10-22 01:57:23 +02:00
Ludovic Marie b31cb42242 Merge pull request #1111 from ludovic111/fix/occlusion-camera-above-world
🤖 Agent: merged. Verify passes. Local integration of #1109–#1112 on main ae21bd54: parity --changed 142/142. After the rebase onto #1094: 101/101, with screenshots in the body.
2026-10-22 01:15:59 +02:00
Ludovic Marie 7672c3d86c Merge pull request #1112 from ludovic111/fix/loading-screen-square
🤖 Agent: merged. Verify passes. Local integration of #1109–#1112 on main ae21bd54: parity --changed 142/142. CI parity's world_spawn diff (seed -2080727421395798566) also happens on main: vanilla itself gives y64/65/66/72 across runs. The other failure is the known dedicated_server pearl flake.
2026-10-22 01:15:55 +02:00
Ludovic Marie ec257d331e Merge pull request #1110 from ludovic111/fix/item-merge-falling-landing
🤖 Agent: merged. Verify passes. Local integration of #1109–#1112 on main ae21bd54: parity --changed 142/142, with before/after item counts in the body.
2026-10-22 01:15:50 +02:00
Ludovic Marie cfd4ac33bf Station shift-clicks follow vanilla's quickMoveStack; the brewing stand runs on the menu engine
The station screens' hand-written quick move put a payment stack's first item
into the beacon, fell back to the other inventory half when an enchanting,
grindstone, stonecutter, cartography or anvil rule's own slots were full, and
sent every input back hotbar-last-first. Follow each menu's quickMoveStack
(EnchantmentMenu, BeaconMenu, GrindstoneMenu, StonecutterMenu,
CartographyTableMenu, ItemCombinerMenu with SmithingMenu's
canMoveIntoInputSlots), repeated as doClick's QUICK_MOVE does.

A local brewing stand's clicks now run on the verified menu engine, as a
server's already did, so its shift-clicks, drags (quick craft) and double
clicks are BrewingStandMenu's, which test_menu_click_parity covers.

Part of #275

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:12:43 +02:00
Ludovic Marie aaf6384751 Tests: the menu style is per test thread, so parallel tests can't flip it
The menu style is one process-wide flag, and options tests switch it to lay
out a page in Horizon's or Classic's style. Running in parallel, one test's
switch moved another's widgets (classic_graphics_presets_set_the_distances
failed 4 of 200 runs of the options tests). Under cfg(test) the flag is a
thread local, Classic first; the game keeps the shared atomic.

Fixes #802

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:12:43 +02:00
Ludovic Marie cb20d7056c Book title: draw Select All's highlight, as BookSignScreen's EditBox
The title box is an unbordered, centred EditBox (black, no shadow) in
vanilla. Horizon kept Ctrl/Cmd+A's selection but never drew it, and centred
the title together with its cursor. Draw it with ui::append_field (now with
a text shadow flag): the value centred alone, the cursor after it, and the
inverted highlight. horizon-ctl gets the super (Cmd) and F6 key names, and
A/C/V/X with the edit modifier held act on the open book.

Part of #275

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:12:42 +02:00
Ludovic Marie 7e82252f12 Extras: classic switches two to a row; settings nest under their switch
Classic Extras laid every setting out as a full-width button. Pair each
section's buttons as vanilla's OptionsList.addSmall does (the same layout as
Video Settings), and shorten "Lower sensitivity while zoomed" to "Slower
turning" so it fits a half-width button.

Horizon's Extras page shows a switch's own settings (Zoom key, Minimap size,
FPS corner...) only while that switch is on, so it stays one row per extra
as the list grows. Classic keeps every button, as vanilla screens do.

Fixes #812
Fixes #815

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:12:42 +02:00
Ludovic Marie 782d93bf99 Release the session lock before closing it, as DirectoryLock.close does
A world's session.lock is an flock held by the open file. Closing the file
releases it only once every copy of the descriptor is gone, and a process
spawned on another thread holds a copy until it execs. Under a parallel
cargo test (crash reports spawn uname/sw_vers), deleting a world right after
dropping its lock could then fail with "already open". Unlock explicitly
in Drop, as vanilla releases the FileLock before closing the channel.

Fixes #749

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:12:42 +02:00
Ludovic Marie e1d39b9787 Merge pull request #1109 from ludovic111/tools/chunk-harness-postprocess
🤖 Agent: merged. Verify and CI parity pass (chunk harness tooling).
2026-10-22 01:03:10 +02:00
Ludovic Marie 0dd31c0757 horizon-server update: semver tags (v0.2.0) follow every date tag
From 0.2 Horizon's game releases are tagged vMAJOR.MINOR.PATCH (docs/versioning.md). newer() compared
tags number by number, so v0.2.0 looked older than v2026.10.19.15 and an installed server would never
offer or install it. Every semver tag now outranks every date tag; within semver, patch and minor
compare as numbers and a pre-release (v0.3.0-rc.1) comes before its release. Pruning old releases
sorts with the same order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 00:29:34 +02:00
Ludovic Marie 2d586fac52 Merge pull request #1107 from ludovic111/fix/beehive-break-releases-bees
🤖 Agent: merged. Verify passes. Local integration of #1101–#1107 on main caeffffb: parity --changed 302/304, and the two failures (block_particles, entity_model) fail identically on plain main. CI parity's secure_chat failure on #1101 logged 'transcripts identical' (flaky).
2026-10-22 00:17:45 +02:00
Ludovic Marie ef1142ab49 Merge pull request #1101 from ludovic111/fix/explosion-knockback-resistance
🤖 Agent: merged. Verify passes. Local integration of #1101–#1107 on main caeffffb: parity --changed 302/304, and the two failures (block_particles, entity_model) fail identically on plain main. CI parity's secure_chat failure on #1101 logged 'transcripts identical' (flaky).
2026-10-22 00:17:41 +02:00
feeldev c833fbe212 fix(benchmark): create the world folder before writing its marker
`open` replies once the world starts opening on a worker, so the save
folder may not exist yet when the benchmark writes horizon-benchmark.txt
into it. On a slower device (an Android phone) the write failed with
"No such file or directory" and the run ended before the first scene.
2026-10-21 17:04:34 -05:00
Ludovic Marie 4eaa0251e2 Cave culling: see the world from above or below its height
With the camera above the build height (or below the bottom), vanilla's
SectionOcclusionGraph.initializeQueueForFullUpdate seeds the search with
the top (bottom) layer of sections around the camera instead of the
camera's own section. Horizon started from the camera's section and could
only step one section past the world's edge, so from y 352 up (two
sections above the top) it reached nothing and every chunk vanished.

Fixes #1037

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 23:09:57 +02:00
Ludovic Marie b7390d783b Merge pull request #1106 from ludovic111/fix/attack-knockback
🤖 Agent: merged. Verify passes; CI parity passes except dedicated_server, which fails the same way on main (play-pearl teleported 0 vs 1, the known flake in FEATURES.md LATER).
2026-10-21 23:02:44 +02:00
Ludovic Marie aac5ff91e7 Merge pull request #1104 from ludovic111/fix/elytra-hop
🤖 Agent: merged. Verify passes; CI parity passes except dedicated_server, which fails the same way on main (play-pearl teleported 0 vs 1, the known flake in FEATURES.md LATER).
2026-10-21 23:02:40 +02:00
Ludovic Marie 7f4de08a9a Merge pull request #1102 from ludovic111/fix/no-use-while-using-item
🤖 Agent: merged. Verify passes; CI parity passes except dedicated_server, which fails the same way on main (play-pearl teleported 0 vs 1, the known flake in FEATURES.md LATER).
2026-10-21 23:02:37 +02:00
Ludovic Marie b8261b3270 Merge pull request #1105 from ludovic111/fix/attribute-swapping
🤖 Agent: merged. Verify and CI parity pass.
2026-10-21 23:02:07 +02:00
Ludovic Marie e3cea08736 Boats: the water patch hides water inside the hull; the riding camera turns smoothly
BoatRenderer draws its water_patch part with RenderTypes.waterMask (depth
only) unless the boat is under water, so translucent water behind it fails
the depth test inside the hull. Horizon loaded the part but never drew it:
the water surface showed through the boat. The patch now draws with a
depth-only Water mask pipeline after the entities and before translucent
terrain (rafts have none, as RaftRenderer).

Turning in a boat stepped the camera at the tick rate: positionRider adds
the boat's deltaRotation to the passenger's yRot after its yRotO was kept,
and LocalPlayer.getViewYRot interpolates a passenger's yaw between them.
The camera now spreads the turn over the tick's frames.

Fixes #1016

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 22:33:08 +02:00
Ludovic Marie 7404c2b94e Sky, fog and water fog colours blend across biomes (GaussianSampler)
The camera's biome alone gave the sky, fog and water fog colours, so they
jumped at every biome boundary (most visibly the Nether fog). Vanilla's
EnvironmentAttributeProbe weights the noise biomes of a 6x6x6 quart
neighbourhood around the camera with GaussianSampler's kernel and lerps
the spatially interpolated attributes between them
(SpatialAttributeInterpolator, ARGB.srgbLerp); unloaded chunks count as
plains.

Fixes #797

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 22:33:08 +02:00
Ludovic Marie 621b791a33 End crystals spin and bob in every dimension
EndCrystal.tick advances the crystal's time wherever it is; only the fire
at its block needs a dragon fight. Horizon advanced it only during the End
fight, so a crystal placed elsewhere kept a fixed time and jumped back
every tick (it flickered instead of turning).

Fixes #1051

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 22:33:07 +02:00
Ludovic Marie 38b16f44cb Terrain particles: the model's particle sprite and vanilla tint sources
Breaking, mining, landing and other block particles took the block's up
face and a fixed grass or foliage colour, so grass blocks crumbled as
tinted grass tops (moss-like). Vanilla's TerrainParticle uses the model's
particle material (first variant / first multipart selector) and tint
source 0's colorAsTerrainParticle: the biome-blended in-world colour,
none for grass blocks (BlockTintSources.grassBlock) or blocks without a
source. The in-wall screen overlay and block markers use the particle
material too.

Fixes #1034

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 22:33:07 +02:00
Ludovic Marie 8b0872f901 Elytra: a landing glide lasts one more tick, so hops keep their speed
The glide flag is the server's: LivingEntity.updateFallFlying clears it when
canGlide fails (the player is on the ground), from the position the client
sent, and the client gets the change on its next tick. So in vanilla a glide
that lands goes on for one tick on the ground, with travelFallFlying's drag
instead of ground friction, and a jump on that tick (with its sprint boost)
keeps the speed: the elytra hop. Horizon ended the glide on the landing tick,
so each hop lost about half of the speed to ground friction.

Fixes #1056

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:54 +02:00
Ludovic Marie d32fd5457a Beehives: nests grown in the live level get their block entity and bees
BeehiveDecorator stores 2 or 3 bees in the nest's block entity. World
generation kept them, but trees placed in the live level (a sapling grown next
to flowers, which picks the *_bees_005 trees, and /place feature) dropped them:
LevelFeatureWorld had no store_beehive_occupants, so the nest had no block
entity at all. Breaking it released nothing and bees could not enter it.

LevelAccess gets load_block_entity, the game loads the occupants into the
nest's block entity, and the occupant NBT is shared with world generation.

Fixes #1097

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:32 +02:00
Ludovic Marie 9d9f259f94 Combat: sprint and yaw knockback (Player.causeExtraKnockback); vanilla knockback on the player
Player.attack adds causeExtraKnockback after the hurt: the weapon's knockback
enchantment (halved) plus 0.5 for a sprinting full-strength hit, pushed along
the attacker's yaw (sin, -cos) rather than away from it, which lets a player
steer a hit target by turning while attacking (knockback displacement).
Horizon had only the enchantment part, on mobs; sprinting hits added nothing
and players (LAN PvP) got no extra knockback at all. Now:
- player hits on mobs and players: one extra knockback of that strength with
  LivingEntity.knockback (knockback resistance, lift only from the ground),
  the attack.knockback sound, and the attacker's sprint stops;
- the knockback a player takes (mob and PvP hits, dealDefaultKnockback with
  0.4) reads its knockback resistance (netherite) and only lifts from the
  ground: an airborne player kept being thrown up by every hit.

Fixes #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:32 +02:00
Ludovic Marie c01739300a Combat: attack damage and speed come from last tick's main hand (attribute swapping)
The player's ATTACK_DAMAGE and ATTACK_SPEED modifiers change in
LivingEntity.detectEquipmentUpdates, once a tick, while Player.attack reads
the weapon's enchantments and smash bonus from the stack in hand at the
attack. So swapping hotbar slots just before an attack hits with the old
item's damage and charge and the new item's enchantments (a Wind Burst or
Breach mace after another weapon): attribute swapping. Horizon read both from
the item in hand at the attack.

Also Player.tick's reset: switching to a different item now resets the attack
strength the damage uses (only the indicator's ticker reset before), for the
host and for LAN guests.

Fixes #505

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:32 +02:00
Ludovic Marie 9d96bb6ec7 Explosions: knockback reads explosion_knockback_resistance; armor enchantment modifiers stack per slot
Two Blast Protection pieces now cancel explosion knockback (#1049):
- ServerExplosion.hurtEntities scales knockback by EXPLOSION_KNOCKBACK_RESISTANCE
  for living entities. The player's knockback ignored it, and mobs used
  KNOCKBACK_RESISTANCE (iron golems were never pushed; vanilla pushes them,
  every type's explosion resistance base is 0).
- EnchantmentAttributeEffect.idForSlot: the modifier id ends with the slot,
  so the same enchantment on two armor pieces adds up. The id was
  <id>.<level>, so the second piece replaced the first.
- hitPlayers skips creative players who are flying: no knockback for them.

Fixes #1049

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:31 +02:00
Ludovic Marie 2c47e79cc7 Use: no block placing or item use while an item is in use
Minecraft.handleKeybinds only calls startUseItem while the player is not
using an item: use clicks are consumed and held use doesn't repeat. Horizon
repeated held use every 4 ticks regardless, so with a shield raised in the off
hand, aiming at a block placed the main hand's block (or spawn egg, boat...).

Fixes #1050

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:31 +02:00
Ludovic Marie 705be141d7 Elytra: a glide that isn't diving keeps the fall distance at 1
LivingEntity.updateFallFlying starts with Entity.checkFallDistanceAccumulation:
while gliding and falling slower than 0.5 blocks a tick, the fall distance is
capped at 1. Horizon kept accumulating it for the whole glide, so landing after
gliding down (or after climbing and gliding back) dealt the full drop's damage.

Fixes #1046

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 21:06:31 +02:00