free_port (7 copies), offline_uuid (4), varint and parse_varint (3 and 2),
dbits (6), fbits (4) and settled (2) move into lab.py; every caller uses
lab's. The other server harnesses keep importing free_port from
test_dedicated_server_parity, which now takes lab's. Imports the moved
code left unused go too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three races made the two sides differ with nothing wrong in Horizon:
- Steps ended on a fixed 1.5 s sleep. On a slow run a chat or its
broadcast (vanilla queues the chat, then the broadcast as a later
task) landed in the next step. Each step now also ends on a barrier:
every connected client sends `random value 1..2` twice, and waits for
the answer, which only the sender gets and which is left out of the
transcript.
- The client closed every socket at once, and the server logs
"<name> lost connection" in whatever order its network threads see
the closed connections. The players still connected now leave one at
a time: each waits until it has been told the previous one left
(PlayerList.remove broadcasts that after logging). The harness waits
for Carol's line before stopping the server.
- A player the server kicks (Bob, Mallory) is logged as
"lost connection: <reason>", or as "Disconnected" when vanilla's
network thread closes the connection before disconnect(reason) runs.
The reason sent is still compared in the transcript, so the log line
no longer compares it for kicked players.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chat session updates with their profile key checked against the services'
keys, signed chat and the message chain, last-seen acknowledgements, the
signature cache, signed say/me/msg, enforce-secure-profile, and vanilla's
log lines. Offline servers and players without a chat session chat
unsigned, as on vanilla. tools/test_secure_chat_parity.py compares both
servers with test keys and a mock services server.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>