Commit Graph

649 Commits

Author SHA1 Message Date
Ludovic Marie 35f0b5ec30 Read creative toolbars (hotbar.nbt) through the HOTBAR data fixers, compared with HotbarManager
EmptyItemInHotbarFix was missing from the data fixers. horizon_client::hotbar loads the nine rows of nine stacks of an older file as vanilla does: lenient counts, unregistered items empty, stray entries dropped from their row, a row that is no list ending the reading, short rows lost and long ones cut.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 06:21:56 +02:00
Ludovic Marie a7606c4ad4 Compare the resource pack screen's drawing with vanilla
horizon_client::pack_screen ports PackSelectionScreen, its two
TransferableSelectionLists and the ConfirmScreen of an incompatible pack as
vanilla's state machine (clicks, wheel, search typing, focus, selection,
scroll) and gives its GUI calls; screen_draw holds the widgets (StringWidget,
MultiLineTextWidget, Button, a font-aware EditBox port) and StringSplitter's
line splitting with legacy codes. Pack components keep their legacy codes and
style fields. tools/test_pack_screen_parity.py runs a real
PackSelectionScreen through the same actions: 1500/1500 cases match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 06:07:04 +02:00
Ludovic Marie 7c8afc8a34 Merge branch 'parity-base' into parity/server-leftovers
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 05:44:19 +02:00
Ludovic Marie 0a2601c33a Send recipes, advancements and command replies to players as vanilla does
- ClientboundUpdateRecipesPacket at join: the recipe property sets and the
  stonecutter's recipes, from the data pack (lan/recipes.rs).
- On a player's first tick the minecraft:tick criteria are met: the recipes
  their advancements grant go out in ClientboundRecipeBookAddPacket, then
  ClientboundUpdateAdvancementsPacket with what the player may see
  (lan/advancements.rs).
- Command replies reach remote players as the components vanilla sends:
  Text keeps the Component it was built from (literal, translatable,
  siblings, style), sendFailure wraps the message as vanilla does, and the
  NBT wraps the elements of mixed lists.

The dedicated-server harness drops its known gaps: it compares these
packets (sorted where vanilla's hash maps order them per run) and the
replies to three failing commands, keeps only the first set_time among the
joining packets and turns random ticks off in the generated world.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 05:43:51 +02:00
Ludovic Marie b28fcec7f0 Compare the ghost recipe of a recipe book click with the vanilla client's
Book::ghost is the one place that places a recipe's ingredients into the grid or furnace slots; the harness runs fillGhostRecipe against the real menus. Fixes found: the result and the dyed, potion and map demo ingredients cycle through every stack (not the first), a furnace's fuels follow the registry's component lookup, and items keep their registry order.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 05:43:31 +02:00
Ludovic Marie d6fd90a347 Merge branch 'parity-base' into parity/menus-golem 2026-10-13 05:36:44 +02:00
Ludovic Marie 23d7ebdfaa Search the recipe book as vanilla's FullTextSearchTree does, over the full tooltip lines of every result
The recipe book view harness now searches: names, parts of names, ids with a colon, odd texts.
Horizon's recipe tooltips lacked attribute modifiers, smithing template, potion, dyed, pot, rocket and disc lines, and the results a display cycles through (map copies, tipped arrows, dyed armour).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 05:35:49 +02:00
Ludovic Marie 765f53b2ba Merge branch 'parity-base' into parity/platform-maths 2026-10-13 05:15:09 +02:00
Ludovic Marie e70c38e578 Send the command tree in vanilla's registration order
The LAN and dedicated servers built the tree from the data generator's
commands report, which sorts each node's children. lan/command_order.rs,
generated from vanilla's Commands(CommandSelection.ALL) by
tools/generate_lan_command_order.py, gives the registration order, and the
dedicated-server harness now compares the tree in order (the game rules,
registered in an identity-hashed order, aside).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:59:34 +02:00
Ludovic Marie 41c4f2247e Merge branch 'parity-base' into parity/menus-golem 2026-10-13 04:48:24 +02:00
Ludovic Marie 8976bd37d4 Select resource packs as vanilla's PackSelectionModel does, compared with vanilla
horizon_client::packs::SelectionModel ports PackRepository's selection and
PackSelectionModel (default positions, fixed and required packs, moving up
and down, commit), and the pack screen uses it. The new pack_selection
harness drives vanilla's model and Horizon's through 4,000 random action
sequences; every state matches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:47:36 +02:00
Ludovic Marie 2756b55b5b Merge branch 'parity/old-saves' into parity-base 2026-10-13 04:37:51 +02:00
Ludovic Marie ed1ea50c8e Merge parity-base into parity/platform-maths
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:31:39 +02:00
Ludovic Marie ab0d708f87 Merge branch 'parity-base' into parity/menus-golem 2026-10-13 03:43:32 +02:00
Ludovic Marie 75336660bb Compare the focused chat with vanilla
The HUD harness's chat cases now also draw the chat as the open chat
screen does: foreground, at the focused height, scrolled, with the scroll
bar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:42:57 +02:00
Ludovic Marie a9fa46fd0a Run the copper golem on CopperGolemAi's brain and compare its chest sorting
The golem's goals are replaced by vanilla's brain (core and idle activities,
the transport cooldown, look-at-player-sometimes, stroll or wait), and
TransportItemsBetweenContainers moves into the library: nearest wanted
chest in chunk and block entity map order, queueing behind golems with a
chest open, the 60-tick interaction with its states, sounds and opener
counts, picking up and putting down (with vanilla's overcounting), visited
and unreachable positions. Weathering draws from the level random after the
living tick; the spin sound is client-local. mob_ai gains seven copper golem
scenarios that print each golem's state, hand and opened chest and every
chest's contents and openers; all match vanilla.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:40:13 +02:00
Ludovic Marie 9ac6d665fb Merge branch 'parity/rendering-gaps' into parity-base 2026-10-13 03:32:19 +02:00
Ludovic Marie 2db50eeca1 Merge branch 'parity-base' into parity/old-saves 2026-10-13 03:27:26 +02:00
Ludovic Marie 19d4146f04 Draw player list heads from players' skins as vanilla does
Profiles' textures properties are unpacked as authlib does and looked up
as SkinManager does (signatures, the local player, allowed texture URLs,
downloads), skins are fetched and processed as SkinTextureDownloader does
and shown from atlas slots. The tab_list harness now runs a real
SkinManager and compares processLegacySkin over 400 PNGs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:16:04 +02:00
Ludovic Marie 558d140fca Compute Math.sin/cos/pow/log10 as HotSpot does on the host architecture
Rust's float functions use the platform libm, and vanilla's own Math
results differ between x86-64 (Intel stubs, close to glibc) and AArch64
(fdlibm, with sin/cos evaluated using fused multiply-adds). jmath picks
the same implementation HotSpot uses on the machine, so options, the
world border's alpha and RandomPos match vanilla on an Apple silicon Mac
as well as on Linux.

The vanilla protocol client no longer records the game-time sync sent
every 20 ticks: whether one arrives before the first chunk batch depends
on when the client joined.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:05:34 +02:00
Ludovic Marie 811e4ff6de Merge parity-base into parity/warden-sculk
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:03:24 +02:00
Ludovic Marie 085cca6aa4 Merge branch 'parity/rendering-gaps' into parity-base 2026-10-13 03:02:44 +02:00
Ludovic Marie 8dc1859369 Merge branch 'parity-base' into parity/spawn-gear
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:02:28 +02:00
Ludovic Marie 360ddcbdba Merge branch 'parity/villager-social' into parity-base 2026-10-13 02:53:42 +02:00
Ludovic Marie eec52f9055 The recipe book draws as vanilla's widgets do; test_recipe_book_render_parity
horizon_client::recipe_book_screen lays out RecipeBookComponent's drawing
(background, search EditBox, tab buttons, the filter CycleButton, the page
of RecipeButtons with its number and arrows, the alternatives overlay,
tooltips) and GhostSlots as vanilla's GUI calls with their poses, and the
game paints them. The new harness builds vanilla's widgets for 600 random
states (VanillaRecipeBookScreenOracle) and compares every call: 600/600.

Ingredients keep their HolderSet order (tags in TagLoader order), which is
how the overlay and ghost slots cycle; the book centres over the menu on
narrow screens as widthTooNarrow does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 02:22:55 +02:00
Ludovic Marie d9054baf44 The loom's result preview draws vanilla's banner flag picture in picture
GuiBannerResultRenderer's flag model and pattern layers, lit with
Lighting.Entry.ITEMS_FLAT and clipped to the 20x40 rectangle, through the
GUI item pipeline. The block entity render harness gains loom result cases
(the oracle submits vanilla's renderToTexture under the PiP pose): 407/407.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 02:03:08 +02:00
Ludovic Marie 1efc825a75 Merge parity/old-saves into parity/old-saves-flat
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 02:00:29 +02:00
Ludovic Marie acdbb3d27a End gateways tick their beam in game: client beamAnimationTick beside the server copy's portalTick
The anim harness now runs vanilla's TheEndGatewayBlockEntity on a client and
a server stand-in (triggerCooldown every 2400 ticks and on entry, block event
1) and compares the beam render state; 40 cases match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 01:55:46 +02:00
Ludovic Marie 955f2be4ae Flattening fixes: numeric block names normalised by the chunk rewrite, unknown entities stay untyped, spawn egg default; band harness also upgrades the old saved data
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 01:26:43 +02:00
Ludovic Marie 42cdea74be LAN discovery as vanilla's list keeps it; test_lan_parity against LanServerPinger and LanServerDetection
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 01:11:55 +02:00
Ludovic Marie 5f5b6119d2 Spawner update tags in chunk packets; harness lists recipes and advancements as known gaps
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:57:10 +02:00
Ludovic Marie 4d62899a10 Harness: force-load the spawn area so both servers serve full chunks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:52:35 +02:00
Ludovic Marie 389d2f9549 Adopt only villagers and creakings born during a mob_ai scenario
Animal babies and dropped items stay out of the comparison, as before the
merge: the probe does not model them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:50:18 +02:00
Ludovic Marie c8370d8e29 Merge branch 'parity/old-saves-flat' (1.12.2 to 1.13.2 fixes) 2026-10-13 00:48:14 +02:00
Ludovic Marie 1ea26de544 Match finalizeSpawn for every case of the harness
A zombie villager's profession comes from its constructor's random, not
the one finalizeSpawn draws from. Allays and withers are no longer marked
persistent to escape despawning: they are kept as removeWhenFarAway and the
wither's checkDespawn keep them, and canPickUpLoot follows the allay's and
the sulfur cube's overrides. A sulfur cube's size sets its attribute
bases, and strength and speed effects count in attribute values. The
oracle's stand-in level gets the sound seed random Level.playSound draws
from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:47:25 +02:00
Ludovic Marie 89d5b27b4c Dedicated server: chunk centre in placeNewPlayer, first-tick entity data; harness normalises vanilla's run-to-run orders
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:44:18 +02:00
Ludovic Marie 85e43462ac Block entity order as vanilla's chunk map iterates; chunk comparison without light values
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:37:51 +02:00
Ludovic Marie 7878013342 Merge parity-base into parity/spawn-gear
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:37:27 +02:00
Ludovic Marie b5a6b6a99e Port LegacyStructureFileFix (1493) and run the file fixes of the range in the band harness
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 00:35:54 +02:00
Ludovic Marie 52a419ac31 Match villager births and footsteps on bed edges
The parent's half of VillagerMakeLove.tryToGiveBirth (eating, the child's
bed and type, resting) runs in its own tick, before it ages; the partner's
follows as an event. A baby's NearestBedSensor keeps its bed when the
reused path heads elsewhere, as vanilla checks for a POI there. Footsteps
come from the block under the feet (Entity.mainSupportingBlockPos), not
the column below the centre. The oracle faces newborns' heads with their
bodies (LivingEntity draws the head yaw from Math.random), and the breeding
scenarios leave one free bed per section (PoiManager hands them out in hash
order).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:35:40 +02:00
Ludovic Marie 7ede56b596 Dedicated server: vanilla console lines, player chat, /list, legacy ping, chunk tracking, heightmaps and light layers
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:32:29 +02:00
Ludovic Marie e0a025c5bd Compare villager gossip and breeding with vanilla
Gossip and gifts between villagers (TradeWithVillager) move into the
library so the mob_ai probe runs them as the game does; both villagers now
lock their gaze on each other, as lockGazeAndWalkToEachOther does. The
probe reads the oracle's villager flags, prints villager data (food,
inventory, gossip, reputation) and adds babies as they are born. The
oracle seeds TriggerGate's shuffles too, which were left to the clock.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:27:35 +02:00
Ludovic Marie 8498688341 Datafix: 1.13 to 1.14 fixes (1800 to 1963); saved data may be plain NBT 2026-10-13 00:26:17 +02:00
Ludovic Marie 8d16a937c5 Dedicated server: load the spawn area; vanilla-codec client harness
VanillaProtocolClient joins a server with vanilla's own codecs;
test_dedicated_server_parity.py compares a vanilla and a Horizon dedicated
server serving the same world.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:18:01 +02:00
Ludovic Marie df0c1ad36e Seed a summoned warden before its first tick, and keep its heartbeat off the server random
The shrieker summons the warden during the block ticks, so it ticks in the
same tick's entity phase: the oracle and the fixture now seed it (its
random, sensor delays and RunOne shuffles) before that phase, not after.
The heartbeat is a client sound: its pitch no longer draws from the
level random, and the fixture leaves it out as vanilla's server never
sends it. sculk: 435/435.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:16:52 +02:00
Ludovic Marie ad2758fc9c Merge parity-base into parity/villager-social
Keeps both sides' oracle scenarios: the creaking hearts, hurts, leads and
animal flags of parity-base on this branch's entity list, with a heart's
creakings adopted under their creation seed. Restores the villager meeting,
birth and golem-check events the unfinished WIP had begun to replace.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:08:10 +02:00
Ludovic Marie d229326779 Datafix harness: --band TARGET checks the fixes up to a DataVersion on legacy-layout worlds; fixes sorted by key 2026-10-13 00:06:19 +02:00
Ludovic Marie af7ad70438 Merge parity-base into parity/warden-sculk
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-12 23:53:02 +02:00
Ludovic Marie 5731a9406f Merge branch 'parity/dedicated-server' (before its WIP commit) into parity-base 2026-10-12 17:55:17 +02:00
Ludovic Marie 404072d5e5 Merge branch 'parity/warden-sculk' (before its WIP commit) into parity-base
# Conflicts:
#	crates/horizon-client/examples/entity_anim_fixture.rs
#	crates/horizon-client/src/game.rs
#	crates/horizon-client/src/game/creatures.rs
#	tools/test_entity_model_parity.py
2026-10-12 17:55:17 +02:00