The effect capped downward gravity but left the fall distance to accumulate, so the landing tick still dealt fall damage. Clear it at the start of check_fall_damage, where both local travel and the server thread's replay of a guest's move pass.
Co-Authored-By: opencode (deepseek-v4.1-flash-free) <noreply@opencode.ai>
CustomBossEvents.onPlayerConnect adds a joining player to its bars before any
entity, dragon fight or raid tells it about theirs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The item-tab hotbar loop only set the tooltip, so the nine slots never
showed the white hover fill the 5x9 grid uses. Apply the same fill,
including over empty slots, before picking the tooltip item.
Fixes#1341
Co-Authored-By: opencode (deepseek-v4.1-flash-free) <noreply@opencode.ai>
The host wrote no trim component, so single player on its server thread,
LAN guests and dedicated-server players saw armour without its trim.
network_stack now takes the connection's synced-registry lookup for any
registry and writes Component::Trim when both names are in it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A server sends its packs in the configuration phase, while the joining
screen covers the frame; vanilla's ToastManager draws over every screen.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The host diffed each viewer's boss events into a Change enum, then turned the
changes into packets for guests and, through a second match, into setter calls
on the window's own overlay; the client turned packets into the same setters a
third way. The diff now yields ClientboundBossEventPacket values, guests get
them as packets and the local overlay applies them with BossOverlay::apply,
the same function a server's packets reach. Gone: Change, Snap, Sent,
apply_local, boss_packet and the overlay's nine-argument add and setters.
UUIDUtil.uuidFromIntArray joins uuid_ints in lan::playerdata.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The settings screen's own options (controller, vibration, dead zones and the
rest) are not vanilla options and have no vanilla keys, so their captions
were English literals. They now read horizon.options.* from assets/horizon/lang,
which the client bundles as one more language source placed first, so a pack
or the prepared root can still override it. English and Russian ship here.
The pre-world overlay said "Joined as {name}; loading terrain..." after
Event::Joined. Vanilla's LevelLoadingScreen only ever draws the
multiplayer.downloadingTerrain text there — use that translation, no
name.
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
What the toast showed differed from vanilla 26.3 in several ways:
- the title and the failure line had no arguments: download.pack.title takes
the request number and the batch size, download.pack.failed the failures
and the batch size;
- sizes read "1.3 KiB" style; com.mojang.realmsclient.Unit.humanReadable gives
"1.3 KB" ("512 B" below 1 KiB, half-up rounding), checked against the jar;
- each update didn't restart SystemToast's 5 s display time, so a download
longer than 5 s lost its toast, and the Notification Time option was ignored;
- a finished batch removed the toast at once instead of forceHide's slide out;
- the failure title sat at y 7 in white; SystemToast draws titles yellow, and a
title without a message at y 12;
- a second batch replaced the first one's channel and lost its events.
The download thread now reports HttpUtil's listener calls (requestStart,
downloadStart with the Content-Length, downloadedBytes, requestFinished), and
each batch gets a PackNotifier (createDownloadNotifier) with its own toast. The
toast is a shared toasts::SystemToast; the system background moved to
toasts.rs with a y, so the pack toasts stack under an advancement toast.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With a pack whose gbuffers_terrain (or a fallback) loads, solid and
cutout terrain is drawn by it into the pack's buffers, in place, between
prepare and deferred, and Horizon's own solid terrain draw is skipped.
- depthtex0 is now a Depth32Float attachment: the blit writes the
world's depth there (GL window depth, GL rows), terrain tests and
writes against it, so entities and terrain occlude each other; later
programs sample it as before.
- The vertex glue reads Horizon's TerrainVertex on both draw paths
(instanced, and flat with the page tables in bind group 1) and gives
atlas coordinates, lightmap coordinates in 0-240, the vertex colour,
mc_midTexCoord at the sprite's centre and mc_Entity = -1. Normals,
tangents and block ids come later.
- texture/gtexture/tex sample the block atlas, lightmap the lightmap;
atlasSize is set.
- Occlusion culling is off while a pack draws terrain (it reads the
depth of Horizon's terrain draw), and flat draws stay on.
- Uniforms a program reads that are not provided yet are reported.
- Program building is shared by quads and terrain (build_pass, bind).
- terrain-test: Horizon's own pack for this slice.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Advancement.decorateName appends a new line and the description to the title's copy;
adv_name replaced the title's extra list, so a title built from siblings (a
plugin's {"text":"","extra":[...]}) reached clients as just the description.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The screen built them from literals, so the buttons stayed English in every
language while the world select screen next to them was translated. Each has
a vanilla key the prepared resources already carry; Friends is Horizon's own
and reads horizon.menu.friends with the English text as fallback.
A proxy switching servers (Velocity, BungeeCord) sends the client back to
configuration. The network thread acknowledged it, but the game thread kept
ticking the old level and its client_tick_end went out right after the
acknowledgement, where the server reads it as configuration packet 13.
Velocity drops the client: "A packet did not decode successfully", shown as
"An internal error occurred in your connection".
Vanilla's handleConfigurationStart clears the level before it acknowledges,
so nothing of play follows. Session::send now drops play packets while the
connection is in configuration, checked under the writer lock that the
acknowledgement is sent with.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mesher::mesh keeps model order, which the leaf-culling test pairs with
the baked faces; the section and tile workers sort what they upload.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
load_post takes the game's terrain vertex inputs and, given them, loads
the first program of gbuffers_terrain's fallback chain that translates
(gbuffers_terrain, textured_lit, textured, basic). Program loading is
shared by the post-processing and gbuffers programs.
The translator no longer rewrites a variable, parameter or member that
has the name of a sampler (`float specular` beside `uniform sampler2D
specular`), which kept Complementary's gbuffers programs from compiling.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two halves of FireworkRocketEntity on a server were missing:
- SetCreativeModeSlot encoded only damage, so a creative-picked rocket
lost its minecraft:fireworks component (flight_duration and explosions
gone); the wire codec also had no decoder for it or firework_explosion,
so a stack carrying them failed to decode at all. The components now
follow Fireworks.STREAM_CODEC/FireworkExplosion.STREAM_CODEC both ways
(component ids 71/70).
- A remote rocket never read DATA_ATTACHED_TO_TARGET,
DATA_ID_FIREWORKS_ITEM or DATA_SHOT_AT_ANGLE, so the server-attached
boost rocket was an inert marker: attached_to now comes from
EntityDataSerializers.OPTIONAL_UNSIGNED_INT (the id plus one), the item
feeds the explosion list, and FireworkRocketEntity.tick's
isFallFlying boost applies to the local player.
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Packs sample blocks from one 2D atlas; Horizon keeps them in sprite
arrays. While a pack is loaded, every layer and its mip levels are
copied into a grid, and the animator reports the layers it rewrote so
only those are copied again. The sprite arrays gain COPY_SRC.
The gbuffers pass binds it in the next slice.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Give integrated and dedicated startup a synchronous loading entry point without client deferral or integrated-server selection. Keep client orchestration and background loading unchanged.
Co-Authored-By: OpenAI Codex GPT-6.1 <noreply@openai.com>
Separate client, integrated-server and dedicated-server roles from connection state. Use roles for startup, presentation work and server dimension loading while preserving in-frame client simulation.
Co-Authored-By: OpenAI Codex (GPT-6.1) <noreply@openai.com>
A mounted mob answered "Found no elements matching Passengers": the command
built the entity with the flat serializer, so `Passengers` was never in the
tag, even though the game had the relationship and saving a world kept it.
Persistence already writes the tree (`Game::mob_tree_nbt`, which also carries
the leash), and vanilla's command path uses the same one, so the command reads
it now.
Fixes#1519.
Co-Authored-By: Hermes Agent (Nous Research) <noreply@nousresearch.com>
- A buffer is cleared only when a program reads it before one writes all
of it; the clears left ride in the blit pass as attachments the blit
shader leaves alone, instead of passes of their own.
- The blit writes depthtex0 only when some program reads it.
- Attachments a pass overwrites whole (the blit's colortex0 and depth,
every composite output, final's window) start cleared rather than
loaded, which spares a tiled GPU reading them back first.
- The blit's bindings are kept until the world target changes size.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first slice that draws: with HORIZON_SHADER_PACK=<name>, the pack in
shaderpacks/<name> (folder or zip) runs its prepare, deferred, composite
and final programs over the world, under the hand and the HUD. Gbuffers
programs come later, so the composites read Horizon's own picture.
- The world renders into its own target (as with a resolution scale); its
colour becomes colortex0 and its reverse-Z depth becomes depthtex0 in
GL's window depth (1 - d for the same planes), rows flipped to GL's
order. depthtex1 and depthtex2 read the same depth for now.
- colortex buffers in the formats the pack asked for (the nearest one
wgpu renders to), created only when a program uses them, each with two
textures: programs read main and write alt, the buffers a program wrote
flip after it, flip.* keys and deferred_pre/composite_pre apply, and
the mapping carries over to the next frame. Clears at the start of the
frame with the pack's colours or the defaults.
- noisetex (256x256 white noise, repeat), a lit stand-in behind shadow
samplers until shadow maps exist, a 1x1 stand-in for other names; the
frame uniforms of the previous commit and the translator's own block.
- final draws onto the window; without it colortex0 is shown.
- Pipelines are built through validation scopes: a program wgpu refuses
is reported with the full error and skipped. The dimension's folder is
reloaded when the player changes dimension.
Nothing changes without the environment variable: players see no change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The values a pack's post-processing programs read once per frame, in
GL's conventions: camera position and the previous one, eye altitude,
up/sun/moon/shadow-light positions in view space (the sky's own frame for
the sun and moon), sun and shadow angles, world time, day and moon phase,
frame counter, frame time and run time, view size and aspect, near and
far, rain, smoothed wetness, thunder, fog colour, start and end, sky
colour, eye in fluid, blindness, night vision, darkness, brightness, GUI
hidden, eye brightness and its smoothed value, and the model-view and
projection matrices with their inverses and last frame's. The projection
is GL's perspective with the world's near and far planes times vanilla's
view bobbing. Each value is written as the type the pack declared.
The game passes what only it knows (day time, weather levels, the fluid
at the camera, light at the camera, blindness, F1, brightness) in the
renderer's Frame when HORIZON_SHADER_PACK is set.
Fix (slice 4): programs that draw to buffers read gl_FragCoord through a
variable only final set; every target sets it now, with a test. Found by
the first frame drawn with a pack.
Nothing reads the uniforms yet: players see no change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As a client (multiplayer, a LAN guest, single player on its server
thread) Horizon ran its own fall damage, fire, freezing, berry bushes and
starvation through the local hurt, so the camera's hurt tilt started even
when the server cancelled the damage (lobbies that turn fall damage off).
Vanilla's client never hurts itself: Entity.hurt does nothing outside a
ServerLevel and FoodData.tick is ServerPlayer's. Its hurt animation comes
from the server: LocalPlayer.hurtTo on a health drop, and
ClientboundDamageEventPacket / ClientboundHurtAnimationPacket for itself.
- PlayerMotion.client_side: hurt_blocking and food_tick do nothing;
landing sounds and fall-distance tracking still run.
- remote: SetHealth flashes on a drop after the first health, and the
player's own damage events and hurt animations restart its hurt time.
- horizon-ctl state reports the player's hurt_time.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both switched on past 4,096 section draws, measured when a section had
2.2 to 2.5 draws. A section's draw count now depends on the sides it shows
the eye, so the bars count sections in view: 1,600, where 4,096 draws fell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The frame loop skips Game::tick while the game is paused, so these never
fired; the server thread's paused pass is what moved the player on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Decode the trim component as its material and pattern registry ids when both
are references (a direct holder stays read past) and name them through the
server's synced trim_material and trim_pattern registries, as enchantments
are, so worn and held trimmed armour draws its trim in multiplayer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A server's custom advancements often name themselves with an empty text and
the words in its siblings ({"text":"","extra":[...]}); only the top-level
text or translate key was read, so their tooltips were blank. Read them as
the component they are (ComponentSerialization), with siblings, styles,
translation arguments and fallbacks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- predict_use and predict_place set their blocks through one
predict_blocks (retainKnownServerState), instead of two copies of the
loop.
- remote_can_place returns where BlockItem.place put the block, and the
placer hears the place sound there: before, set_block only played it at
the clicked face's neighbour, so a block that replaced grass or snow
where the player clicked made no sound for its placer now that the
server leaves the placer out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A frozen level (TickRateManager.isEntityFrozen) ticks only the players, so
their fluid contact is the only one that moves on, as in the loop below.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Measured on the built branch: it does not stop the drowning from #1592 on
its own. Kept because it is what forcing the level to stand still looks
like, and the negative result is in the PR.
Co-Authored-By: Hermes Agent (Nous Research) <noreply@nousresearch.com>
The window's own tick doesn't run while paused (the frame loop skips
Game::tick), so the two gates added there never fired. What kept going was
the server thread: its paused pass still ran tick_guests, the players'
doTick, so air, hunger and drowning damage moved on behind the pause menu.
Vanilla's IntegratedServer.tickPaused only ticks the connections, and
ServerGamePacketListenerImpl.tick skips tickPlayer while the server is
paused. tick_lan now does the same: the paused pass keeps the connections
and skips tick_guests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- AbstractBoat.push(player) moves the player too: the boat's own tick and
the player's pushEntities run on the player's client in vanilla
(pushableBy lets a client push only its local player), so the window's
player is pushed in-frame and a server's client pushes itself in
remote_pushes, as it does for mobs.
- A mob the boat would take that can't get in (boarding cooldown, boat
under water) is left alone, not pushed: the tick calls startRiding,
which fails quietly, instead of push.
- Mob.startRiding drops the mob's lead.
- look_at_entity reuses the guest's eye position.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`m.fluids` is filled by `Mob::update_fluids`, which only runs in the mob tick
on the server. A window that is a client of a server never runs that tick, so
every mob it draws kept the default `Fluids { in_water: false }` for its whole
life. Cod, salmon and tropical fish rotate onto their side while `!in_water`
(`mobs/aquatic.rs`), so they were drawn lying on their flank in water, while
their position and heading, which come from the server, looked correct (#1591).
`tick_remote_entities` now runs vanilla's `EntityFluidInteraction.update` for
the displayed mobs before it ticks their animations, so the renderers read the
water contact the same way they do for a mob the window simulates itself.
Fixes#1591.
Co-Authored-By: Hermes Agent (Nous Research) <noreply@nousresearch.com>
Air kept draining behind the Escape menu in singleplayer and the drowning
damage landed on closing it. The server pauses (`IntegratedServer::set_paused`
reads the flag), but the window's own copy of the player kept running
`controlled_simulation_tick` every frame, and that is where
`tick_environment_damage` decrements the air and pushes `MotionEvent::Drown`.
`Minecraft.tick` skips the level while the game is paused, so both local paths
now skip the player's simulation: the client of a server (`tick_remote_level`)
and in-frame single player. Keys are already neutral when a screen is open, so
this only stops the environment, hunger and fall prediction from running ahead
of the paused server.
Fixes#1592.
Co-Authored-By: Hermes Agent (Nous Research) <noreply@nousresearch.com>
#1570 landed the client pack manager without vanilla's
PackDownloadNotificationComponent: the SystemToast that follows a
download with download.pack.progress.percent or .bytes and stays as
download.pack.failed when a batch fails. The download queue reports
requestStart/downloadedBytes/downloadFinished on a channel (vanilla's
DownloadProgressListener), the game ticks them into a toast it slides
in for the vanilla 5 seconds with the toast in/out sounds.
Co-Authored-By: Devin <devin@cognition.ai>
BlockItem.place plays it with playSound(player, ...): the server sends it to
the others, and the placer's client plays it as its block appears. The
server sent it to the placer too, so each block sounded twice.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The clientbound boss_event packet (add/update/remove/style/progress), a
BossOverlay that renders each bar, darkens the world under a wither, and
suppresses the create-the-world fog — vanilla's BossHealthOverlay and
GameRenderer behaviour on a real server.
Co-Authored-By: Devin <devin@cognition.ai>