Commit Graph

2131 Commits

Author SHA1 Message Date
Ludovic Marie 494afc8dc3 Merge pull request #1002 from ludovic111/fix/player-equip-sound
🤖 Agent: merged after verify passed and local proof (menu_click fails on main 7978/8000, passes with the fix; place_recipe passes). The player's armour equip sound and event follow every vanilla path. Fixes #986 (reported by famescare).
2026-10-19 13:17:32 +02:00
Ludovic Marie 451318860e Merge remote-tracking branch 'origin/main' into pr578 2026-10-19 12:48:48 +02:00
Ludovic Marie 7426aed33c Play the equip sound when the player puts on armour
LivingEntity.onEquipItem now runs for the player wherever vanilla calls
it: the inventory menu's ArmorSlot and off-hand slot (setByPlayer, in the
menu engine, so clicks, shift-clicks, number keys, drags and LAN guests'
clicks), right-click equipping (Equippable.swapWithEquipmentSlot), the
creative screen (every changed slot, as handleSetCreativeModeSlot sets it),
the swap-hands key, dispensers (now also a shield into the off hand) and
/item and /loot on armour slots. It plays Equippable.equipSound (the
generic armour sound by default) on PLAYERS when the item lands in its own
slot, and emits equip/unequip game events for armour; nothing for
spectators, on a client, or when the item is unchanged.

The menu click harness's oracle now records vanilla's onEquipItem calls.

Fixes #986

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 12:43:01 +02:00
Ludovic Marie 5c88c46c51 Merge pull request #1001 from ludovic111/fix/guest-projectile-owner
🤖 Agent: merged after verify passed. Remote players' projectiles record their owner: ender pearls teleport and hurt the thrower, mobs target the shooter; docs/server.md row updated; part of #484.
2026-10-19 11:52:38 +02:00
Ludovic Marie f7d2a0b311 Merge pull request #1000 from ludovic111/fix/pvp-friendly-fire
🤖 Agent: merged after verify passed. Teammates with friendly fire off no longer hurt each other on a server (lan_e2e pvp); part of #484.
2026-10-19 11:52:26 +02:00
Ludovic Marie 97993634c0 Merge pull request #999 from ludovic111/fix/guest-use-item-on
🤖 Agent: merged after verify passed. A remote player's item used on a block is used once (a snowball thrown at the ground flew 2× main hand / 3× off hand); part of #484.
2026-10-19 11:50:11 +02:00
Ludovic Marie 092bf87012 Server: a guest's projectiles are theirs (ender pearls take them)
A projectile a guest shot was recorded as the local player's (Who::Player), which on a
server means the host, or nobody on a dedicated server. So a guest's ender pearl
teleported the host on a LAN world and did nothing on a dedicated server, what it hit
answered to the host, and clients were told the projectile had no owner.

Projectiles now remember the guest who shot them (Projectile.guest, set when the
guest's turn ends). Clients get the guest as the owner (Projectile.getAddEntityPacket),
and the hit runs as that guest: their pearl teleports and hurts them, and the mob hit
answers to them. ThrownEnderpearl's endermite also needs monsters to spawn, and comes
where the player was.

The dedicated-server harness checks that the snowballs' owner is the player and throws
an ender pearl at the player's feet: vanilla teleports it and takes 5 health, main did
neither.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 11:11:44 +02:00
Ludovic Marie ca1e3a17c8 Server: a right click with an item on a block uses it once
A vanilla client sends a right click as one packet per hand and part
(Minecraft.startUseItem): UseItemOn for the block's part and ItemStack.useOn, then
UseItem for Item.use when that passed, the main hand first. The server ran the whole
click, both hands, for UseItemOn, then the item again for UseItem: a snowball thrown
at the ground flew twice, three times from the off hand.

Each packet now does its own part with its own hand
(ServerGamePacketListenerImpl.handleUseItemOn / handleUseItem): UseItemOn stops at
useOn (no throwing, drinking, eating, raising, equipping, buckets or an ender eye off a
frame), and neither touches entities (Interact does). Horizon's own client, which
counted on the server trying the off hand, now sends the off hand's packets when the
main hand's use passes, as vanilla's does. UseItem's rotation is the player's now
(absSnapRotationTo) without sending the client a teleport back.

The dedicated-server harness right-clicks the ground with a snowball in the main hand,
then in the off hand, and counts the snowballs against vanilla's (2 and 3 on main,
1 and 1 now).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 11:11:19 +02:00
Ludovic Marie b0c8f964b2 Server: players on one team without friendly fire don't hurt each other
Player attacks between the host and guests, or two guests, only checked the pvp game
rule. ServerPlayer.canHarmPlayer also asks the victim's team (Player.canHarmPlayer):
an ally on a team with friendlyFire false takes no damage, and the attacker hears the
no-damage sound.

lan_e2e's pvp check puts both players on such a team and checks that neither hurts
the other.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 10:34:03 +02:00
Ludovic Marie 4953305c7b Server: run a dead player's chat commands, as vanilla does (#973)
A dead guest's packets were all dropped but the respawn request, so a command typed on
the death screen never ran. ServerGamePacketListenerImpl.handleChatCommand and
handleSignedChatCommand don't look at the player's health: the commands now run.

The dedicated-server harness sends `/trigger nope` from the death screen and compares
the reply with vanilla's before respawning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 10:34:02 +02:00
Ludovic Marie 272414cc05 Merge remote-tracking branch 'origin/main' into feat/dx12-fallback
# Conflicts:
#	crates/horizon-client/src/graphics.rs
#	crates/horizon-client/src/graphics_ui.rs
2026-10-19 09:31:58 +02:00
Ludovic Marie aac0dc7f60 Merge pull request #966 from ludovic111/feat/server-update
🤖 Agent: merged after verify and CI parity passed. horizon-server update (SHA-256 check, world backup, switch, health wait, automatic rollback) and rollback; 6-hourly update notice in log, status and panel. Proven end to end on the Mac mini and the ThinkPad (healthy update, crash rollback, timeout rollback, manual rollback, real GitHub download); 37 unit tests.
2026-10-19 08:33:03 +02:00
Ludovic Marie fcb37f05e9 Merge pull request #965 from ludovic111/fix/server-relative-dir
🤖 Agent: merged after verify and CI parity passed. horizon-server run --dir <relative> no longer crash-loops the game; new test fails without the fix.
2026-10-19 08:32:51 +02:00
Ludovic Marie 0af3dd3900 Merge pull request #959 from ludovic111/feat/carry-yung-modifiers
🤖 Agent: merged after verify and CI parity passed, and a combined check with rdbt's #796 on current main (fmt, clippy, 359 tests, 14 world-gen harnesses). YUNG/Moog terrain adaptation around structures (Better Fortresses netherrack inside bridges 39–41 % → 2.5–7 %), its carry, and YUNG modifiers.
2026-10-19 08:10:05 +02:00
Ludovic Marie 0def8931cb Merge pull request #956 from ludovic111/feat/carry-terrain-adaptation
🤖 Agent: merged after verify and CI parity passed, and a combined check with rdbt's #796 on current main (fmt, clippy, 359 tests, 14 world-gen harnesses). YUNG/Moog terrain adaptation around structures (Better Fortresses netherrack inside bridges 39–41 % → 2.5–7 %), its carry, and YUNG modifiers.
2026-10-19 08:09:53 +02:00
Ludovic Marie 39b74fb468 Merge pull request #955 from ludovic111/feat/enhanced-terrain-adaptation
🤖 Agent: merged after verify and CI parity passed, and a combined check with rdbt's #796 on current main (fmt, clippy, 359 tests, 14 world-gen harnesses). YUNG/Moog terrain adaptation around structures (Better Fortresses netherrack inside bridges 39–41 % → 2.5–7 %), its carry, and YUNG modifiers.
2026-10-19 08:09:41 +02:00
Ludovic Marie b464f977f1 Merge pull request #796 from rdbtCVS/t3/optimize-noise-aquifers
🤖 Agent: merged, thanks rdbt! Bulk density arithmetic, the shared Beardifier kernel and Perlin column reuse: 12.685 → 10.069 ms/chunk Overworld terrain (−20.6 %, one worker). We merged current main in (density/tests.rs: kept both test sets) and checked it together with #955/#956/#959: fmt, clippy -D warnings, 359 core/world/port-pack tests, and 14 world-gen harnesses (density, noise, structure_density, server_world_gen, world_spawn, decorated_region, …) all pass.
2026-10-19 08:09:26 +02:00
Ludovic Marie c5656493cd Merge pull request #977 from ludovic111/feat/renderer-startup-steps
🤖 Agent: merged after verify passed. The renderer logs each start-up step once per device (driver, requested features and limits, surface, pipelines, first acquire/submit/present), so a native crash's last log line names the step.
2026-10-19 08:02:21 +02:00
Ludovic Marie 99b07dc810 Merge remote-tracking branch 'origin/main' into pr/796
# Conflicts:
#	crates/horizon-core/src/density/tests.rs
2026-10-19 07:58:32 +02:00
Ludovic Marie d2e8e5fe28 Merge pull request #771 from Online5277/feat/terrain-lod
🤖 Agent: merged, thanks Online5277! Terrain LOD lands off by default. With LODs off it matches main (0 differing pixels in 6 RD16 views, same FPS/GPU ms on the HD 620, same time to full render distance); CI verify and parity pass. We merged main in three times and adapted it to #905/#939 and the packed texture coordinates. The follow-ups from the review (edge band, integrated-GPU cost, lighter far meshes) we're taking on ourselves.
2026-10-19 07:49:12 +02:00
Ludovic Marie 8aacf93d8f DirectX 12 on Windows: the fallback when Vulkan fails, and a setting (#746)
The Windows client builds wgpu's dx12 backend. With graphicsApi:auto (the
default), the renderer opens Vulkan and falls back to DirectX 12 when Vulkan
has no adapter (no Vulkan driver) or its device request fails; vulkan and dx12
pick one (horizon-graphics.txt, Video Settings > Graphics API on Windows, or
HORIZON_GRAPHICS_API; WGPU_BACKEND still overrides). Other systems keep their
one backend.

DirectX 12 keeps wgpu's indirect-draw validation: it is what passes each
draw's first instance to shaders there. Occlusion culling stays Vulkan-only and
flat draws Metal-only, as before; multi-draw and the GPU timer use DirectX 12's
own. gpu-allocator now resolves to the windows crate wgpu-hal's dx12 code
uses (0.62): with cpal's 0.54 it did not compile. A test translates every WGSL
shader to HLSL as the dx12 backend does for FXC.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 07:34:16 +02:00
Ludovic Marie 70de685d2b Log each step of the renderer's start (#746)
A native crash in the graphics driver leaves no panic or crash report: the
last log line is all a player can send. After the adapter line, log the
driver, the features and limits the device is requested with, the surface
configuration, the pipelines (with multi-draw, occlusion culling and the GPU
timer on or off) and the first frame's acquire, submit and present, once per
device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 07:27:44 +02:00
Ludovic Marie 21ac62a085 Merge pull request #972 from ludovic111/perf/sculk-unload-once
🤖 Agent: merged after verify passed and local proof (sculk harness). Sculk drops every unloaded chunk's blocks in one pass: worst tick 583–609 → 38–44 ms with 40 bots.
2026-10-19 07:15:24 +02:00
Ludovic Marie cf5a979b35 Merge pull request #971 from ludovic111/perf/heightmaps-on-helpers
🤖 Agent: merged after verify passed and local proof (heightmap, chunk_stage, lan, …). Chunk-packet heightmaps are built on the warm-up threads; bytes identical; lan_chunks −11–13 %.
2026-10-19 07:15:15 +02:00
Ludovic Marie d157880712 Merge pull request #970 from ludovic111/perf/server-thread-first
🤖 Agent: merged after verify passed and local proof on the integration commit (8 harnesses, lan_e2e both modes). The server thread runs ahead of the workers on macOS and Windows, like vanilla's Thread.setPriority(8): 40 bots tick p99 101.5/77.7 → 32.8/32.7 ms, ticks over 50 ms 166/146 → 1/2.
2026-10-19 07:15:05 +02:00
Ludovic Marie 9e98c1902b Merge remote-tracking branch 'origin/main' into pr854
# Conflicts:
#	crates/horizon-client/src/game/remote.rs
2026-10-19 06:40:04 +02:00
Ludovic Marie 78e8556e5a Merge pull request #800 from LookImEcho-Rick/codex/issue-592-nether-teleport
🤖 Agent: merged, thanks LookImEcho-Rick! It was still marked draft, but its description was complete and our checks were done, so we marked it ready. /execute in <dimension> now moves the player across dimensions like vanilla (fixes #592). With main merged in and the #947 fix (#962), command_exec, command_parse, server_dimension_players and dedicated_server pass locally, and verify passes. If you meant to add more, a follow-up PR is welcome.
2026-10-19 06:29:47 +02:00
Ludovic Marie 1f16677a44 Merge pull request #963 from ludovic111/feat/processor-random-and-condition
🤖 Agent: merged after verify passed and parity --changed 311/311 locally. Lithostitched apply_random, condition and set_block in the game: CTOV farms grow carrots, potatoes and beetroot, paths and mossy cobblestone appear.
2026-10-19 06:20:58 +02:00
Ludovic Marie 0ceede079e Merge pull request #964 from ludovic111/feat/carry-apply-random-condition
🤖 Agent: merged after verify passed and parity --changed 311/311 locally. Carry for Lithostitched apply_random, condition and set_block (130 dropped → 0).
2026-10-19 06:20:48 +02:00
Ludovic Marie 9ed2f482af Merge pull request #960 from ludovic111/feat/carry-processor-references
🤖 Agent: merged after verify passed and parity --changed 311/311 locally. Lithostitched reference processors carried: 83 dropped → 0.
2026-10-19 06:20:39 +02:00
Ludovic Marie 995187d82d Merge pull request #958 from ludovic111/feat/yung-modifiers
🤖 Agent: merged after verify passed and parity --changed 311/311 locally on the integration commit. YUNG modifiers, piece_in_range and dead-end pools (game side).
2026-10-19 06:20:28 +02:00
Ludovic Marie f3a3dd22bd Merge pull request #957 from ludovic111/fix/carry-json-comments
🤖 Agent: merged after verify and CI parity passed. The carry reads data files with comments as Minecraft does; six Better Fortresses pools come back (265 → 3,765 pieces over seed 1234's Nether centre).
2026-10-19 06:20:19 +02:00
Ludovic Marie cd4f8ba849 Merge pull request #954 from ludovic111/fix/stronghold-ring-biome-search
🤖 Agent: merged after verify passed and local proof on one integration commit of modpacks-9's PRs: parity --changed 311/311, structure-start oracle 3,153/3,153. CI parity's only failure was secure_chat, which this change doesn't touch. Stronghold rings 3/128 off → 0/128 on seeds 1234, 2, 3, 42, -7.
2026-10-19 06:20:09 +02:00
Ludovic Marie 874d62b49b Merge remote-tracking branch 'origin/main' into pr800 2026-10-19 05:55:51 +02:00
Ludovic Marie ee4b4c7834 Merge pull request #962 from ludovic111/fix/level-switch-entities
🤖 Agent: merged after verify and CI parity passed (command_exec 764/764 three times locally, 20 affected harnesses). /summon no longer spawns other pending entities and takes their id; the harness settle waits for entities like vanilla's. Fixes #947.
2026-10-19 05:55:41 +02:00
Ludovic Marie 3ce89ebb8a horizon-server update: report a switch without an install instead of staying busy
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:31:08 +02:00
Ludovic Marie bf2c5e7946 horizon-server update: wait for the old game after a rollback; document updates
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:30:21 +02:00
Ludovic Marie 0e025df8e1 Server thread: ahead of the workers on macOS and Windows, as vanilla's spin
MinecraftServer.spin raises its server thread (Thread.setPriority(8)) when
there are more than four processors. The new horizon-threads crate makes the
same request for the dedicated server's thread and the integrated server's:
user-interactive QoS on macOS, above-normal priority on Windows, nothing on
Linux (an unprivileged thread can't raise itself).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:27:50 +02:00
Ludovic Marie 857a88351f horizon-server update and rollback: switch releases, roll back by itself when the game doesn't come up
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:21:26 +02:00
Ludovic Marie a8682eb4c5 horizon-server: give the game its folders whole when --dir is relative
`horizon-server run --dir srv` (what init prints) started the game in srv/ with
--control-socket srv/.horizon/engine.json, which the game resolved inside srv/,
so it crashed at every start. spawn now passes absolute paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:20:36 +02:00
Ludovic Marie cd99c1c683 Sculk: drop the blocks of every unloaded chunk in one pass
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:01:18 +02:00
Ludovic Marie 3667bb963c Chunk batches: make the columns' heightmaps on the warm-up threads too
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 05:01:18 +02:00
Ludovic Marie f62e07c36a Read GPU readbacks without assuming the mapping's alignment
A Vega 11 on Windows (Vulkan) panicked at launch in bytemuck's cast_slice
with TargetAlignmentGreaterAndInputNotAligned, starting with the release
that shipped occlusion culling. The section-test results and the GPU
timer's timestamps were cast in place from the mapped range, which isn't
guaranteed to be 4- or 8-byte aligned. Copy the words out instead.

Fixes #953

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:40:00 +02:00
Ludovic Marie bb24420df2 Carry: Lithostitched's apply_random, condition and set_block as the game's
apply_random becomes horizon:apply_random: its weighted lists, or its set
of lists at weight 1, with the inline lists carried like any other (their
Java processors dropped and counted). condition becomes horizon:condition
when the game runs every condition in it (true, all_of, any_of, not,
random_chance, matching_blocks with plain property values), with its then
and else lists carried. set_block with a simple or weighted state provider
and no block entity change becomes horizon:set_block. Anything else stays
Java and is dropped as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:29:23 +02:00
Ludovic Marie 2647ed7ed0 Structure processors: Lithostitched's apply_random, condition and set_block as data
horizon:apply_random runs one processor list drawn by weight
(WeightedList.getRandom); horizon:condition runs `then` or `else` by a
test of the block (true, all_of, any_of, not, random_chance and
matching_blocks on the placed or the existing block). Both take their
random from Lithostitched's RandomSettings: seeded with the world seed
plus the name's hash, forked positionally at the block, the piece or the
structure's pivot. process_block now gets the piece's position for it.

horizon:set_block is Lithostitched's set_block with a simple or weighted
state provider: the block becomes the state (drawn at the chosen position
from the unsalted seed), keeping the properties it shares with the old one
unless preserve_state is off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:28:57 +02:00
Ludovic Marie 8993bd4594 Merge pull request #949 from rdbtCVS/t3/reuse-terrain-sampler-scratch
🤖 Agent: merged, thanks rdbt! Terrain sampler scratch buffers are reused between chunks; byte-identical output across the 22 world-gen parity harnesses on the combined commit.
2026-10-19 04:21:05 +02:00
Ludovic Marie 764b4e0803 Merge pull request #948 from rdbtCVS/t3/fix-issue-945
🤖 Agent: merged, thanks rdbt! Spectator scroll-wheel flight speed now follows vanilla (6,791 oracle cases); verified on the combined commit with local_input and the client tests. Fixes #945.
2026-10-19 04:20:53 +02:00
Ludovic Marie ea8964506c Merge pull request #946 from rdbtCVS/t3/dedup-neighbour-computation
🤖 Agent: merged, thanks rdbt! Checked on one commit with #948 and #949: fmt, workspace clippy -D warnings, 896 world/core/client tests, and 22 parity harnesses (biome, carving, decoration, density, structure_density, server_world_gen, world_spawn, …) all pass.
2026-10-19 04:20:41 +02:00
Ludovic Marie 8e095b88fa Carry: write Lithostitched's processor references in
lithostitched:reference runs the processors of other lists in turn.
Carry now writes their processors in its place, in order and references
in them too, from the mod's own processor lists. A reference to a tag or
to a list the mod lacks stays, and is dropped and counted as before.
ChoiceTheorem's Overhauled Village builds most of its lists this way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:17:42 +02:00
Ludovic Marie ca790e8dba Far terrain: a third of the render-thread work per frame
Lod::update sorted every unsampled plan node each frame to take at most
four (none while every sample slot is busy), and woke the workers every
frame. It now skips the selection while the slots are full, keeps only
the best 2 * (SAMPLE_JOBS + pending) entries before sorting (a key is
listed at most twice, so the same tiles are taken in the same order),
takes the best fallback with min(), and wakes the workers only when a job
was queued. A finished chunk's detail now goes straight to the tile at
each level 0-4 holding it instead of scanning every ready tile (the others
never overlapped it).

Mac mini, RD12, LOD 256 while far terrain generates, `sample` of the main
thread over 30 s, alternating: Lod::update 10.4 % and 12.3 % of the
samples before, 3.4 % and 3.5 % after; update_world 3497 and 3373
samples before, 668 and 864 after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:08:00 +02:00