BlockCollisionScan asked every cursor cell for its collision shape,
moved it into place and intersected it with Shapes.create(box), even
for air. Mob movement and every other Entity.collide spent most of
their time there. Now:
- CollisionBlock carries empty_shape, set by the registry for states
with no contextual rule and an empty cached shape (air, plants): the
scan skips them without asking. Providers that build CollisionBlock
themselves (the query-order fixture) leave it false, so their query
logs are unchanged.
- A shape whose bounds miss the box is skipped before moving it:
joinIsNotEmpty(AND) of the two is false anyway.
- Shapes.create(box) is built the first time a shape is not the unit
cube (finite bounds always make one), not for every scan.
- SceneCollisions hands the scan the resident chunk itself, so a cell
costs one section read instead of a chunk-map lookup.
Results are unchanged: running both paths side by side over 900,000
mob moves in a 600-mob village gave bit-identical movement.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A creative player with game master commands (Player.canUseGameMasterBlocks)
places command, chain and repeating command blocks and opens
CommandBlockEditScreen on them: the command, its previous output with the
O/X tracking toggle, Impulse/Chain/Repeat, Conditional and Needs
Redstone/Always Active, applied as handleSetCommandBlock does.
The block entity (CommandBlockEntity with BaseCommandBlock) saves and
loads its vanilla fields. CommandBlock.tick runs impulse blocks on a
rising signal, repeating blocks every tick while powered or always
active, and the chain in front (executeChain), honouring conditional
blocks, command_blocks_work and max_command_sequence_length. Commands
run through the command system as the block (position, facing, game
master level); their feedback becomes the block's last output and the
[@: ...] broadcast under command_block_output. Comparators read the
success count.
Fixes#444
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The player's portal timer reset to zero on any tick outside a portal and
came back from a trip with a 300-tick cooldown that only ran down outside
portals; the overworld exit search covered 32 blocks of loaded chunks;
nothing but the player could use a portal.
The player now follows Entity.setAsInsidePortal / handlePortal with
PortalProcessor (decay by 4, the cooldown of 10 that a portal keeps
resetting, players_nether_portal_default/creative_delay), and
NetherPortalBlock.getPortalDestination through the new
horizon_world::level::portal_travel: PortalForcer.findClosestPortalPosition
(16 / 128 blocks, loaded and saved chunks), createPortal,
BlockUtil.getLargestRectangleAround, PortalShape.getRelativePosition and
findCollisionFreePosition, with the turned yaw and motion and
block.portal.travel. LocalPlayer.handlePortalTransitionEffect closes
screens and plays block.portal.trigger. Items and mobs go through after one
tick with a 300-tick cooldown and wait as saved entities until their
dimension loads around the exit.
tools/test_nether_portal_parity.py compares the destination with vanilla's
getPortalDestination over two headless levels; the scene motion harness
gains portal fixtures for the player's processor and cooldown.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Horizon searched its own spiral of 48-block steps from 0 0 for a dry,
non-leaf top block, so seed 1891623539983467248 spawned at -48 -48 where
vanilla puts the world spawn at 144 71 144 (the player then lands within
the respawn radius, 152 145 in the report).
Vanilla (MinecraftServer.setInitialSpawn): NoiseBasedChunkGenerator.
getOrigin runs NoiseSpawnFinder over the noise settings' spawn_target
points (SpawnTargetPoint.sampleFitness, a 2048/512 then 512/32 radial
search biased towards 0 0); an 11 by 11 chunk spiral around that chunk
takes the first column PlayerSpawnFinder.getSpawnPosInChunk accepts
(getLevelRespawnPos: MOTION_BLOCKING, WORLD_SURFACE and OCEAN_FLOOR
heights, no liquid, a full-topped collision shape); without one, the
origin chunk's centre at the spawn height. The first player is then
placed by PlayerSpawnFinder.findSpawn: the respawn-radius square in a
random coprime order, a free player box with liquids colliding, else the
spawn with fixupSpawnHeight; adventure mode uses the spawn as is.
horizon-world gains worldgen::spawn_finder and OverworldGenerator::origin;
the client's world_spawn module and game/initial_spawn.rs follow
setInitialSpawn and PlayerSpawnFinder, for single player and the
dedicated server alike. Flat worlds use FlatLevelSource's origin and
spawn height.
tools/test_world_spawn_parity.py compares, for the report's seed, the
chunk harness's seeds and 50 random ones, the origins
(VanillaWorldSpawnOracle against the spawn_origin example) and the
level.dat spawn of worlds created by the vanilla dedicated server and by
Horizon's. Vanilla is not deterministic on chunk corners where trees of
neighbouring chunks overlap (decoration order follows its worker
threads), so a mismatching seed reruns vanilla up to three times.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new harness decorates a 13x13-chunk area around each site, on both sides,
in the order vanilla's chunk scheduler uses around a player standing there
(chunk_dump HORIZON_LIST_ORDER prints decoration_order::vanilla_order), and
compares every block state, quart biome, block entity and scheduled tick:
the two reported spots on seed 1891623539983467248 (taiga trees at
204 -239; a stronghold with sculk and a geode at 4870 401), eleven tree-heavy
biomes and the nearest mineshaft, village, ancient city and trial chambers of
two seeds. 21 sites, 3,549 chunks, 0 differences.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both dumps list each proto chunk's scheduled block and fluid ticks in
scheduling order (`t block|fluid NAME X Y Z PRIORITY`) and the harness
compares them: they run once the chunk is live, and the leaf ticks of
updateShapeAtEdge were missing without any block differing at FEATURES.
HORIZON_ORDER names a file of `x z` lines both sides decorate in, instead of
row-major: decoration is order dependent (a chunk's features write into its
neighbours), and vanilla's chunk system decorates around a player in its own
order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LevelChunk.removeBlockEntity calls setRemoved: a jukebox reports its song
stopping (the jukebox_stop_play game event and level event 1011) and a
beacon plays its deactivation, whatever the flags. A record popped from a
replaced jukebox stops a playing song first and updates the neighbours as
JukeboxBlockEntity.onSongChanged does (a redstone wire beside it can pop).
The block update oracle removes block entities the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Explosion drops keep their random sequences and the pot's dynamic drops;
/setblock destroy and /fill destroy run Level.destroyBlock through the
behaviour library, so the block entity spills as vanilla's does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LevelChunk.setBlockState now runs BlockEntity.preRemoveSideEffects and
removes the block entity when a block with one is replaced by another
block (copper chests and copper golem statues keep theirs across
weathering; UPDATE_SKIP_BLOCK_ENTITY_SIDEEFFECTS skips the side effects).
Containers spill every slot through Containers.dropItemStack (spot and
pieces of 10 to 30 with triangular motions from the level random, empty
slots still drawing their spot), jukeboxes pop their record, lecterns
their book; shulker boxes keep their contents for the dropped box.
Campfires, decorated pots, chiseled bookshelves and shelves, which Horizon
keeps as loaded, spill too.
Block.dropResources now draws its loot and pop spots when the behaviour
calls it, not after it returns, and spawnAfterBreak awards ore, sculk and
spawner experience. Item entities and orbs the behaviour makes are added
before it returns to the game, in the same tick. Player mining follows
ServerPlayerGameMode.destroyBlock's order (removal and spill, tool wear,
then the drops); explosions let the removal spill the contents.
ExperienceOrb.award draws the merge id from the level random and moves
the orb with its own random. Decorated pots copy their decorations and
drop their sherds when cracked (loot tables' dynamic entries).
The block update oracle replays preRemoveSideEffects too, and the new
block removal harness (tools/test_block_removal_parity.py) compares
setBlock/destroyBlock/removeBlock on every block entity holder with
contents against vanilla: 2000/2000 cases match.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
block_entity_anim now also ports ChestLidController (chests, trapped and
copper chests, ender chests: triggerEvent(1, openCount), tickLid,
getOpenness), ChestBlock.opennessCombiner and ChestRenderer's lid curve,
and EnchantingTableBlockEntity.bookAnimationTick with its render state
(nearest non-spectator player by feet position within 3 blocks, Mth.atan2,
the class's shared RANDOM). The renderer pairs a double chest half with its
neighbour only as DoubleBlockCombiner does (same block, other half, same
facing) and reads the book from BlockAnim instead of ticking its own copy.
The game keeps a BlockEntityAnims and runs the client tickers of every
loaded animated block entity each tick: chest lids, books, shulker boxes,
bells (resonance sound, entity-effect particles, raider glow), conduits
(nautilus particles) and dragon/piglin heads. Opening and closing chests,
ender chests and shulker boxes sends the opener-count block event (both
halves of a double chest); a ring's block event reaches the bell through a
new LevelEvent::BlockEntityEvent. The renderer now gets this state instead
of BlockAnim::default(), so shulker lids, bells, conduits and heads move.
block_entity_anim harness: 256/256 cases (new: 48 chest, 36 book).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Formats the overnight parity work, fixes the lints it introduced, and
updates the LAN bot test and mob AI probe for fields added on the other
side of the merges (the bot test also set a field that never existed).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Uncommitted changes the agent had in progress when it was stopped; may not
build or pass its harnesses yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The chunk generation harness found 70 differing chunks across three seeds in
the overworld, Nether and End. Proto chunks, biomes and decoration now span
the dimension type's build range rather than the noise height, so features
above y=128 in the Nether and End city upper floors survive; the decoration
level reports no sky light, as unlit vanilla chunks do, so mushrooms and crops
pass or fail their light checks the same way; beehive decorators store their
bees; iceberg ellipses skip NaN distances; double slabs never waterlog;
mineshaft spawners save an empty SpawnPotentials list; and the dump example
forgets structure starts between rectangles, as the oracle starts each with
fresh chunks.
The oracle prints absent block entity keys as vanilla loads them from an empty
tag, and the harness treats vanilla's save-format equivalences (plain sign
text, absent empty banner patterns, unfiltered sign messages) as equal. All 2,352
chunks over 225 structure sites match with zero block, biome or block entity
differences.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The oracle now gives comparators and lecterns real block entities, so a
lectern whose state has a book reads page progress 1 of an empty book and
signals 14. The fixture's stand-in block entities now do the same, and the
redstone harness matches on 8,000 of 8,000 cases with a second seed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The random tick oracle now stands on a real overworld: the data pack's
dimension type (for fire's infiniburn tag), its attributes and day timeline
on a clock at the fixture's day time, level data for difficulty, and block
scans that walk positions in BlockScanUtils' section order, since 26.3 reads
chunk sections the map-backed level does not have.
Horizon now rolls the nether portal's zombified piglin spawn with the level
random (the client spawns it near a player), rechecks chest and ender chest
openers through a new block entity hook and broadcasts the lid event, gives
melting ice and placed sniffer eggs their game events, and reads the weather
age of copper golem statues, which name the field weatheringState. The
fixture prints empty dispensers, crafters, ghastling spawns and fresh
shriekers as vanilla resolves them.
Random ticks match on 39,998 of 39,998 compared cases (two propagules cannot
grow trees in the oracle), block updates on 40,000 of 40,000 and redstone on
3,999 of 4,000.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The block update oracle crashed on 625 cases because its constructor-less
level had no sound seed generator, attribute system or chunk source; it now
supplies them, keeps cave and void air apart from air, and creates block
entities on demand as a real level does. With those cases compared, Horizon
now primes TNT with the level random, sound and prime_fuse event at the
moment of priming, links powered wooden shelves into side chains, breaks
nether portals whose frame is no longer complete, reacts to power at command
blocks through a new block entity hook, rings bells with their block event,
uses the straw bed's own destroy particles and gives big dripleaf tilt changes
their vibration. Empty dispensers also emit block_activate in the client.
Block updates match on 40,000 of 40,000 cases and redstone on 3,999 of 4,000.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Work in progress on the block update differential harness fixtures and redstone/piston update fixes.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Adds the vanilla updateShape/neighborChanged oracle, the Rust fixture example and the Python driver, plus a handle_neighbor_changed entry point on Behaviours.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The new oracle drives vanilla's own chunk stages (structure starts and references, biomes, terrain with surface and carvers, then biome decoration with every placed feature and structure piece) through real WorldGenRegion instances, and the chunk_dump example runs the same stages in the same order in Horizon. The Python runner compares every block state, quart biome and block entity over terrain sites and structure sites found by scanning each seed, in the overworld, Nether and End, with phases that stop before features or run structure pieces only.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Apply clippy's fixes, fix the remaining lints by hand and allow, for the
whole workspace, the lints that one-to-one ports of vanilla's Java
naturally trip (argument counts, index loops, nested types, large enum
variants).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tree fixture world now applies vanilla's edge shape updates for its
obstacles (faceless vines, unsupported short grass), the vanilla fixture
world answers environment attributes with defaults, and features that
need structure templates or the pale moss registry, directly or through
named features, are left to the decoration harnesses. The scene probes
build their scene with World::test_scene since TestWorld was removed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Oracles reference shared helper oracles (heightmap, level shape...) that
javac could not find when only the entry files were listed. Also let
chunkgen_bench list unsupported features (HORIZON_LIST_UNSUPPORTED=1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve the places where union merges kept both sides: the persist
rewrite of level.dat now carries item components, XP seed and effects;
mob ticking uses the creatures module (with Thorns); explosions damage
mobs through the new damage source and emit particles; TNT's white
flash moves to overlay 5 since clouds use 4; End gateway data follows
the new dimensions/ folder layout.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Legacy jigsaw elements apply STRUCTURE_AND_AIR last, after jigsaw
replacement (outposts no longer carve air where jigsaws sat).
- Templates without a known shape run StructureTemplate's neighbor shape
updates (updateShapeAtEdge, then updateFromNeighbourShapes) through
level::Behaviours: snowy grass under igloos, stair shapes and fence
connections in shipwrecks.
- The placement oracle keeps going through structure entities (a level
stand-in with no enabled features) and compares brushable-block loot.
With block behavior exports present, 18 chunks of seed 1 covering
villages, igloo, outpost, mineshafts, shipwreck, warm ocean ruin, buried
treasure, ruined portal, trial chambers, monument, mansion, stronghold,
ancient city, trail ruins and a jungle temple match vanilla exactly,
blocks and block-entity loot seeds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Dim::End (DIM1 region folder, End environment attributes, sky light).
- Eyes of ender fill End portal frames; a complete ring of twelve
(EndPortalFrameBlock portal shape) lights the 3x3 End portal.
- End portals travel to the End (obsidian platform at 100 49 0, facing
west) and back to the world spawn; dying in the End respawns in the
Overworld.
- Without the ender dragon the fight counts as won: the active exit
portal (EndPodiumFeature) and the first gateway of the seed's
shuffled ring are placed once the main island is loaded.
- End gateways: TheEndGatewayBlockEntity exit search (chunk scan,
findValidSpawnInChunk, END_ISLAND fallback, findTallestBlock), exit
gateways linked both ways and kept in DIM1/horizon-end-gateways.json;
worldgen return gateways lead exactly to the End spawn.
- End sky box (end_sky.png tiled, 0x282828), End portal and gateway
surfaces and the spike End crystals (EndCrystalModel animation).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VanillaStructurePlacementOracle generates vanilla terrain with live
structure starts and references for the 3x3 chunks around a target, runs
the structure part of applyBiomeDecoration through a WorldGenRegion-like
level and dumps the target chunk's blocks and block entities. The
structure_blocks example does the same with Horizon's generator
(GeneratorWorker::set_structures_only skips placed features) and
tools/compare_structure_blocks.py reports the differences.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chests, trapped chests and barrels written by world generation become
client containers; their loot tables are unpacked with the loot module
using the generated LootTableSeed and the container's biome. chunkgen_bench
can list generated block entities (HORIZON_BLOCK_ENTITIES).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New horizon_world::loot: pools, weighted and nested entries, the item
modifiers chest tables use (counts, damage, random and level-based
enchanting, potions, stew effects, instruments, filtered/discard),
conditions, the stack splitter and the slot shuffle, all with vanilla's
random draw order. tools/compare_loot_fill.py runs a new vanilla oracle
(VanillaLootFillOracle) against the loot_fill example: all 58 chest
tables match slot for slot over 42 seeds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Port NetherFortressPieces (bridge and castle piece weights, children,
moveInsideHeights, chests and the blaze spawner) and NetherFossilStructure
(noise-column floor search, template piece with the dried ghast). The
structure-start oracle and chunkgen_bench take a dimension; seeds 1 and
12345 match vanilla on 5024 of 5025 Nether starts over 301x301 chunks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vanilla_diff compares Rust-decorated chunks with region files of a vanilla
world generated for the same seed; chunkgen_bench takes --dimension.
configure_end_gateway stores the exit of end_gateway_return gateways instead
of failing the feature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Port StructurePiece's orientation frame and block helpers, template pieces
with data markers, chest/dispenser loot block entities and the five
smaller legacy structures. Structure stubs use the chunk middle (block 8).
For seed 0 over 97x97 chunks all 35 starts of implemented structure types
match the vanilla oracle (pieces, boxes, positions).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Behaviours::placement_state exposes BlockItem placement-state selection
without writing to the level; tools/test_level_place_parity.py compares it
with vanilla (VanillaPlacementOracle) over random neighbourhoods: 20000/20000
cases match. PlaceContext gains can_use_game_master_blocks. Level module
formatted with rustfmt.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Templates store palette states as id/properties; reading only Name made
every template block air. Add a vanilla oracle (structure placement, start
selection and Structure.generate over a chunk rectangle), a bench mode
dumping Rust starts in the same format, and a comparison script. For seed
0 over 97x97 chunks all 15 jigsaw starts (villages, trial chambers, trail
ruins, abandoned camps) match vanilla piece for piece.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
VanillaLevelShapeOracle evaluates BlockState.updateShape and canSurvive over
generated 5x5x5 neighbourhoods with a reflective LevelReader and records the
ticks requested through ScheduledTickAccess; level_shape_fixture does the same
through Behaviours. 40000/40000 random cases match. Walls, snow layers and sea
pickles now read position-dependent collision shapes (bamboo, speleothems,
shulker boxes) through DynamicSupport.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Port structure sets (random spread with frequency reducers and exclusion
zones), vanilla start selection, JigsawPlacement (pool aliases, shuffled
jigsaws by selection priority, placement-priority queue, free-space
checks, expansion hack, rigid/terrain-matching junctions) and pool
element placement. Proto generation computes per-chunk references within
8 chunks and feeds the beardifier into the noise fill; FEATURES places
referenced starts per decoration step before that step's features.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merge worktree-agent-a8b4c3c64b61988c7 (trees, ores, vegetation, lakes,
geodes, dungeons, icebergs, dripstone, fungus, end spikes). The decoration
world now supplies the world seed, the write-zone check, raw section
writes for bulk ore placement and full-block collision tests.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Unit tests pin Java HashSet bucket iteration, Fisher-Yates draw order and
the seed-derived End spike layout. The oracle ignores sounds, level
events and entity queries; the Rust fixture accepts end-gateway
configuration; FEATURE_FILTER limits a rerun to matching features.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Adds minecraft:speleothem_cluster (Column scans, pools, merged tips) and
minecraft:large_dripstone (wind offsets, base embedding, height curve).
The differential harness now resolves named features and placed features
lazily on the Java side, logs dungeon loot/spawner block entities, uses
the world seed and survival rules, and exercises every other configured
feature over surface, cave, flooded-cave, ocean and nether worlds.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>