From e994c8ab95007e4b872999d692c2f361155cf3ed Mon Sep 17 00:00:00 2001 From: Ludovic Marie <136255825+ludovic111@users.noreply.github.com> Date: Wed, 14 Oct 2026 19:09:46 +0200 Subject: [PATCH] release: the macOS smoke run opens a world (from a scratch folder) and checks it drew one Without --world the client stays on the title screen: 300 frames and no chunks. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 17 ++++++++++------- docs/release-flow.md | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cd2ad5ce0..f7b6c68ac 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -146,19 +146,22 @@ jobs: if: runner.environment == 'self-hosted' run: | set -euo pipefail + # From a scratch folder: the game keeps its saves and options in the folder it starts in. home="$RUNNER_TEMP/horizon-smoke" rm -rf "$home" && mkdir -p "$home" version=$(sed -n 's/.*"version": *"\([^"]*\)".*/\1/p' research-lock.json | head -1) - HORIZON_HOME="$home" HORIZON_NO_AUDIO=1 target/release/horizon-client \ - --resources ".local/horizon-client/$version" --offscreen --render-distance 4 --seed 1 \ - --frames 300 --timeout-seconds 180 --smoke-report "$home/smoke.json" > "$home/client.log" 2>&1 \ - || { tail -40 "$home/client.log"; exit 1; } + client="$PWD/target/release/horizon-client" + resources="$PWD/.local/horizon-client/$version" + (cd "$home" && HORIZON_HOME="$home" HORIZON_NO_AUDIO=1 "$client" --resources "$resources" --offscreen \ + --world smoke --seed 1 --render-distance 4 --frames 300 --timeout-seconds 180 \ + --smoke-report "$home/smoke.json" > "$home/client.log" 2>&1) || { tail -40 "$home/client.log"; exit 1; } python3 - "$home/smoke.json" <<'EOF' import json, sys report = json.load(open(sys.argv[1])) - print({key: report.get(key) for key in ("adapter", "presented_frames", "resident_chunks", "error")}) - if report.get("error") is not None or report.get("presented_frames") != 300 or not report.get("resident_chunks"): - sys.exit("the smoke run did not draw a world: " + json.dumps(report)[:2000]) + print(json.dumps(report)) + if report.get("error") is not None or report.get("frames") != 300 or not report.get("chunks") \ + or not report.get("meshed_sections") or not report.get("player"): + sys.exit("the smoke run did not draw a world") EOF - name: Package run: | diff --git a/docs/release-flow.md b/docs/release-flow.md index ac2598fc6..e5a04ac64 100644 --- a/docs/release-flow.md +++ b/docs/release-flow.md @@ -130,7 +130,7 @@ the notes. | --- | --- | --- | | `horizon-linux-x86_64.tar.gz` | GitHub `ubuntu-22.04` (an older glibc, so it runs on any recent distribution) | the standard loader and libraries only (`tools/check_imports.py`) | | `horizon-windows-x64.zip` | GitHub `windows-latest`, C runtime linked in | system DLLs only (`tools/check_imports.py`) | -| `horizon-macos-arm64.zip` | The Mac mini's runner (`vars.MAC_RUNNER=macos-latest` sends it to GitHub) | system libraries only (`otool -L`); a 300-frame offscreen run of a new world with resources prepared from the runner's own Minecraft (`--offscreen --frames 300 --smoke-report`) | +| `horizon-macos-arm64.zip` | The Mac mini's runner (`vars.MAC_RUNNER=macos-latest` sends it to GitHub) | system libraries only (`otool -L`); a 300-frame offscreen run of a new world with resources prepared from the runner's own Minecraft (`--offscreen --world smoke --frames 300 --smoke-report`: frames drawn, chunks generated and meshed, a player, no error) | Each builds `horizon-client`, `horizon-ctl` and `horizon-prepare` in release mode, checks all three exist, starts each one (`--help`, `--version`), packages the folder with `cargo run -p xtask -- package` and archives it. The