From b470bec351a8c572e26e9efcc17229093cd95b7f Mon Sep 17 00:00:00 2001 From: Ludovic Marie <136255825+ludovic111@users.noreply.github.com> Date: Sun, 25 Oct 2026 09:35:25 +0100 Subject: [PATCH] Cleanup: one lock helper in horizon-bots, the predicate helper beside its trait The twenty unwrap_or_else(|e| e.into_inner()) calls become one lock() helper, so the bots read as they did with the same poison tolerance. bound_property moves from worldgen.rs (between DecodeError's impls) to block_predicate.rs, next to PredicateBlockResolver, whose predicate_property it implements. Co-Authored-By: Claude Opus 5.5 --- crates/horizon-bots/src/main.rs | 109 ++++++------------ crates/horizon-world/src/worldgen.rs | 17 --- .../src/worldgen/block_feature.rs | 2 +- .../src/worldgen/block_predicate.rs | 16 +++ .../src/worldgen/state_provider.rs | 2 +- 5 files changed, 53 insertions(+), 93 deletions(-) diff --git a/crates/horizon-bots/src/main.rs b/crates/horizon-bots/src/main.rs index 666ead349..66326a74e 100644 --- a/crates/horizon-bots/src/main.rs +++ b/crates/horizon-bots/src/main.rs @@ -173,6 +173,11 @@ impl Random { } } +/// One bot thread that panics poisons the locks it held; the others and the report go on. +fn lock(m: &Mutex) -> std::sync::MutexGuard<'_, T> { + m.lock().unwrap_or_else(std::sync::PoisonError::into_inner) +} + fn raw(id: i32, write: impl FnOnce(&mut Writer)) -> Vec { let mut w = Writer::new(); w.varint(id); @@ -329,7 +334,7 @@ fn read( ) { use ids::play::clientbound as cb; use ids::play::serverbound as sb; - let send = |body: Vec| writer.lock().unwrap_or_else(|e| e.into_inner()).send(&body); + let send = |body: Vec| lock(&writer).send(&body); let mut seen = HashSet::new(); let mut batch = BatchSize::new(); let mut teleports = 0u64; @@ -338,7 +343,7 @@ fn read( Ok(packet) => packet, Err(e) => { if bot.online.swap(false, Ordering::SeqCst) { - *bot.error.lock().unwrap_or_else(|e| e.into_inner()) = Some(e.to_string()); + *lock(&bot.error) = Some(e.to_string()); } return; } @@ -356,12 +361,7 @@ fn read( cb::LEVEL_CHUNK_WITH_LIGHT => { bot.chunks.fetch_add(1, Ordering::Relaxed); if let (Ok(x), Ok(z)) = (r.i32(), r.i32()) { - if !bot - .held - .lock() - .unwrap_or_else(|e| e.into_inner()) - .insert((x, z)) - { + if !lock(&bot.held).insert((x, z)) { bot.resent.fetch_add(1, Ordering::Relaxed); } if seen.insert((x, z)) { @@ -373,11 +373,7 @@ fn read( cb::FORGET_LEVEL_CHUNK => { if let Ok(play::Clientbound::ForgetLevelChunk(p)) = play::Clientbound::decode(id, &body) - && bot - .held - .lock() - .unwrap_or_else(|e| e.into_inner()) - .remove(&(p.pos[0], p.pos[1])) + && lock(&bot.held).remove(&(p.pos[0], p.pos[1])) { bot.forgotten.fetch_add(1, Ordering::Relaxed); } @@ -398,7 +394,7 @@ fn read( } cb::PLAYER_POSITION => match play::Clientbound::decode(id, &body) { Ok(play::Clientbound::PlayerPosition(p)) => { - let mut at = bot.teleport.lock().unwrap_or_else(|e| e.into_inner()); + let mut at = lock(&bot.teleport); let previous = at.unwrap_or([0.0; 3]); // Relative flags: X 1, Y 2, Z 4. let pos: [f64; 3] = std::array::from_fn(|i| { @@ -429,18 +425,17 @@ fn read( }, cb::DISCONNECT | cb::START_CONFIGURATION => { bot.online.store(false, Ordering::SeqCst); - *bot.error.lock().unwrap_or_else(|e| e.into_inner()) = - Some(if id == cb::DISCONNECT { - format!( - "disconnected: {}", - String::from_utf8_lossy(&body) - .chars() - .filter(|c| !c.is_control()) - .collect::() - ) - } else { - "sent back to configuration".into() - }); + *lock(&bot.error) = Some(if id == cb::DISCONNECT { + format!( + "disconnected: {}", + String::from_utf8_lossy(&body) + .chars() + .filter(|c| !c.is_control()) + .collect::() + ) + } else { + "sent back to configuration".into() + }); return; } _ => Ok(()), @@ -465,7 +460,7 @@ fn run_bot( let connection = match join(&o, &name) { Ok(c) => c, Err(e) => { - *bot.error.lock().unwrap_or_else(|e| e.into_inner()) = Some(e); + *lock(&bot.error) = Some(e); return; } }; @@ -479,18 +474,12 @@ fn run_bot( use ids::play::serverbound as sb; // Wait for the spawn position. let spawn = loop { - if let Some(at) = *bot.teleport.lock().unwrap_or_else(|e| e.into_inner()) { + if let Some(at) = *lock(&bot.teleport) { break at; } if !bot.online.load(Ordering::SeqCst) || asked.elapsed() > Duration::from_secs(60) { - if bot - .error - .lock() - .unwrap_or_else(|e| e.into_inner()) - .is_none() - { - *bot.error.lock().unwrap_or_else(|e| e.into_inner()) = - Some("no spawn position within 60 s".into()); + if lock(&bot.error).is_none() { + *lock(&bot.error) = Some("no spawn position within 60 s".into()); } return; } @@ -498,13 +487,7 @@ fn run_bot( }; bot.joined_after_ms .store(asked.elapsed().as_millis() as u64, Ordering::SeqCst); - let send = |body: Vec| { - writer - .lock() - .unwrap_or_else(|e| e.into_inner()) - .send(&body) - .is_ok() - }; + let send = |body: Vec| lock(&writer).send(&body).is_ok(); send(raw(sb::PLAYER_LOADED, |_| {})); let mut random = Random(o.seed ^ (index as u64).wrapping_mul(0x2545_F491_4F6C_DD1D)); let mut pos = spawn; @@ -513,30 +496,15 @@ fn run_bot( let mut target = pos; let mut next = Instant::now(); loop { - if until - .lock() - .unwrap_or_else(|e| e.into_inner()) - .is_some_and(|u| Instant::now() >= u) - || !bot.online.load(Ordering::SeqCst) - { + if lock(&until).is_some_and(|u| Instant::now() >= u) || !bot.online.load(Ordering::SeqCst) { break; } // A teleport from the server wins over where the bot thought it was. - if let Some(at) = bot - .teleport - .lock() - .unwrap_or_else(|e| e.into_inner()) - .take() - { + if let Some(at) = lock(&bot.teleport).take() { pos = at; } let here = ((pos[0].floor() as i32) >> 4, (pos[2].floor() as i32) >> 4); - if !bot - .held - .lock() - .unwrap_or_else(|e| e.into_inner()) - .contains(&here) - { + if !lock(&bot.held).contains(&here) { bot.waited.fetch_add(1, Ordering::Relaxed); } else if pos[1] < cruise { pos[1] = (pos[1] + 0.5).min(cruise); @@ -593,7 +561,7 @@ fn run_bot( } // Offline first, so the reader doesn't count the closed connection as a failure. bot.online.store(false, Ordering::SeqCst); - writer.lock().unwrap_or_else(|e| e.into_inner()).shutdown(); + lock(&writer).shutdown(); } fn behaviour_of(mode: &str, index: usize) -> Behaviour { @@ -647,14 +615,10 @@ fn main() { let total = |f: fn(&Bot) -> &AtomicU64| -> u64 { bots.iter().map(|b| f(b).load(Ordering::Relaxed)).sum() }; - let failed = bots - .iter() - .filter(|b| b.error.lock().unwrap_or_else(|e| e.into_inner()).is_some()) - .count(); + let failed = bots.iter().filter(|b| lock(&b.error).is_some()).count(); if first.is_none() && online > 0 { first = Some(Instant::now()); - *until.lock().unwrap_or_else(|e| e.into_inner()) = - Some(Instant::now() + Duration::from_secs(o.seconds)); + *lock(&until) = Some(Instant::now() + Duration::from_secs(o.seconds)); } println!( "{}", @@ -672,13 +636,10 @@ fn main() { }) ); previous_chunks = chunks; - let over = until - .lock() - .unwrap_or_else(|e| e.into_inner()) - .is_some_and(|u| Instant::now() >= u); + let over = lock(&until).is_some_and(|u| Instant::now() >= u); let all_failed = failed == o.bots; if over || all_failed || (first.is_none() && start.elapsed() > Duration::from_secs(120)) { - *until.lock().unwrap_or_else(|e| e.into_inner()) = Some(Instant::now()); + *lock(&until) = Some(Instant::now()); break; } } @@ -708,7 +669,7 @@ fn main() { "forgotten": b.forgotten.load(Ordering::Relaxed), "pulled_back": b.pulled_back.load(Ordering::Relaxed), "waited_ticks": b.waited.load(Ordering::Relaxed), - "error": *b.error.lock().unwrap_or_else(|e| e.into_inner()), + "error": *lock(&b.error), })).collect::>(), }); if o.report.as_deref() == Some("-") { diff --git a/crates/horizon-world/src/worldgen.rs b/crates/horizon-world/src/worldgen.rs index 294f96336..63de74d24 100644 --- a/crates/horizon-world/src/worldgen.rs +++ b/crates/horizon-world/src/worldgen.rs @@ -103,23 +103,6 @@ impl std::fmt::Display for DecodeError { } } impl std::error::Error for DecodeError {} - -/// The bound value of one physical block property, for the two decode contexts that read -/// block predicates (`block_feature` and `state_provider`). -pub(crate) fn bound_property( - values: Option<&[crate::block_properties::BoundBlockProperty; 4]>, - property: crate::block_properties::BlockProperty, -) -> Result { - use crate::block_properties::BlockProperty; - let values = values.ok_or(DecodeError::Field("predicate block property registry"))?; - let index = match property { - BlockProperty::Solid => 0, - BlockProperty::Replaceable => 1, - BlockProperty::Liquid => 2, - BlockProperty::SolidRender => 3, - }; - Ok(values[index].clone()) -} impl From for DecodeError { fn from(value: serde_json::Error) -> Self { Self::Json(value) diff --git a/crates/horizon-world/src/worldgen/block_feature.rs b/crates/horizon-world/src/worldgen/block_feature.rs index d943bd1be..0131b93e2 100644 --- a/crates/horizon-world/src/worldgen/block_feature.rs +++ b/crates/horizon-world/src/worldgen/block_feature.rs @@ -192,7 +192,7 @@ impl super::block_predicate::PredicateBlockResolver for FeatureBlockBindings<'_> &self, property: BlockProperty, ) -> Result { - super::bound_property(self.physical_properties.as_ref(), property) + super::block_predicate::bound_property(self.physical_properties.as_ref(), property) } fn predicate_biome_set( &self, diff --git a/crates/horizon-world/src/worldgen/block_predicate.rs b/crates/horizon-world/src/worldgen/block_predicate.rs index a4709abc2..7d27de22e 100644 --- a/crates/horizon-world/src/worldgen/block_predicate.rs +++ b/crates/horizon-world/src/worldgen/block_predicate.rs @@ -10,6 +10,22 @@ use horizon_core::geometry::Direction; use serde_json::value::RawValue; use std::{collections::BTreeSet, sync::Arc}; +/// `predicate_property` for resolvers that hold the bound physical properties +/// (`block_feature` and `state_provider`), in `BlockProperty` order. +pub(super) fn bound_property( + values: Option<&[BoundBlockProperty; 4]>, + property: BlockProperty, +) -> Result { + let values = values.ok_or(DecodeError::Field("predicate block property registry"))?; + Ok(values[match property { + BlockProperty::Solid => 0, + BlockProperty::Replaceable => 1, + BlockProperty::Liquid => 2, + BlockProperty::SolidRender => 3, + }] + .clone()) +} + /// Resolve a block holder set against the same immutable registry used by world /// queries. Unknown blocks/tags fail during decoding, even in unused branches. pub trait PredicateBlockResolver { diff --git a/crates/horizon-world/src/worldgen/state_provider.rs b/crates/horizon-world/src/worldgen/state_provider.rs index e261192f9..93005b86f 100644 --- a/crates/horizon-world/src/worldgen/state_provider.rs +++ b/crates/horizon-world/src/worldgen/state_provider.rs @@ -186,7 +186,7 @@ impl PredicateBlockResolver for StateProviderBindings<'_> { &self, property: BlockProperty, ) -> Result { - super::bound_property(self.physical_properties.as_ref(), property) + super::block_predicate::bound_property(self.physical_properties.as_ref(), property) } fn predicate_biome_set( &self,