Merge pull request #2010 from Domanffe/perf/skip-lookup-once

🤖 Agent: contrib-gate-17 verified this head (26.3 sources, integration tree build, clippy, tests, parity; details in the PR comment). Thanks @Domanffe!
2026-10-26 14:13:29 +01:00
parent 8087d8bf58 11eb74b0b6
commit 7b94de404e
1 changed files with 19 additions and 15 deletions
@@ -951,21 +951,25 @@ fn draw_normals(
        return;
    }
    let normals = normals.part(p);
-    for poly in part.polygons.iter().filter(|_| !poses.skips(part)) {
-        let normal = poly.vertex_normal(normals);
-        for v in poly.vertices {
-            let pos = m.transform_point3(glam::Vec3::new(v[0], v[1], v[2]) / 16.0);
-            out.push(Vertex {
-                normal,
-                pos: pos.to_array(),
-                uv: [
-                    uv[0] + (uv[2] - uv[0]) * v[3],
-                    uv[1] + (uv[3] - uv[1]) * v[4],
-                ],
-                layer: overlay,
-                color,
-                light,
-            });
+    // `skips` is a name lookup: ask once per part, not once per polygon. A part
+    // hidden this way still draws its children, so only the polygons are gated.
+    if !poses.skips(part) {
+        for poly in &part.polygons {
+            let normal = poly.vertex_normal(normals);
+            for v in poly.vertices {
+                let pos = m.transform_point3(glam::Vec3::new(v[0], v[1], v[2]) / 16.0);
+                out.push(Vertex {
+                    normal,
+                    pos: pos.to_array(),
+                    uv: [
+                        uv[0] + (uv[2] - uv[0]) * v[3],
+                        uv[1] + (uv[3] - uv[1]) * v[4],
+                    ],
+                    layer: overlay,
+                    color,
+                    light,
+                });
+            }
        }
    }
    for c in &part.children {