From 6d1f6965d23ec297186704fcdc43df40ea17a4f0 Mon Sep 17 00:00:00 2001 From: Alexander Krylov Date: Sun, 25 Oct 2026 03:57:00 +0300 Subject: [PATCH] Packs: an untouched vanilla directory is mirrored on Windows too (#1688) link cannot symlink a directory on Windows, so mirror has to recurse into one itself, but it only did so when a pack had filters. An untouched directory fell through to the link branch and vanished from the overlay, which took textures/font and the panorama with it and made a pack that overrides a font crash the client before its window. --- crates/horizon-client/src/packs.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/horizon-client/src/packs.rs b/crates/horizon-client/src/packs.rs index 5b4d11e82..1e012fd90 100644 --- a/crates/horizon-client/src/packs.rs +++ b/crates/horizon-client/src/packs.rs @@ -517,7 +517,11 @@ fn build_overlay_uncached( } } } else if touched.contains(&child) - || (vanilla.join(&child).is_dir() && !filters.is_empty()) + // Windows cannot link a directory the way unix does (`link` above), so an + // untouched one has to be mirrored: skipping it hid textures/font and the + // title panorama from the overlay, and a font json that names those sheets + // then failed to load (#1688). + || (vanilla.join(&child).is_dir() && (cfg!(not(unix)) || !filters.is_empty())) { mirror( &child,