From 622b9a3a953a370b49d528b9e4b2ea24bacce9e4 Mon Sep 17 00:00:00 2001 From: Ludovic Marie <136255825+ludovic111@users.noreply.github.com> Date: Mon, 19 Oct 2026 15:43:49 +0200 Subject: [PATCH] Releases: the Mac mini builds them from a clean checkout Its work folder is shared with pull requests' parity jobs; with clean: false, whatever they left (target/, an untracked .cargo/config.toml, a build script's output) could end up in a release. release.yml and launcher.yml now always check out clean; target/ is rebuilt from scratch, and vanilla-data.sh relinks .local/ from its preparations outside the checkout. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/launcher.yml | 5 +++-- .github/workflows/release.yml | 7 +++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/launcher.yml b/.github/workflows/launcher.yml index a898d567a..e7b55c64b 100644 --- a/.github/workflows/launcher.yml +++ b/.github/workflows/launcher.yml @@ -120,8 +120,9 @@ jobs: with: ref: ${{ needs.decide.outputs.head }} persist-credentials: false - # The Mac mini's runner keeps its target/ between runs. - clean: ${{ runner.environment == 'github-hosted' }} + # Always from a clean checkout, the Mac mini's runner too: its work folder is shared with pull requests' + # parity jobs, and nothing they leave may end up in a launcher release (target/ is rebuilt from scratch). + clean: true - uses: dtolnay/rust-toolchain@stable - uses: Swatinem/rust-cache@v2 if: runner.environment == 'github-hosted' diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1a4a89bf6..a8f5f9bb5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -102,8 +102,11 @@ jobs: with: ref: ${{ needs.decide.outputs.head }} persist-credentials: false - # On the Mac mini's runner, keep target/ (incremental) and .local/ (the prepared resources). - clean: ${{ runner.environment == 'github-hosted' }} + # Always from a clean checkout, the Mac mini's runner too: its work folder is shared with pull requests' + # parity jobs, and nothing they leave (target/, an untracked .cargo/config.toml, a build script's output) + # may end up in a release. target/ is rebuilt from scratch; .local/ is relinked by vanilla-data.sh, which + # keeps its preparations outside the checkout. + clean: true - uses: dtolnay/rust-toolchain@stable - uses: Swatinem/rust-cache@v2 if: runner.environment == 'github-hosted'