From 5f9f973295c5cc948a6999a849c2c843f5e831f6 Mon Sep 17 00:00:00 2001 From: Ludovic Marie <136255825+ludovic111@users.noreply.github.com> Date: Sun, 4 Oct 2026 12:22:10 +0200 Subject: [PATCH] Retain mixed overlay-aware Vulkan results and probe demo worlds --- .github/workflows/macos-vulkan-research.yml | 11 +- .../live-observations.json | 186 +++++++++++++++++- docs/client-graphics-smoke.md | 9 + 3 files changed, 204 insertions(+), 2 deletions(-) diff --git a/.github/workflows/macos-vulkan-research.yml b/.github/workflows/macos-vulkan-research.yml index adea87de5..e0d1d4f26 100644 --- a/.github/workflows/macos-vulkan-research.yml +++ b/.github/workflows/macos-vulkan-research.yml @@ -1,6 +1,11 @@ name: macOS Vulkan research on: workflow_dispatch: + inputs: + world: + description: Create or open disposable demo worlds instead of title probes + type: boolean + default: false permissions: contents: read jobs: @@ -18,15 +23,19 @@ jobs: - name: Build original mod and private probe dependencies run: python tools/build_mod.py - name: Probe vanilla, core and distant-terrain Vulkan cases + env: + HORIZON_GRAPHICS_WORLD: ${{ inputs.world }} run: | python - <<'PY' - import json, subprocess, sys + import json, os, subprocess, sys from pathlib import Path cases = [ ['--profile', 'baseline', '--backend', 'vulkan'], ['--profile', 'core-performance', '--backend', 'vulkan'], ['--profile', 'vulkan'], ] + if os.environ.get('HORIZON_GRAPHICS_WORLD') == 'true': + cases = [case + ['--world'] for case in cases] observations = [] for case in cases: result = subprocess.run([sys.executable, 'tools/test_client_graphics.py', '--native-display', *case], capture_output=True, text=True) diff --git a/benchmarks/mac-vulkan-2026-10-04/live-observations.json b/benchmarks/mac-vulkan-2026-10-04/live-observations.json index 4a1bf1538..3f0e640ee 100644 --- a/benchmarks/mac-vulkan-2026-10-04/live-observations.json +++ b/benchmarks/mac-vulkan-2026-10-04/live-observations.json @@ -152,7 +152,8 @@ "Baseline includes the same original measurement mod and private test fixture; no core optimization mods or distant terrain.", "Full logs, screenshots, game binaries and assets remain private.", "Later selected stack locations place the observed failures in the screenshot callback; the independently logged Vulkan identifier is not established as their cause.", - "Actual assertions rejected uniform callback images in all three cases. Overlay state was not recorded, and displayed-window correctness is not established." + "Actual assertions rejected uniform callback images in all three cases. Overlay state was not recorded, and displayed-window correctness is not established.", + "After guarding overlays, core/distant-terrain title readbacks pass but vanilla remains uniform; the aggregate research run fails. No world-rendering or physical-M2 claim." ], "later_stack_run": { "source_commit": "a77476b54e7bf4a1b3a96cb9d8108ed7c1c7b2b0", @@ -515,5 +516,188 @@ ] } ] + }, + "later_overlay_run": { + "source_commit": "a1d8c1b8246008ac4076cdcaf0f64c71eaf4c767", + "run_url": "https://github.com/ludovic111/minecraft-optimization-lab/actions/runs/37194690645", + "cases": [ + { + "case": [ + "--profile", + "baseline", + "--backend", + "vulkan" + ], + "exit_code": 1, + "failure": [ + { + "exit_code": 1, + "result_count": 0, + "java_exception_types": [ + "java.lang.AssertionError", + "java.lang.RuntimeException" + ], + "expected_demo_authentication_errors_observed": true, + "backend_attempts": [ + { + "backend": "Vulkan", + "operation": "load_library", + "result": "success" + }, + { + "backend": "Vulkan", + "operation": "create_device", + "result": "success" + } + ], + "created_devices": [ + { + "gpu": "Apple Paravirtual device", + "graphics_backend": "Vulkan", + "graphics_driver": "1.2.350 MoltenVK 1.4.2" + } + ], + "client_initializer_reached": true, + "readback_requested": true, + "readback_callback_received": true, + "readback_inspections": [ + { + "framebuffer_width": 1280, + "framebuffer_height": 646, + "sampled_pixels": 4160, + "distinct_sampled_rgb": 1 + } + ], + "probe_failure_categories": [ + "uniform_readback" + ], + "vulkan_error_codes": [ + "VK_ERROR_FEATURE_NOT_PRESENT" + ], + "fatal_jvm_error": false, + "observed_graphics_stack_methods": [ + "net.minecraft.client.Screenshot.lambda$takeScreenshot$1", + "com.mojang.renderpearl.backend.vulkan.DestructionQueue.rotate", + "com.mojang.renderpearl.backend.vulkan.VulkanCommandEncoder.submit", + "com.mojang.renderpearl.frontend.FrontendCommandEncoder.submit" + ], + "profile": "baseline", + "preferred_backend": "vulkan" + } + ] + }, + { + "case": [ + "--profile", + "core-performance", + "--backend", + "vulkan" + ], + "exit_code": 0, + "report": { + "schema": 1, + "platform": "macOS-26.6.2-arm64-arm-64bit", + "architecture": "arm64", + "minecraft": "26.3", + "original_mod_sha256": "e651ef49bc97486e8dacfd4b640465c442525cd645e2dba71ddea9fb64347dd8", + "results": [ + { + "observed_mode": "title", + "title_screen_observed": true, + "world_loaded": false, + "ready_client_ticks": 42, + "window_active": true, + "overlay_present": false, + "overlay_wait_ticks": 105, + "framebuffer_width": 1280, + "framebuffer_height": 646, + "sampled_pixels": 4160, + "distinct_sampled_rgb": 163, + "gpu": "Apple Paravirtual device", + "graphics_backend": "Vulkan", + "graphics_driver": "1.2.350 MoltenVK 1.4.2", + "private_png_sha256": "3c802923766cf9e7f45020bc2d858c23de655cb8e35fa058a050e7b09a1d3708", + "profile": "core-performance", + "preferred_backend": "vulkan", + "launcher_exit_code": 0, + "backend_attempts": [ + { + "backend": "Vulkan", + "operation": "load_library", + "result": "success" + }, + { + "backend": "Vulkan", + "operation": "create_device", + "result": "success" + } + ] + } + ], + "limits": [ + "Short scene startup and nonuniform framebuffer readback only.", + "World mode uses the ordinary limited demo; world files remain private.", + "No exhaustive gameplay, visual-correctness, FPS or M2 Pro performance claim.", + "Vulkan preference can fall back; inspect the observed backend.", + "PNG images, assets and full logs remain in the private runtime directory." + ] + } + }, + { + "case": [ + "--profile", + "vulkan" + ], + "exit_code": 0, + "report": { + "schema": 1, + "platform": "macOS-26.6.2-arm64-arm-64bit", + "architecture": "arm64", + "minecraft": "26.3", + "original_mod_sha256": "e651ef49bc97486e8dacfd4b640465c442525cd645e2dba71ddea9fb64347dd8", + "results": [ + { + "observed_mode": "title", + "title_screen_observed": true, + "world_loaded": false, + "ready_client_ticks": 42, + "window_active": true, + "overlay_present": false, + "overlay_wait_ticks": 122, + "framebuffer_width": 1280, + "framebuffer_height": 646, + "sampled_pixels": 4160, + "distinct_sampled_rgb": 163, + "gpu": "Apple Paravirtual device", + "graphics_backend": "Vulkan", + "graphics_driver": "1.2.350 MoltenVK 1.4.2", + "private_png_sha256": "3c802923766cf9e7f45020bc2d858c23de655cb8e35fa058a050e7b09a1d3708", + "profile": "vulkan", + "preferred_backend": "vulkan", + "launcher_exit_code": 0, + "backend_attempts": [ + { + "backend": "Vulkan", + "operation": "load_library", + "result": "success" + }, + { + "backend": "Vulkan", + "operation": "create_device", + "result": "success" + } + ] + } + ], + "limits": [ + "Short scene startup and nonuniform framebuffer readback only.", + "World mode uses the ordinary limited demo; world files remain private.", + "No exhaustive gameplay, visual-correctness, FPS or M2 Pro performance claim.", + "Vulkan preference can fall back; inspect the observed backend.", + "PNG images, assets and full logs remain in the private runtime directory." + ] + } + } + ] } } diff --git a/docs/client-graphics-smoke.md b/docs/client-graphics-smoke.md index 9e114e05c..56e04b01b 100644 --- a/docs/client-graphics-smoke.md +++ b/docs/client-graphics-smoke.md @@ -62,6 +62,8 @@ The manual **macOS Vulkan research** workflow separately probes vanilla, core an the distant-terrain Vulkan profile. It runs every case, retains selected successful and failed outcomes, and exits unsuccessfully when a case fails. Its exploratory results do not count as passing the required OpenGL checks. +Its optional `world` input selects disposable demo-world probes for every case; +the default still probes titles. Local Linux software OpenGL/Vulkan title readbacks passed. Early macOS OpenGL title checks for core and balanced also passed with **Apple Software Renderer**. @@ -89,6 +91,13 @@ counting readiness. This tests an initialization hypothesis while preserving the same nonuniform-image requirement. It is not evidence that the game's displayed Vulkan window was uniform or that a physical M2 GPU has the same problem. +After the overlay guard, run 37194690645 has mixed results: core and distant-terrain +title probes pass on the Apple Paravirtual Vulkan device, with no overlay and +nonuniform readback, then exit cleanly. Vanilla still fails the uniform-readback +assertion. The overall research run therefore remains failed. These outcomes +justify retaining the readiness guard; they do not establish the cause of the +remaining failure, full visual correctness, world rendering or physical M2 speed. + For an isolated private preference override: ```sh