From 24b26da5d6a2d9fcce961ef8fa289a5dda0bff10 Mon Sep 17 00:00:00 2001 From: Ludovic Marie <136255825+ludovic111@users.noreply.github.com> Date: Mon, 26 Oct 2026 02:19:17 +0100 Subject: [PATCH] server_ops_feedback: wait for the save's reply before the next step On the desktop runner (8 harnesses at a time) vanilla's save-all took 2 s, the whole step: the transcript ended before "Saved the game" and the harness failed with Horizon right. The save step now waits for that console line, on both sides, before its usual 2 s. Co-Authored-By: Claude Opus 5.5 --- tools/test_server_ops_feedback_parity.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/test_server_ops_feedback_parity.py b/tools/test_server_ops_feedback_parity.py index 2dd405517..f7b7a0e73 100644 --- a/tools/test_server_ops_feedback_parity.py +++ b/tools/test_server_ops_feedback_parity.py @@ -54,6 +54,9 @@ QUIET = [ ] CASES = {'broadcast': ({}, BROADCAST), 'quiet': ({'broadcast-console-to-ops': 'false'}, QUIET)} STEP_SECONDS = 2.0 +# Steps whose reply can take longer than a step: the next step waits for this console line first. A loaded machine +# took 2 s to save vanilla's world, and the transcript ended before "Saved the game". +WAIT_FOR = {'console-save': r'System chat: Saved the game'} def run_side(label, case, server_command, client_command, build, world): @@ -88,6 +91,8 @@ def run_side(label, case, server_command, client_command, build, world): server.console(command) for action in actions: tell(action) + if step in WAIT_FOR: + server.wait_for(WAIT_FOR[step], timeout=120) time.sleep(STEP_SECONDS) tell('end') client.wait(timeout=60)