From 1344df60f06887183f1f67f81eeee35c07afb4e4 Mon Sep 17 00:00:00 2001 From: Ludovic Marie <136255825+ludovic111@users.noreply.github.com> Date: Sat, 10 Oct 2026 18:34:26 +0200 Subject: [PATCH] Give the menu oracle's player an advancement tracker Taking a brewed potion fires BrewedPotionTrigger, which crashed the stand-in player without PlayerAdvancements. With an empty tracker the menu click harness matches on 6,000 of 6,000 cases. Co-Authored-By: Claude Opus 5.5 --- .../test/java/dev/horizonlab/parity/VanillaMenuOracle.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mods/horizon/src/test/java/dev/horizonlab/parity/VanillaMenuOracle.java b/mods/horizon/src/test/java/dev/horizonlab/parity/VanillaMenuOracle.java index a505cb0bc..af5ca6e3c 100644 --- a/mods/horizon/src/test/java/dev/horizonlab/parity/VanillaMenuOracle.java +++ b/mods/horizon/src/test/java/dev/horizonlab/parity/VanillaMenuOracle.java @@ -86,10 +86,13 @@ public final class VanillaMenuOracle { World world; boolean creative; Inventory inv; + // No advancements are granted, so criterion triggers find no listeners. + net.minecraft.server.PlayerAdvancements advancements; FakePlayer() { super(null, null, null, null); } @Override public Inventory getInventory() { return inv; } + @Override public net.minecraft.server.PlayerAdvancements getAdvancements() { return advancements; } @Override public ServerLevel level() { return world; } @Override public boolean hasInfiniteMaterials() { return creative; } @Override public boolean isCreative() { return creative; } @@ -166,6 +169,8 @@ public final class VanillaMenuOracle { var player = make(FakePlayer.class); player.world = world; player.creative = f.get("creative").getAsBoolean(); + player.advancements = make(net.minecraft.server.PlayerAdvancements.class); + set(player.advancements, net.minecraft.server.PlayerAdvancements.class, "activeTriggers", new java.util.IdentityHashMap<>()); set(player, ServerPlayer.class, "connection", make(Connection.class)); var inv = new Inventory(player, new EntityEquipment()); player.inv = inv;