Launcher: Windows tests check behaviour, not symlink paths
On Windows the launcher links another launcher's client jar with a hard link (a copy across volumes) and its libraries and assets with a junction, since symlinks need developer mode. canonicalize() of a hard link is its own path, so the sources tests, which compared canonical paths, failed on Windows and blocked every launcher release since launcher-v0.4.0. They now check that the linked jar is the launcher's file (a byte written through one shows in the other), which holds for a symlink and a hard link alike. The modpack profile test compares paths as paths rather than strings ending in "a/carry". mklink /J's paths are always quoted: Rust only quotes arguments with spaces, and cmd reads an unquoted & or ^ in a user folder as its own syntax. CI runs every launcher test target, not just the library's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -138,7 +138,8 @@ jobs:
|
||||
echo "::notice::No Metal toolchain on this runner: GPUI compiles its shaders at run time"
|
||||
echo "LAUNCHER_FEATURES=gpui/runtime_shaders" >> "$GITHUB_ENV"
|
||||
fi
|
||||
- run: cargo test --release --locked --lib ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
|
||||
# Every test target (the library, the binary, tests/), on each system the launcher ships for.
|
||||
- run: cargo test --release --locked ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
|
||||
- run: cargo build --release --locked ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
|
||||
- name: The version is the release's
|
||||
run: |
|
||||
|
||||
Reference in New Issue
Block a user